New issue
Advanced search Search tips

Issue 663025 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 664505



Sign in to add a comment

Fix and reenable browse:news:flipboard and browse:social:twitter system health story on Mac perf bots

Project Member Reported by eyaich@chromium.org, Nov 7 2016

Issue description

We are seeing system_health.memory_desktop failing on several mac bots ( including the swarmed mac bots):

 Mac 10.10 Perf (3):
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Mac%2010.10%20Perf%20%283%29/builds/4270

Mac Retina Perf (3): 
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Mac%20Retina%20Perf%20%283%29/builds/4094

Mac HDD Perf(3): 
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Mac%20HDD%20Perf%20%283%29/builds/2570

Mac Pro 10.11 Perf:
https://chromium-swarm.appspot.com/user/task/32578aba6b181810

Mac Air 10.11 Perf:
https://chromium-swarm.appspot.com/user/task/32572497defaff10

I am also seeing the same stack trace for system_health.common_desktop for the swarmed mac bots: 

Mac Pro 10.11 Perf:
https://chromium-swarm.appspot.com/user/task/32578aaf2efc9e10

Mac Air 10.11 Perf:
https://chromium-swarm.appspot.com/user/task/32572489832bac10

Snippet of stack trace: 
INFO:root:Minidump found: /b/s/w/itMse6iM/tmpGfnJrK/completed/385d256c-948c-4584-b439-f68083f7e85f.dmp
INFO:py_utils.cloud_storage:Downloading gs://chromium-telemetry/binary_dependencies/minidump_stackwalk_76c5983fc9e9316a9d4251ba3e68b955c4fc9bf3 to /b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/bin/mac/x86_64/minidump_stackwalk
INFO:root:Dumping breakpad symbols.
INFO:py_utils.cloud_storage:Downloading gs://chromium-telemetry/binary_dependencies/minidump_dump_c39bd7a3b9fa6279893b2d759045699d79ce4dcb to /b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/bin/mac/x86_64/minidump_dump
INFO:root:Found crashpad_database_util
[1107/064856:WARNING:crash_report_database_mac.mm(697)] Failed to read report metadata for /b/s/w/itMse6iM/tmpGfnJrK/completed/385d256c-948c-4584-b439-f68083f7e85f.dmp.stripped
INFO:root:*************** BROWSER STANDARD OUTPUT ***************
INFO:root:
INFO:root:*********** END OF BROWSER STANDARD OUTPUT ************
INFO:root:********************* BROWSER LOG *********************
INFO:root:No log file
INFO:root:***************** END OF BROWSER LOG ******************
Traceback (most recent call last):
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 87, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/s/w/irLRJx3H/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 299, in RunStory
    self._current_page.Run(self)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/page/__init__.py", line 109, in Run
    self.RunPageInteractions(action_runner)
  File "/b/s/w/irLRJx3H/tools/perf/page_sets/system_health/system_health_story.py", line 112, in RunPageInteractions
    self._DidLoadDocument(action_runner)
  File "/b/s/w/irLRJx3H/tools/perf/page_sets/system_health/browsing_stories.py", line 71, in _DidLoadDocument
    self._NavigateToItem(action_runner, i)
  File "/b/s/w/irLRJx3H/tools/perf/page_sets/system_health/browsing_stories.py", line 33, in _NavigateToItem
    action_runner.ScrollPageToElement(element_function=item_selector)
  File "/b/s/w/irLRJx3H/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 429, in ScrollPageToElement
    speed_in_pixels_per_second=speed_in_pixels_per_second))
  File "/b/s/w/irLRJx3H/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 55, in _RunAction
    action.RunAction(self._tab)
  File "/b/s/w/irLRJx3H/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/actions/scroll_to_element.py", line 65, in RunAction
    self._scroller.RunAction(tab)
  File "/b/s/w/irLRJx3H/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/actions/scroll.py", line 106, in RunAction
    tab.WaitForJavaScriptExpression('window.__scrollActionDone', 60)
  File "/b/s/w/irLRJx3H/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 129, in WaitForJavaScriptExpression
    py_utils.WaitFor(IsJavaScriptExpressionTrue, timeout)
  File "/b/s/w/irLRJx3H/third_party/catapult/common/py_utils/py_utils/__init__.py", line 120, in WaitFor
    res = condition()
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 122, in IsJavaScriptExpressionTrue
    return bool(self.EvaluateJavaScript(expr))
  File "/b/s/w/irLRJx3H/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 193, in EvaluateJavaScript
    expr, context_id=None, timeout=timeout)
  File "/b/s/w/irLRJx3H/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 221, in EvaluateJavaScriptInContext
    expr, context_id=context_id, timeout=timeout)
  File "/b/s/w/irLRJx3H/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 39, in inner
    inspector_backend._ConvertExceptionFromInspectorWebsocket(e)
  File "/b/s/w/irLRJx3H/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 36, in inner
    return func(inspector_backend, *args, **kwargs)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 211, in EvaluateJavaScript
    return self._runtime.Evaluate(expr, context_id, timeout)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py", line 45, in Evaluate
    res = self._inspector_websocket.SyncRequest(request, timeout)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 110, in SyncRequest
    res = self._Receive(timeout)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 149, in _Receive
    data = self._socket.recv()
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/third_party/websocket-client/websocket.py", line 596, in recv
    opcode, data = self.recv_data()
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/third_party/websocket-client/websocket.py", line 606, in recv_data
    frame = self.recv_frame()
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/third_party/websocket-client/websocket.py", line 637, in recv_frame
    self._frame_header = self._recv_strict(2)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/third_party/websocket-client/websocket.py", line 746, in _recv_strict
    bytes = self._recv(shortage)
  File "/b/s/w/irLRJx3H/third_party/catapult/telemetry/third_party/websocket-client/websocket.py", line 739, in _recv
    raise WebSocketConnectionClosedException()
DevtoolsTargetCrashException: <unprintable DevtoolsTargetCrashException object>







 

Comment 1 by u...@chromium.org, Nov 8 2016

Cc: u...@chromium.org
 Issue 663028  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57f0956c8472b744529cee20e6c64bd39fd84ec9

commit 57f0956c8472b744529cee20e6c64bd39fd84ec9
Author: zhenw <zhenw@chromium.org>
Date: Sat Nov 12 04:55:16 2016

Disable system_health.memory_desktop on Win and Mac perf bots

TBR=nednguyen@google.com
BUG= 656040 , 663025 

Review-Url: https://codereview.chromium.org/2497713002
Cr-Commit-Position: refs/heads/master@{#431773}

[modify] https://crrev.com/57f0956c8472b744529cee20e6c64bd39fd84ec9/tools/perf/benchmarks/system_health.py

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd3aaa596bf9434716cfe9c6c84ea70d5eae3547

commit fd3aaa596bf9434716cfe9c6c84ea70d5eae3547
Author: nednguyen <nednguyen@google.com>
Date: Sat Nov 12 12:39:11 2016

Revert of Disable system_health.memory_desktop on Win and Mac perf bots (patchset #1 id:1 of https://codereview.chromium.org/2497713002/ )

Reason for revert:
Please don't disable the whole system health benchmark. Disable only the failing stories instead.

Original issue's description:
> Disable system_health.memory_desktop on Win and Mac perf bots
>
> TBR=nednguyen@google.com
> BUG= 656040 , 663025 
>
> Committed: https://crrev.com/57f0956c8472b744529cee20e6c64bd39fd84ec9
> Cr-Commit-Position: refs/heads/master@{#431773}

TBR=zhenw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 656040 , 663025 

Review-Url: https://codereview.chromium.org/2492323003
Cr-Commit-Position: refs/heads/master@{#431783}

[modify] https://crrev.com/fd3aaa596bf9434716cfe9c6c84ea70d5eae3547/tools/perf/benchmarks/system_health.py

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4c02aa0d46a7fe3bf66c97e70921f653ff4913f

commit d4c02aa0d46a7fe3bf66c97e70921f653ff4913f
Author: zhenw <zhenw@chromium.org>
Date: Mon Nov 14 23:25:18 2016

Disable browse:social:twitter on Mac perf bots

BUG= 664661 ,  663025 

Review-Url: https://codereview.chromium.org/2501623002
Cr-Commit-Position: refs/heads/master@{#431964}

[modify] https://crrev.com/d4c02aa0d46a7fe3bf66c97e70921f653ff4913f/tools/perf/page_sets/system_health/browsing_stories.py

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc9646d2ba1ad21a0c0f3036b3891df1501b6035

commit cc9646d2ba1ad21a0c0f3036b3891df1501b6035
Author: zhenw <zhenw@chromium.org>
Date: Tue Nov 15 00:18:44 2016

Disable browse:news:flipboard on Mac perf bots

BUG= 663025 

Review-Url: https://codereview.chromium.org/2499073002
Cr-Commit-Position: refs/heads/master@{#432008}

[modify] https://crrev.com/cc9646d2ba1ad21a0c0f3036b3891df1501b6035/tools/perf/page_sets/system_health/browsing_stories.py

Comment 7 by zh...@chromium.org, Nov 15 2016

Labels: -Pri-1 Pri-2
Summary: Fix and reenable browse:news:flipboard and browse:social:twitter system health story Mac perf bots (was: system_health.memory_desktop failure on chromium.perf on several mac bots)

Comment 8 by zh...@chromium.org, Nov 15 2016

Summary: Fix and reenable browse:news:flipboard and browse:social:twitter system health story on Mac perf bots (was: Fix and reenable browse:news:flipboard and browse:social:twitter system health story Mac perf bots)
Cc: nednguyen@chromium.org
Owner: ----
Removing Ned from owner, this needs triage.
Blocking: 664505
Cc: -nednguyen@chromium.org
Owner: nedngu...@google.com
Status: Started (was: Untriaged)
Looks like this browse:news:flipboard  no longer fail on Mac canary, I will reenable
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac57155e1022ee2c0691b654aeaa256e74ba2c56

commit ac57155e1022ee2c0691b654aeaa256e74ba2c56
Author: nednguyen <nednguyen@google.com>
Date: Mon Jan 16 21:34:01 2017

Reenable browse:social:twitter on Mac

BUG= 663025 

Review-Url: https://codereview.chromium.org/2602083002
Cr-Commit-Position: refs/heads/master@{#443945}

[modify] https://crrev.com/ac57155e1022ee2c0691b654aeaa256e74ba2c56/tools/perf/page_sets/system_health/browsing_stories.py

Blockedon: 662971
Blockedon: -662971
Status: Fixed (was: Started)
These stories are now enabled on Mac.

Sign in to add a comment