New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663021 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

s/int/double/ in MediaSettingsRange.idl

Project Member Reported by mcasas@chromium.org, Nov 7 2016

Issue description

Per issue [1], change in the Spec.


[1] https://github.com/w3c/mediacapture-image/issues/77
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a4284b492c9511bd41ccad6e53f339a6de409a3

commit 5a4284b492c9511bd41ccad6e53f339a6de409a3
Author: mcasas <mcasas@chromium.org>
Date: Thu Nov 10 18:17:17 2016

MediaSettingsRange: s/long/double/ in MediaSettingsRange.idl and PhotoCapabilities.idl

This CL follows issue [1] in replacing integer
types with doubles in the capabilities/settings idl
(WebIdl encourages doubles and discourages
floats).

The change is rippled down to the mojom and
the implementations.  In Android:
- Reading capabilities and status are changed to
using double.
- Configuring settings are changed to use doubles.
- zoom and exposure compensation setting/reading
don't need to have x100 multipliers anymore, removed.

Otherwise:
- v4l2_capture_delegate.cc bugfix: unnecessary scaling
of zoom during setting (unmatched on retrieving).
- FakeVideoCaptureDevice changes to doubles.

[1] https://github.com/w3c/mediacapture-image/issues/77
BUG= 663021 

Review-Url: https://codereview.chromium.org/2482983002
Cr-Commit-Position: refs/heads/master@{#431293}

[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java
[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/media/capture/video/android/java/src/org/chromium/media/VideoCapture.java
[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/media/capture/video/android/photo_capabilities.cc
[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/media/capture/video/android/photo_capabilities.h
[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/media/capture/video/android/video_capture_device_android.cc
[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/media/capture/video/fake_video_capture_device.cc
[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/media/capture/video/fake_video_capture_device.h
[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/media/capture/video/fake_video_capture_device_unittest.cc
[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/media/capture/video/linux/v4l2_capture_delegate.cc
[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/media/mojo/interfaces/image_capture.mojom
[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/third_party/WebKit/LayoutTests/imagecapture/resources/mock-imagecapture.js
[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/third_party/WebKit/LayoutTests/imagecapture/setoptions.html
[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/third_party/WebKit/Source/modules/imagecapture/MediaSettingsRange.h
[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/third_party/WebKit/Source/modules/imagecapture/MediaSettingsRange.idl
[modify] https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3/third_party/WebKit/Source/modules/imagecapture/PhotoSettings.idl

Comment 2 by mcasas@chromium.org, Nov 10 2016

Status: Fixed (was: Started)
[bulk-edit : please ignore if not applicable]

Could you please set the correct milestone for this issue?

Comment 4 by sshru...@google.com, Nov 23 2016

Components: -Blink>MediaStream>ImageCapture Blink>ImageCapture

Sign in to add a comment