New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 663008 link

Starred by 1 user
Status: Fixed
Owner:
█ maxbogue@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 663125



Sign in to add a comment

[Sync] ProfileSyncService should keep ownership of the sync thread

Project Member Reported by maxbogue@chromium.org, Nov 7 2016 
Now that http://crrev.com/2471183003 has landed, there's no reason to pass ownership of the sync thread to the backend. PSS should just keep ownership at all times.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71190f64c797987aae80d1e343e46ea6509c7aaf

commit 71190f64c797987aae80d1e343e46ea6509c7aaf
Author: maxbogue <maxbogue@chromium.org>
Date: Tue Nov 08 00:33:40 2016

[Sync] Move sync thread ownership to ProfileSyncService.

BUG= 663008 

Review-Url: https://codereview.chromium.org/2481313002
Cr-Commit-Position: refs/heads/master@{#430441}

[modify] https://crrev.com/71190f64c797987aae80d1e343e46ea6509c7aaf/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/71190f64c797987aae80d1e343e46ea6509c7aaf/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/71190f64c797987aae80d1e343e46ea6509c7aaf/components/browser_sync/profile_sync_service_unittest.cc
[modify] https://crrev.com/71190f64c797987aae80d1e343e46ea6509c7aaf/components/sync/driver/glue/sync_backend_host.h
[modify] https://crrev.com/71190f64c797987aae80d1e343e46ea6509c7aaf/components/sync/driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/71190f64c797987aae80d1e343e46ea6509c7aaf/components/sync/driver/glue/sync_backend_host_impl.h
[modify] https://crrev.com/71190f64c797987aae80d1e343e46ea6509c7aaf/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
[modify] https://crrev.com/71190f64c797987aae80d1e343e46ea6509c7aaf/components/sync/driver/glue/sync_backend_host_mock.cc
[modify] https://crrev.com/71190f64c797987aae80d1e343e46ea6509c7aaf/components/sync/driver/glue/sync_backend_host_mock.h
[modify] https://crrev.com/71190f64c797987aae80d1e343e46ea6509c7aaf/components/sync/driver/glue/sync_backend_registrar.cc
[modify] https://crrev.com/71190f64c797987aae80d1e343e46ea6509c7aaf/components/sync/driver/glue/sync_backend_registrar.h
[modify] https://crrev.com/71190f64c797987aae80d1e343e46ea6509c7aaf/components/sync/driver/glue/sync_backend_registrar_unittest.cc

Comment 2 by maxbogue@chromium.org, Nov 8 2016

Blocking: 663125
Status: Fixed (was: Started)
►

Sign in to add a comment