Issue 663003 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	dtseng@chromium.org
Closed:	Nov 2016
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
cvox2 Phase3 braille VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Errors setting spans in braille output

Project Member Reported by dmazz...@chromium.org, Nov 7 2016

Issue description

These lines are failing frequently, e.g. tab to a text field with text inside it:

        buff.setSpan(new cvox.ValueSpan(selSpan.offset), valueStart, valueEnd);
        buff.setSpan(new cvox.ValueSelectionSpan(), startIndex, endIndex);

Comment 1 by lpalmaro@chromium.org, Nov 7 2016

Labels: braille Phase3
Owner: dtseng@chromium.org
Status: Available (was: Untriaged)

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9a9eed835172e6ecdb351901f1b5f40266d1ce3

commit f9a9eed835172e6ecdb351901f1b5f40266d1ce3
Author: dtseng <dtseng@chromium.org>
Date: Fri Nov 11 04:00:09 2016

Refine braille output

- whitespace: handle exclusion of separator character ' ' for inline nodes
- fix bug where we were adding additional value selection spans when adding text for selected notifications
- general code cleanup: move logic to merge braille spans down into the code sites where they are being used
- add support for character, word navigation (i.e. show the line and move the cursor under the character selected).

BUG= 663003 , 545487 , 523285 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2487043002
Cr-Commit-Position: refs/heads/master@{#431492}

[modify] https://crrev.com/f9a9eed835172e6ecdb351901f1b5f40266d1ce3/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
[modify] https://crrev.com/f9a9eed835172e6ecdb351901f1b5f40266d1ce3/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/f9a9eed835172e6ecdb351901f1b5f40266d1ce3/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/f9a9eed835172e6ecdb351901f1b5f40266d1ce3/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs