Backspace in PDF forms deletes 2 characters instead of 1 |
||||||||||||
Issue descriptionVersion: 55.0.2883.35 (Beta) OS: Linux What steps will reproduce the problem? (1) Go to http://foersom.com/net/HowTo/data/OoPdfFormExample.pdf (2) Type "abc" in the first form field (3) Press Backspace What is the expected output? The form field contains "ab" What do you see instead? The form field constains "a"
,
Nov 7 2016
Do you have a known good build version or revision number?
,
Nov 7 2016
No worries, I got it. Will bisect.
,
Nov 7 2016
https://chromium.googlesource.com/chromium/src/+log/61500f21a9f93247d9b02fa86c7f619e02bb7fb8..4db6bf82982a5755e26f23f5442f018212fbe059 -> r415535
,
Nov 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/435a59e7bbcf2e5875f860317f1056d914a30610 commit 435a59e7bbcf2e5875f860317f1056d914a30610 Author: dtapuska <dtapuska@chromium.org> Date: Tue Nov 08 02:09:33 2016 Fix backspace double occuring on PDF files. For some reason I overlooked an ifdef I left in some code in change; https://chromium.googlesource.com/chromium/src/+/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d%5E%21/ Make sure this code isn't ifdef'd out since this is the easiest path to merge into M55. I've added a TODO to revisit this since I think this function can actually be removed and not generate the events in the first place. BUG= 663002 Review-Url: https://codereview.chromium.org/2481943002 Cr-Commit-Position: refs/heads/master@{#430478} [modify] https://crrev.com/435a59e7bbcf2e5875f860317f1056d914a30610/third_party/WebKit/public/platform/WebInputEvent.h
,
Nov 8 2016
Fixed on trunk? Let's verify on Canary and then do a M55 merge?
,
Nov 8 2016
,
Nov 8 2016
There's no Linux canary... but it's fixed for me on ToT. Please request a merge to M55.
,
Nov 8 2016
There are official linux builds (not signed) I was waiting for 56.0.2914.0 to be built. Likewise this needs to be testing on windows canary as well to verify it doesn't break that platform.
,
Nov 9 2016
Rechecked this issue on chrome version 56.0.2914.0 on Ubuntu 14.04 and Windows 10. Fix is working as intended. Hitting backspace removes only one character. Adding TE-Verified labels. Requesting a merge to M55.
,
Nov 9 2016
,
Nov 9 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Nov 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21ad4cf85b24053d7994ef0b234c658e4a64f058 commit 21ad4cf85b24053d7994ef0b234c658e4a64f058 Author: Dave Tapuska <dtapuska@chromium.org> Date: Wed Nov 09 14:17:31 2016 Fix backspace double occuring on PDF files. For some reason I overlooked an ifdef I left in some code in change; https://chromium.googlesource.com/chromium/src/+/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d%5E%21/ Make sure this code isn't ifdef'd out since this is the easiest path to merge into M55. I've added a TODO to revisit this since I think this function can actually be removed and not generate the events in the first place. BUG= 663002 Review-Url: https://codereview.chromium.org/2481943002 Cr-Commit-Position: refs/heads/master@{#430478} (cherry picked from commit 435a59e7bbcf2e5875f860317f1056d914a30610) Review URL: https://codereview.chromium.org/2493463002 . Cr-Commit-Position: refs/branch-heads/2883@{#504} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/21ad4cf85b24053d7994ef0b234c658e4a64f058/third_party/WebKit/public/platform/WebInputEvent.h
,
Nov 9 2016
,
Nov 16 2016
Rechecked this issue on chrome version 55.0.2883.52 on Ubuntu 14.04 and Windows 10. Fix/merge is working as intended. Hitting backspace removes only one character. Adding TE-Verified labels.
,
Jan 6 2017
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by npm@chromium.org
, Nov 7 2016