New issue
Advanced search Search tips

Issue 662995 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 671354
issue 671357
issue 671365
issue 736928

Blocking:
issue 618368



Sign in to add a comment

detect SurfaceView suitability for video frames

Project Member Reported by liber...@chromium.org, Nov 7 2016

Issue description

Provide feedback to GLStreamTextureImage about the suitability of a quad to be backed by a SurfaceView.  This involves detecting rotation / scale / sandwich CC cases, webgl, devtools, scrolling, etc.
 

Comment 1 by xhw...@chromium.org, Nov 17 2016

Cc: xhw...@chromium.org ddorwin@chromium.org
Cc: billorr@chromium.org
Components: Internals>Media>Video Internals>GPU>Video
Labels: OS-Android
Labels: Proj-DialogSurface
Blockedon: 671354
Blockedon: 671357
Blockedon: 671365
Blocking: 618368
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe8f969833ed376460af94787e2572755e598575

commit fe8f969833ed376460af94787e2572755e598575
Author: liberato <liberato@chromium.org>
Date: Thu Jun 08 19:17:36 2017

Send enter / exit fullscreen signal to AVDA

This CL causes WMPI to notify AVDA when the player element enters /
exits fullscreen.  This will help AVDA to choose whether to use an
overlay or SurfaceTexture to back the video frames.

It also replaces the (surface id, routing token) pair that is sent
via the Provide/RequestOverlayInfoCB with an OverlayInfo struct.
This structure contains the surface id and routing token, plus the
current fullscreen state, if it is known.

BUG= 662995 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2892083002
Cr-Commit-Position: refs/heads/master@{#478048}

[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/base/BUILD.gn
[add] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/base/overlay_info.cc
[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/base/overlay_info.h
[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/filters/gpu_video_decoder.h
[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/gpu/android_video_decode_accelerator.h
[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/gpu/android_video_decode_accelerator_unittest.cc
[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/gpu/ipc/client/gpu_video_decode_accelerator_host.h
[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/gpu/ipc/common/media_messages.h
[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/gpu/ipc/common/media_param_traits_macros.h
[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/gpu/ipc/service/gpu_video_decode_accelerator.h
[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/video/video_decode_accelerator.cc
[modify] https://crrev.com/fe8f969833ed376460af94787e2572755e598575/media/video/video_decode_accelerator.h

Blockedon: 736928
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d

commit 68ec57f3e3114a39ea147c7fe956fa3b9d3a601d
Author: liberato@chromium.org <liberato@chromium.org>
Date: Wed Jun 28 00:43:05 2017

Added PromotionHintAggregator for AVDA.

PromotionHintAggregator takes compositor feedback and aggregates
it into a single "promote / don't promote" signal.  This signal is
sent from AVDACodecImage to the surface chooser, which uses it to
switch back to SurfaceTexture if needed.

This CL also requests feedback from the compositor about whether a
video quad would be promoted.

Bug:  662995 ,  671365 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iaef3e5bb21e018033c9dd4e024c7e65daf0c5c35
Reviewed-on: https://chromium-review.googlesource.com/545195
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482823}
[modify] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/gpu/BUILD.gn
[add] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/gpu/android/promotion_hint_aggregator.h
[add] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/gpu/android/promotion_hint_aggregator_impl.cc
[add] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/gpu/android/promotion_hint_aggregator_impl.h
[add] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/gpu/android/promotion_hint_aggregator_impl_unittest.cc
[modify] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/gpu/android_video_decode_accelerator.h
[modify] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/gpu/android_video_surface_chooser.h
[modify] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/gpu/android_video_surface_chooser_impl.cc
[modify] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/gpu/android_video_surface_chooser_impl_unittest.cc
[modify] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/gpu/avda_codec_image.cc
[modify] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/gpu/avda_codec_image.h
[modify] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/gpu/avda_picture_buffer_manager.cc
[modify] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/gpu/avda_shared_state.cc
[modify] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/gpu/avda_shared_state.h
[modify] https://crrev.com/68ec57f3e3114a39ea147c7fe956fa3b9d3a601d/media/gpu/avda_state_provider.h

Status: Fixed (was: Started)

Sign in to add a comment