New issue
Advanced search Search tips

Issue 662990 link

Starred by 1 user
Status: Fixed
Owner:
caseq@chromium.org
Closed: Nov 2017
Cc:
paulir...@chromium.org
pfeldman@chromium.org
alph@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: group events per iframe in Timeline

Project Member Reported by caseq@chromium.org, Nov 7 2016 
As the page often spends a large, if not dominant, portion of its loading and running time in its child frames, often 3rd-party, it's important to see a per-frame breakdown of page costs. This may be exposed in a number of ways:

- grouping per frame in timeline aggregated trees;
- per-frame flame chart groups;
- a coloring scheme matching that would match grouping.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79b4a4119de12f1f37748e7fedb3e2a87a534e3a

commit 79b4a4119de12f1f37748e7fedb3e2a87a534e3a
Author: caseq <caseq@chromium.org>
Date: Tue Nov 08 21:31:05 2016

DevTools: add per-frame grouping into aggregated timeline details

- add frame list to TracingStartedInPage
- add frame details (URL, name) to CommitLoad
- refactor event grouping in the top-down tree to never prematurely
    merge events that would end up in different groups adter grouping.
- move GroupBy enum from WI.TimelineAggregator to AggregatedTimelineTreeView;

BUG= 662990 

Review-Url: https://codereview.chromium.org/2473283003
Cr-Commit-Position: refs/heads/master@{#430719}

[modify] https://crrev.com/79b4a4119de12f1f37748e7fedb3e2a87a534e3a/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/tracing-test.js
[add] https://crrev.com/79b4a4119de12f1f37748e7fedb3e2a87a534e3a/third_party/WebKit/LayoutTests/inspector-protocol/timeline/page-frames-expected.txt
[add] https://crrev.com/79b4a4119de12f1f37748e7fedb3e2a87a534e3a/third_party/WebKit/LayoutTests/inspector-protocol/timeline/page-frames.html
[modify] https://crrev.com/79b4a4119de12f1f37748e7fedb3e2a87a534e3a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-aggregated-details-expected.txt
[modify] https://crrev.com/79b4a4119de12f1f37748e7fedb3e2a87a534e3a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-aggregated-details.html
[modify] https://crrev.com/79b4a4119de12f1f37748e7fedb3e2a87a534e3a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/79b4a4119de12f1f37748e7fedb3e2a87a534e3a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
[modify] https://crrev.com/79b4a4119de12f1f37748e7fedb3e2a87a534e3a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
[modify] https://crrev.com/79b4a4119de12f1f37748e7fedb3e2a87a534e3a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/506586367b7a3b51201870bf86da6d5375755090

commit 506586367b7a3b51201870bf86da6d5375755090
Author: caseq <caseq@chromium.org>
Date: Wed Nov 16 18:23:52 2016

Timeline: add support for jumping to frame for aggregated trees

This adds a context menu item for group tree nodes in a
TimelineTreeView to reveal the related frame in the Elements
panel, provided the grouping is by frame.

BUG= 662990 

Review-Url: https://codereview.chromium.org/2510493002
Cr-Commit-Position: refs/heads/master@{#432561}

[modify] https://crrev.com/506586367b7a3b51201870bf86da6d5375755090/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Comment 5 by caseq@chromium.org, Nov 28 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment