New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 662959 link

Starred by 1 user
Status: Archived
Owner:
u...@chromium.org
Closed: Aug 2017
Cc:
perezju@chromium.org
█ picksi@chromium.org
primiano@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

System health story browse:news:reddit is failing on Mac

Project Member Reported by skyos...@chromium.org, Nov 7 2016 
https://build.chromium.org/p/chromium.perf/builders/Mac%2010.11%20Perf%20%283%29/builds/3045/steps/system_health.memory_desktop/logs/stdio

Traceback (most recent call last):
  File "/b/c/b/Mac_10_11_Perf__3_/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 87, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/c/b/Mac_10_11_Perf__3_/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/c/b/Mac_10_11_Perf__3_/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 299, in RunStory
    self._current_page.Run(self)
  File "/b/c/b/Mac_10_11_Perf__3_/src/third_party/catapult/telemetry/telemetry/page/__init__.py", line 109, in Run
    self.RunPageInteractions(action_runner)
  File "/b/c/b/Mac_10_11_Perf__3_/src/tools/perf/page_sets/system_health/system_health_story.py", line 112, in RunPageInteractions
    self._DidLoadDocument(action_runner)
  File "/b/c/b/Mac_10_11_Perf__3_/src/tools/perf/page_sets/system_health/browsing_stories.py", line 74, in _DidLoadDocument
    self._ScrollMainPage(action_runner)
  File "/b/c/b/Mac_10_11_Perf__3_/src/tools/perf/page_sets/system_health/browsing_stories.py", line 83, in _ScrollMainPage
    action_runner.tab.WaitForDocumentReadyStateToBeComplete()
  File "/b/c/b/Mac_10_11_Perf__3_/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/c/b/Mac_10_11_Perf__3_/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 76, in WaitForDocumentReadyStateToBeComplete
    'document.readyState == "complete"', timeout)
  File "/b/c/b/Mac_10_11_Perf__3_/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/c/b/Mac_10_11_Perf__3_/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 142, in WaitForJavaScriptExpression
    e.message + '\n' + debug_message)
TimeoutException: Timed out while waiting 90s for IsJavaScriptExpressionTrue.

Comment 1 by skyos...@chromium.org, Nov 7 2016

Cc: picksi@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31caf2b1bb934e61b2b79fda4ebb8a8791546f54

commit 31caf2b1bb934e61b2b79fda4ebb8a8791546f54
Author: skyostil <skyostil@chromium.org>
Date: Mon Nov 07 18:20:37 2016

perf: Disable browse:news:reddit on Mac

BUG= 662959 
TBR=perezju@chromium.org

Review-Url: https://codereview.chromium.org/2484783002
Cr-Commit-Position: refs/heads/master@{#430320}

[modify] https://crrev.com/31caf2b1bb934e61b2b79fda4ebb8a8791546f54/tools/perf/page_sets/system_health/browsing_stories.py

Comment 3 by hpayer@chromium.org, Nov 21 2016

Owner: u...@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by u...@chromium.org, Dec 12 2016 

The failure doesn't reproduce at current TOT. I am going to re-enable the benchmark on mac and keep an eye on bots.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69c7ebea3b83a1fcd7523ed2e961f573a8f1f61f

commit 69c7ebea3b83a1fcd7523ed2e961f573a8f1f61f
Author: ulan <ulan@chromium.org>
Date: Mon Dec 12 14:32:22 2016

Revert of perf: Disable browse:news:reddit on Mac (patchset #1 id:1 of https://codereview.chromium.org/2484783002/ )

Reason for revert:
The failure does not reproduce at TOT locally.
Re-enabling to see if it still fails on bots.

Original issue's description:
> perf: Disable browse:news:reddit on Mac
>
> BUG= 662959 
> TBR=perezju@chromium.org
>
> Committed: https://crrev.com/31caf2b1bb934e61b2b79fda4ebb8a8791546f54
> Cr-Commit-Position: refs/heads/master@{#430320}

TBR=perezju@chromium.org,skyostil@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 662959 

Review-Url: https://codereview.chromium.org/2565393002
Cr-Commit-Position: refs/heads/master@{#437869}

[modify] https://crrev.com/69c7ebea3b83a1fcd7523ed2e961f573a8f1f61f/tools/perf/page_sets/system_health/browsing_stories.py

Comment 6 by martiniss@chromium.org, Aug 4 2017

Status: Archived (was: Assigned)
►

Sign in to add a comment