New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 662942 link

Starred by 1 user
Status: Fixed
Owner:
█ lawrencewu@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
asvitk...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Store allocator references in field trial in child processes

Reported by lawrencewu@chromium.org, Nov 7 2016 
Currently, when creating field trials in child processes with shared memory, we don't keep track of where they are in the allocator so we can't look them back up later. That's not a problem now but with experiment parameters we will need to look them up to get the field trial parameters.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c13daefb5958061dce05d10bbe22992635a8645

commit 8c13daefb5958061dce05d10bbe22992635a8645
Author: lawrencewu <lawrencewu@chromium.org>
Date: Tue Nov 08 21:29:53 2016

Store ref in field trial in child processes

This CL stores the ref in the field trial in child processes, so we can
look them up later when we will have experiment parameters associated
with them in shared memory. Also initializes the allocator in the child
process when we're creating the field trials so we have a handle on that as well.

BUG= 662942 

Review-Url: https://codereview.chromium.org/2484773002
Cr-Commit-Position: refs/heads/master@{#430718}

[modify] https://crrev.com/8c13daefb5958061dce05d10bbe22992635a8645/base/metrics/field_trial.cc
[modify] https://crrev.com/8c13daefb5958061dce05d10bbe22992635a8645/base/metrics/field_trial.h

Comment 2 by lawrencewu@chromium.org, Nov 9 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment