Issue metadata
Sign in to add a comment
|
Clean rietveld revert incorrectly commits one file as empty |
||||||||||||||||||||||
Issue descriptionVersion: https://chromium.googlesource.com/v8/v8/+/d5948caed59411d72fa27eca65d00a008b4e96f3 What steps will reproduce the problem? (1) Created a revert on the web interface. The revert is clean, applied right after the original commit landed. What is the expected output? The state after the revert equals the state before the commit. What do you see instead? One file (regress-2825.js) is empty after the revert but non-empty before the revert. Presubmit checks fail because the file now does not have a copyright header (this is the only reason I noticed the missing content). Original CL: https://codereview.chromium.org/2480223002/ Revert CL: https://codereview.chromium.org/2480283002/
,
Nov 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/39b86ad453e795db162c84021793f209d3efc6e4 commit 39b86ad453e795db162c84021793f209d3efc6e4 Author: jgruber <jgruber@chromium.org> Date: Mon Nov 07 15:46:31 2016 Manually complete failed revert The revert somehow lost the contents of regress-2825.js. NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true BUG= chromium:662928 Review URL: https://codereview.chromium.org/2483863002 . Cr-Commit-Position: refs/heads/master@{#40806} [modify] https://crrev.com/39b86ad453e795db162c84021793f209d3efc6e4/test/mjsunit/regress/regress-2825.js
,
Nov 7 2016
Maybe related: regress-2825.js has various line endings.
[...]
// Do not edit this file with an editor that replaces \r with \r\n.
// Variable definitions for i0 through i3 are each terminated with \r.
function f() {
var i0 = 0;^M var i1 = 1;^M var i2 = 2;^M var i3 = 3;
var j0 = 0;
[...]
$ hexdump -c test/mjsunit/regress/regress-2825.js
[...]
0000160 ( ) { \n v a r i 0 =
0000170 0 ; \r v a r i 1 = 1 ;
0000180 \r v a r i 2 = 2 ; \r
0000190 v a r i 3 = 3 ; \r \n
In fact, when trying to manually fix the revert (over the web interface), the patch diff fails at exactly the affected lines: https://codereview.chromium.org/2483863002/
,
Nov 7 2016
Rietveld is already known to not handle Windows line endings. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rmis...@google.com
, Nov 7 2016