New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662895 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocked on:
issue 663297



Sign in to add a comment

Layout test archiving doesn't find gsutil

Project Member Reported by machenb...@chromium.org, Nov 7 2016

Issue description

Layout test archives are not uploaded which makes reasoning about the failures very hard.

See:
https://build.chromium.org/p/chromium.fyi/builders/WebKit%20Linux%20-%20TraceWrappables/builds/7487/steps/archive_webkit_tests_results/logs/stdio

or:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FWebKit_Linux_-_TraceWrappables%2F7487%2F%2B%2Frecipes%2Fsteps%2Farchive_webkit_tests_results%2F0%2Fstdout

Error output:
/b/rr/tmpvzSaDk/rw/checkout/scripts/slave/gsutil -h "Cache-Control:public, max-age=31556926" cp file:///b/c/chrome_staging/layout-test-results.zip gs://chromium-layout-test-archives/WebKit_Linux_-_TraceWrappables/7487/layout-test-results.zip
/b/rr/tmpvzSaDk/rw/checkout/scripts/slave/gsutil: line 4: /b/rr/tmpvzSaDk/rw/checkout/scripts/slave/../../../depot_tools/gsutil.py: No such file or directory

The step is green, which is also very confusing.

Maybe this has to do with remote_run?
 
Maybe I read the stack trace wrong. Does it maybe just not find the archive file it just created?
Labels: -Pri-1 Infra-Troopers Pri-2
Owner: sergeybe...@chromium.org
Status: Assigned (was: Untriaged)
Will look into it a bit later in the day.
I'm pretty sure it's because of remote_run. I didn't check yet, but I think the recipe uses direct paths to depot_tools. Instead, it should be using the path recipe module and use the explicitly exported paths from there. I don't remember the details at the moment, but can dig out if needed.
The code is making the assumption that you're in a tools/build checkout on a buildbot host, which is no longer true. This needs to be fixed.

Where does this code call gsutil?

Also, is this bot important? If so, it should be moved off of chromium.fyi.
Cc: benhenry@chromium.org
Cc: andyb...@chromium.org
Dug into this a bit. It's calling slave_utils.GSCopyFile, which can't find depot tools. I'm not sure what the best solution to this is.... 

cc-ing andybons@
Cc: no...@chromium.org
The bot is important to V8 - it's staging a feature that we plan to launch soon. If there were a waterfall chromium.staging, I'd move it there. Otherwise, we could move it to the webkit waterfall as well if there's no problem with that. But it shouldn't be a tree closer.
Blockedon: 663297
The short term solution to this is to convert it back to annotated run. I'll make a CL for this.
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/4773035f7663fe1cf2baa49a44fc8266773f0698

commit 4773035f7663fe1cf2baa49a44fc8266773f0698
Author: martiniss <martiniss@chromium.org>
Date: Wed Nov 09 08:36:08 2016

Switch Webkit Linux TraceWrappables bot back to annotated run

The bot still is assuming it has a depot_tools checkout. Short term fix;
long term fix is complicated.

BUG= 662895 

Review-Url: https://codereview.chromium.org/2486073002

[modify] https://crrev.com/4773035f7663fe1cf2baa49a44fc8266773f0698/masters/master.chromium.fyi/master.cfg

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/851ce6c4a339a712dbd7ed0d24d93e415bfc41f9

commit 851ce6c4a339a712dbd7ed0d24d93e415bfc41f9
Author: machenbach <machenbach@google.com>
Date: Wed Nov 09 08:49:19 2016

Thanks, work-around worked!
Thanks, Stephen!

So this is now not a trooper issue, but before I remove it from the queue - who should own the long term fix? Could that person take the bug please?

Thanks!
Labels: -Infra-Troopers
Owner: martiniss@chromium.org
Assigning to Martiniss until next Crossover team weekly so that he can provide context.

Comment 17 by d...@chromium.org, Nov 16 2016

Owner: d...@chromium.org
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/6ecbb4ac0b4374feefad513056baf5ffe109e2b0

commit 6ecbb4ac0b4374feefad513056baf5ffe109e2b0
Author: Dan Jacques <dnj@chromium.org>
Date: Wed Nov 16 19:46:39 2016

Add gsutil recipe module.

Add the "gsutil" recipe module to depot_tools. This module is copied
from "tools/build"'s recipe module set at:
d6205ab0c0e8e1920f4af1617b5b3767cd944492.

Two Chromium-specific functions have been removed:
- download_with_polling
- download_latest_file

It also adds a function, "gsutil_py_path", which mimics the function in
the "depot_tools" recipe module. Ultimately, the latter will be phased
out in favor of the module-specific function.

BUG= chromium:662895 
TEST=expectations

Change-Id: Ie049d637593b3f02b9ff029fbd20fd3f7170faa6
Reviewed-on: https://chromium-review.googlesource.com/411970
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/6ecbb4ac0b4374feefad513056baf5ffe109e2b0/recipe_modules/depot_tools/api.py
[add] https://crrev.com/6ecbb4ac0b4374feefad513056baf5ffe109e2b0/recipe_modules/gsutil/__init__.py
[add] https://crrev.com/6ecbb4ac0b4374feefad513056baf5ffe109e2b0/recipe_modules/gsutil/api.py
[add] https://crrev.com/6ecbb4ac0b4374feefad513056baf5ffe109e2b0/recipe_modules/gsutil/example.expected/basic.json
[add] https://crrev.com/6ecbb4ac0b4374feefad513056baf5ffe109e2b0/recipe_modules/gsutil/example.py
[add] https://crrev.com/6ecbb4ac0b4374feefad513056baf5ffe109e2b0/recipe_modules/gsutil/resources/gsutil_smart_retry.py

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca

commit f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca
Author: Dan Jacques <dnj@chromium.org>
Date: Thu Nov 17 00:59:20 2016

Recipe engine supplies gsutil path to scripts.

Identify scripts which use "gsutil" through "slave_utils.py":
scripts/slave/...
  chromium/archive_build.py
  chromium/archive_layout_test_results.py
  chromium/asan_archive_build.py (does anything actually use this?)
  extract_build.py
  gsutil_download.py
  runtest.py
  zip_build.py

All of these now augment their argparse/optparse options with common
"slave_utils.py" arguments, namely the ability to set the gsutil script
path.

Update the recipes which invoke those tools to supply the new common
arguments. This is done with the help of a new recipe module, "build",
which represents common "tools/build" repository functionality.

BUG= chromium:662895 
TEST=None

Change-Id: Ife0e71370ccb5963ff55a718ed26689e3b342956
Reviewed-on: https://chromium-review.googlesource.com/412180
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/chromium/archive_layout_test_results.py
[add] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipe_modules/build/__init__.py
[add] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipe_modules/build/api.py
[add] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipe_modules/build/example.expected/basic.json
[add] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipe_modules/build/example.py
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_fail.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_pass.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_pass.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_pass.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/blink_downstream.expected/too_many_failures_for_retcode.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/blink_downstream.expected/webkit_tests_interrupted.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/blink_downstream.expected/webkit_tests_unexpected_error.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/blink_downstream.py
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/chromium_webkit_crash.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_webkit.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/chromium_webkit_revision_chromium.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/chromium_webkit_revision_webkit.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/chromium_webkit_warnings.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Browser_Side_Navigation_Linux.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Site_Isolation_Linux.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Site_Isolation_Win.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux___RandomOrder.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux___TraceWrappables.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux___WPTServe.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux_slimming_paint_v2_Dummy_Builder.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Mac___WPTServe.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Win___WPTServe.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Android__Nexus4_.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Trusty.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Trusty_ASAN.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Trusty_Leak.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Trusty_MSAN.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Trusty__dbg_.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_10.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_11.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_11__dbg_.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_11__retina_.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_9.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win10.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win7.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win7__dbg_.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium.py
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/blink_compile_without_patch_fails.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/dont_analyze_for_non_src_project.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_trusty_blink_dbg.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_trusty_blink_rel.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac10_10_blink_rel.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac10_11_blink_rel.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac10_11_retina_blink_rel.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac10_9_blink_dbg.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac10_9_blink_rel.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win10_blink_rel.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win7_blink_dbg.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win7_blink_rel.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_blink_rel.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_browser_side_navigation_rel.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_layout_tests_slimming_paint_v2.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_site_isolation.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_v8_v8_linux_blink_rel.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/non_cq_blink_tryjob.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/too_many_failures_for_retcode.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_blink_trybot_test_failures.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/webkit_tests_interrupted.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/webkit_tests_unexpected_error.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.expected/webkit_tests_with_and_without_patch_fail.json
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/recipes/chromium_trybot.py
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/slave_utils.py
[modify] https://crrev.com/f09b3e29bc1c4d1816d2f32d27d9d2a410b24bca/scripts/slave/unittests/slave_utils_test.py

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/658649569f986ad1e9be403c83fc384be969f92f

commit 658649569f986ad1e9be403c83fc384be969f92f
Author: Nodir Turakulov <nodir@chromium.org>
Date: Thu Nov 17 10:59:30 2016

chromium_tests: add build dep

chromium_tests uses build module but does not declare it as a
dependency. Fix that

TBR=dnj@chromium.org
BUG= 662895 

Change-Id: I5cb54b7858ec23fcf6a579b521c61549234409c3
Reviewed-on: https://chromium-review.googlesource.com/411956
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/658649569f986ad1e9be403c83fc384be969f92f/scripts/slave/recipe_modules/chromium_tests/__init__.py

Project Member

Comment 21 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/a77d0e4714dfa7479f19e5aa3046fccf3af0f048

commit a77d0e4714dfa7479f19e5aa3046fccf3af0f048
Author: Nodir Turakulov <nodir@chromium.org>
Date: Thu Nov 17 11:17:21 2016

Revert "chromium_tests: add build dep"

This reverts commit 658649569f986ad1e9be403c83fc384be969f92f.

Reason for revert: my reasoning was incorrect.
steps.py uses a passed API object
which is not chromium_tests module. 

Original change's description:
> chromium_tests: add build dep
> 
> chromium_tests uses build module but does not declare it as a
> dependency. Fix that
> 
> TBR=dnj@chromium.org
> BUG= 662895 
> 
> Change-Id: I5cb54b7858ec23fcf6a579b521c61549234409c3
> Reviewed-on: https://chromium-review.googlesource.com/411956
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> 

TBR=dnj@chromium.org,nodir@chromium.org,chromium-reviews@chromium.org,infra-reviews+build@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I48e853eff369ef5e9a3054fbfabaa85909f2d534
Reviewed-on: https://chromium-review.googlesource.com/412202
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/a77d0e4714dfa7479f19e5aa3046fccf3af0f048/scripts/slave/recipe_modules/chromium_tests/__init__.py

Project Member

Comment 22 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/aad805fa11ffe22cfb307b868059ccf55f4d4e10

commit aad805fa11ffe22cfb307b868059ccf55f4d4e10
Author: Dan Jacques <dnj@chromium.org>
Date: Thu Nov 17 21:19:59 2016

Use args separator when invoking gsutil.py.

BUG= chromium:662895 
TEST=None

Change-Id: I4fb46591f1b712ccddb23ac75b55cceed0ce3d56
Reviewed-on: https://chromium-review.googlesource.com/412403
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/aad805fa11ffe22cfb307b868059ccf55f4d4e10/scripts/slave/slave_utils.py

Project Member

Comment 23 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/aad805fa11ffe22cfb307b868059ccf55f4d4e10

commit aad805fa11ffe22cfb307b868059ccf55f4d4e10
Author: Dan Jacques <dnj@chromium.org>
Date: Thu Nov 17 21:19:59 2016

Use args separator when invoking gsutil.py.

BUG= chromium:662895 
TEST=None

Change-Id: I4fb46591f1b712ccddb23ac75b55cceed0ce3d56
Reviewed-on: https://chromium-review.googlesource.com/412403
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/aad805fa11ffe22cfb307b868059ccf55f4d4e10/scripts/slave/slave_utils.py

Project Member

Comment 24 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/fb91a95737e8cb7e580cb0ce533d4d133ea76874

commit fb91a95737e8cb7e580cb0ce533d4d133ea76874
Author: Dan Jacques <dnj@chromium.org>
Date: Fri Nov 18 16:12:56 2016

Project Member

Comment 25 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/c296eda6c0f5b90eb344c93f4c857dcd080c07e5

commit c296eda6c0f5b90eb344c93f4c857dcd080c07e5
Author: Dan Jacques <dnj@chromium.org>
Date: Thu Nov 17 18:06:50 2016

Move webKit Linux - TraceWrappables to remote run.

Recent recipe changes should allow this to access the 'gsutil.py'
wrapper script correctly now in a "remote run" environment.

TBR=martiniss@chromium.org
BUG= chromium:662895 
TEST=None

Change-Id: Iad1ea06d392feb37cf77a43f6cd0af43b39b6d86
Reviewed-on: https://chromium-review.googlesource.com/412301
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/c296eda6c0f5b90eb344c93f4c857dcd080c07e5/masters/master.chromium.fyi/master.cfg

Project Member

Comment 26 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/6bb90f8333448acefa2cd7b701557360206bc6a3

commit 6bb90f8333448acefa2cd7b701557360206bc6a3
Author: Dan Jacques <dnj@chromium.org>
Date: Fri Nov 18 16:42:57 2016

Comment 27 by d...@chromium.org, Nov 18 2016

I switched this back to "remote_run" after a change that I think will fix this specific problem. I'll be monitoring the FYI waterfall and will change this back if there is an observed problem.

Comment 28 by d...@chromium.org, Nov 18 2016

Status: fixedf (was: Assigned)
This switch looks like it is no longer encountering this problem, so I'm going to mark this Fixed.

Comment 29 by d...@chromium.org, Nov 18 2016

Status: Fixed (was: fixedf)
This switch looks like it is no longer encountering this problem, so I'm going to mark this Fixed.
Project Member

Comment 30 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/8f4fe1e1791902056c3bc3648a3585fcd1cffba0

commit 8f4fe1e1791902056c3bc3648a3585fcd1cffba0
Author: Dan Jacques <dnj@chromium.org>
Date: Fri Nov 18 20:24:44 2016

Supply gsutil arguments to zip/extract/archive.

Enable gsutil-using scripts to take common slave_util arguments:
- zip_build.py
- extract_build.py
- chromium/archive_build.py

Update the archive_build recipe module to supply gsutil as a path.

BUG= chromium:662895 
TEST=None

Change-Id: I4a8f89acf893481ad1fbee18efded39f0a62c245
Reviewed-on: https://chromium-review.googlesource.com/411991
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/chromium/archive_build.py
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/extract_build.py
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/archive/__init__.py
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/archive/api.py
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/archive/example.expected/zip_and_upload_custom_location.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_other_direction.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_linux_bisect.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_mac_bisect.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_win32_bisect.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_win64_bisect.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_buildbucket_get.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect/example.expected/no_repro.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect/example.expected/no_values.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect/example.expected/retest_bisect.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect/example.expected/return_code.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect/example.expected/v8_roll_bisect.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect/example.expected/v8_roll_bisect_bis.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_bisect_other_direction.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_linux_bisect.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_mac_bisect.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win32_bisect.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win64_bisect.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_build.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_buildbucket_get.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/no_repro.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/no_values.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/retest_bisect.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/return_code.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/v8_roll_bisect.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/v8_roll_bisect_bis.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/chromium/__init__.py
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipe_modules/chromium/api.py
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/android/builder.expected/full_tryserver_chromium_perf_android_arm64_perf_bisect_builder.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/android/builder.expected/full_tryserver_chromium_perf_android_perf_bisect_builder.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric_valueset.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/bisection/desktop_bisect.expected/deps_perf_tryjob.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_no_benchmark_to_run.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_run_benchmark.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/bisection/desktop_bisect.expected/perf_tryjob_failed_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_metric.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_metric_valueset.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_revisions.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/deps_perf_tryjob.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/perf_cq_no_benchmark_to_run.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/perf_cq_run_benchmark.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/perf_tryjob_failed_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__test_failure.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test_compile_target_overriden.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/buildnumber_zero.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_webkit.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_gtest.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_gtest_android.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_asan_no_lsan.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_builder.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_mac64.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_gtest_on_builder.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_gtest_win.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_build.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_with_timeout_scale.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_junit_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_script_test_failure.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_script_test_with_args.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gn_instrumentation_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_mac_gpu.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_override_compile_targets.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_instrumentation_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_gpu.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_serialized_gtests.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_invalid_format_isolated_script_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_disabled.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/ensure_goma_fail.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_bot_update_always_on_coverage_clobber.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_Android.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_Linux_x64.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_Mac.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_Win.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_Win_x64.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Cronet_Builder.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_MIPS_Builder__dbg_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_WebView_CTS_L_MR1__dbg_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_L__dbg_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_M__dbg_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm64_Builder__dbg_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm_Builder__dbg_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_x64_Builder__dbg_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_x86_Builder__dbg_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_KitKat_Tablet_Tester.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_Lollipop_Phone_Tester.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_Lollipop_Tablet_Tester.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_Marshmallow_64_bit_Tester.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_Marshmallow_Tablet_Tester.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_fyi_Jelly_Bean_Tester.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_fyi_Lollipop_Consumer_Tester.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_android_fyi_Lollipop_Low_end_Tester.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_amd64_generic_Compile.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_daisy_Compile.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_x86_generic_Compile.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder__dbg_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Full.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Ozone_Builder.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Ozone_Tests__1_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__1_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__dbg__1_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Coverage__dbg_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Find_Annotated_Test.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Remoting_Tests.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Tests__trial__dbg_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_VR_Tests.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroid__dbg_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxASan.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxASan_tester.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxLLD.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxLLD_tester.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxUBSanVptr.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxUBSanVptr_tester.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux__dbg_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux_tester.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan_tester.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac__dbg_.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac_tester.json
[modify] https://crrev.com/8f4fe1e1791902056c3bc3648a3585fcd1cffba0/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin.json
[mo
Project Member

Comment 31 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/823837bf954871c80588a87c45ed3fe3f53896b4

commit 823837bf954871c80588a87c45ed3fe3f53896b4
Author: Quinten Yearsley <qyearsley@google.com>
Date: Fri Dec 02 00:26:55 2016

Pass gsutil path to archive_layout_test_retry_summary.py

This CL should do the same thing for archive_layout_test_retry_summary.py
as was done for other scripts that use gsutil for  http://crbug.com/662895 .

Currently, blink try bots are failing to upload retry summary, to GS, which
causes the `webkit-patch rebaseline-cl` tool to be unable to use the retry
summary.

BUG= 642980 , 662895 

Change-Id: I8415bcf0a3ab3133dfe9e8a2586cc8cfb6723c89
Reviewed-on: https://chromium-review.googlesource.com/415912
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/823837bf954871c80588a87c45ed3fe3f53896b4/scripts/slave/chromium/archive_layout_test_retry_summary.py
[modify] https://crrev.com/823837bf954871c80588a87c45ed3fe3f53896b4/scripts/slave/recipe_modules/test_utils/__init__.py
[modify] https://crrev.com/823837bf954871c80588a87c45ed3fe3f53896b4/scripts/slave/recipe_modules/test_utils/api.py
[modify] https://crrev.com/823837bf954871c80588a87c45ed3fe3f53896b4/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_fail.json
[modify] https://crrev.com/823837bf954871c80588a87c45ed3fe3f53896b4/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json
[modify] https://crrev.com/823837bf954871c80588a87c45ed3fe3f53896b4/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json
[modify] https://crrev.com/823837bf954871c80588a87c45ed3fe3f53896b4/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json
[modify] https://crrev.com/823837bf954871c80588a87c45ed3fe3f53896b4/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json
[modify] https://crrev.com/823837bf954871c80588a87c45ed3fe3f53896b4/scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json
[modify] https://crrev.com/823837bf954871c80588a87c45ed3fe3f53896b4/scripts/slave/recipes/blink_downstream.expected/too_many_failures_for_retcode.json
[modify] https://crrev.com/823837bf954871c80588a87c45ed3fe3f53896b4/scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json
[modify] https://crrev.com/823837bf954871c80588a87c45ed3fe3f53896b4/scripts/slave/recipes/chromium_trybot.expected/too_many_failures_for_retcode.json
[modify] https://crrev.com/823837bf954871c80588a87c45ed3fe3f53896b4/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_blink_trybot_test_failures.json
[modify] https://crrev.com/823837bf954871c80588a87c45ed3fe3f53896b4/scripts/slave/recipes/chromium_trybot.expected/webkit_tests_with_and_without_patch_fail.json

Sign in to add a comment