New issue
Advanced search Search tips

Issue 662870 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Dec 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Move inspector tasks from WorkerThread to WorkerBackingThread for cleanup

Project Member Reported by nhiroki@chromium.org, Nov 7 2016

Issue description

Copied from https://codereview.chromium.org/2456733002/diff/160001/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp#newcode160

On 2016/11/02 17:23:37, dgozman wrote:
> I wonder whether we should now move inspector tasks to WorkerBackingThread,
> since we should pause all possible worklets running on the single thread, and
> thus blocking the thread makes sense on the WorkerBackingThread level. WDYT?
 
Cc: ikilpatrick@chromium.org dgozman@chromium.org
I have a question...

In the current implementation, each WorkerThread has its own InspectorTaskRunner. This architecture enables to run debugger tasks only for a specific WorkletGlobalScope during pause on the global scope (see WorkerThread::startRunningDebuggerTasksOnPauseOnWorkerThread). After this cleanup, one InspectorTaskRunner manages all debugger tasks for all WorkerThreads on one WorkerBackingThread. This means the debugger is no longer able to run tasks only for a specific WorkletGlobalScope on pause. Is this right behavior?
I think this is right behavior, since worklets share the thread and so pausing one of them should prevent others from doing anything. This would be a natural expectation for the user debugging tasks on a single thread.
Owner: nhiroki@chromium.org
Status: Assigned (was: Available)
Thank you for the clarification. I'll write a design document.
Any progress (or plans) on this?
Cc: nhiroki@chromium.org
Owner: ----
Status: Available (was: Assigned)
No progress/plan for now...
Components: -Platform>DevTools
Project Member

Comment 7 by sheriffbot@chromium.org, Dec 12

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
(Worker bug triage)

nhiroki@: Any updates?
Status: WontFix (was: Untriaged)
No updates. We've been drastically changing worker startup and worker inspector setup sequence (e.g., issue 835717, issue 882467), so it may be better to consider this after that.

Sign in to add a comment