input-appearance-range-with-datalist-zoomed.html fails on Mac |
|||||
Issue descriptionWhat steps will reproduce the problem? input-appearance-range-with-datalist-zoomed.html fails on Mac 10.11 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/5746 It seems like it started with this cl: https://chromium.googlesource.com/chromium/src/+/fae14ce1a1116a1d312a2a8639bf260d6fe50083
,
Nov 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a787d8f53aed8286e728c0fb521a68176cdfc4a commit 2a787d8f53aed8286e728c0fb521a68176cdfc4a Author: perkj <perkj@chromium.org> Date: Mon Nov 07 12:29:25 2016 Removed TestExpectations [ Mac ] fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html [ NeedsManualRebaseline ] Keep crbug.com/662862 [ Mac ] fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html [ Skip ] BUG= 662862 , 662722 TBR=fmalita@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2477333003 Cr-Commit-Position: refs/heads/master@{#430256} [modify] https://crrev.com/2a787d8f53aed8286e728c0fb521a68176cdfc4a/third_party/WebKit/LayoutTests/TestExpectations
,
Nov 7 2016
,
Nov 7 2016
I think that I ran into this before. The reason is that the Analytic AA is too sensitive to precision error. That results in very small alpha bleeding the edge. Visually that's not an issue. But that will trigger the no bleeding assert (*alpha == 0). I'll relax the assert (e.g., *alpha < 0x10) and the test should be fixed.
,
Nov 7 2016
How small could the *alpha < ?? be and still pass? Is it in fact just off by 1, or really off by 0x0F?
,
Nov 7 2016
,
Nov 7 2016
It's hard to tell how small the alpha is since this only happens in mac trybot and I couldn't reproduce it on my Goobuntu. The reason that I chose 0x10 is because that supersampling could only produce alpha 0x10, 0x20, ... so the threshold of 0x10 should have a quality no worse than that.
,
Nov 9 2016
,
Nov 9 2016
This should fix it: https://codereview.chromium.org/2477393002/
,
Nov 9 2016
Additional fix in: https://codereview.chromium.org/2482193004/
,
Nov 11 2016
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/041da389dd923689041ba5e45cda34901ba4fe8a commit 041da389dd923689041ba5e45cda34901ba4fe8a Author: liyuqian <liyuqian@google.com> Date: Fri Nov 11 17:59:51 2016 Tighten SkAAClip Bounds by Path Bounds This bug chromium:662780 exists after our original fix (https://codereview.chromium.org/2477393002/) because this path (added in unit test) is calling blitAntiRect rather than blitAntiH when the path is drifted across the boundary. (The quadratic edge drifts across the boundary after an update and sets a dX=0 line segment which triggers blitAntiRect.) Note that I didn't assert for the dLeft = dRite = 0 case because the left/right there won't drift after the SkTMin/SkTMax in line 964/966. Theoretically we can revert the relaxation in https://codereview.chromium.org/2477393002/ (that's only a relaxation for analytic AA, not supersampled AA). However, consider that the initial landing of analytic AA is so painful, I decide to revert that relaxation only after our successful landing... BUG= chromium:662780 , chromium:662862 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2482193004 Review-Url: https://codereview.chromium.org/2482193004 [modify] https://crrev.com/041da389dd923689041ba5e45cda34901ba4fe8a/src/core/SkScan_AAAPath.cpp [modify] https://crrev.com/041da389dd923689041ba5e45cda34901ba4fe8a/tests/PathTest.cpp
,
Nov 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2b4df60de19c7a6bac1364943239a23eef258b3 commit d2b4df60de19c7a6bac1364943239a23eef258b3 Author: skia-deps-roller <skia-deps-roller@chromium.org> Date: Fri Nov 11 22:07:22 2016 Roll src/third_party/skia/ 38af9438d..857cb97a3 (4 commits). https://skia.googlesource.com/skia.git/+log/38af9438d7b7..857cb97a34ea $ git log 38af9438d..857cb97a3 --date=short --no-merges --format='%ad %ae %s' 2016-11-11 scroggo Revert "re-land of skslc now uses standard Skia caps" 2016-11-11 robertphillips Add explicit UniqueID classes for GrGpuResource & GrSurfaceProxy 2016-11-11 ethannicholas re-land of skslc now uses standard Skia caps 2016-11-11 liyuqian Tighten SkAAClip Bounds by Path Bounds BUG= 662780 , 662862 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=scroggo@google.com Review-Url: https://codereview.chromium.org/2490313003 Cr-Commit-Position: refs/heads/master@{#431663} [modify] https://crrev.com/d2b4df60de19c7a6bac1364943239a23eef258b3/DEPS |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by perkj@chromium.org
, Nov 7 2016