New issue
Advanced search Search tips

Issue 662861 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 661579
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 661579

Blocking:
issue 662423



Sign in to add a comment

Difference between fullcode and crankshaft_opt: native caller

Project Member Reported by machenb...@chromium.org, Nov 7 2016

Issue description

Note, repro only with --nocrankshaft and --always-opt, no idea if that makes sense.

# Minimized program:
var d = {};
foo = function() {
  print(foo.caller);
}
d.valueOf = foo;
Number(d);
try {
} catch(e) {; }

# Compared nocrankshaft with noturbo_opt

# Flags of nocrankshaft:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --always-opt --random-seed 948182451 --nocrankshaft
# Flags of noturbo_opt:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --always-opt --random-seed 948182451 --always-opt --turbo-filter=~

Difference:
- null
+ function Number() { [native code] }

### Start of configuration nocrankshaft:
null

### End of configuration nocrankshaft

### Start of configuration noturbo_opt:
function Number() { [native code] }

### End of configuration noturbo_opt
 

Comment 1 by danno@chromium.org, Nov 17 2016

Cc: jochen@chromium.org
Owner: verwa...@chromium.org
Status: Assigned (was: Untriaged)
Toon, would you mind taking a look or triaging further?
Further reduced:

var d = { valueOf : function() { print(d.valueOf.caller) }}
Number(d);


Number is lowered to ToNumber in TurboFan which makes caller not see the Number function.
Owner: bmeu...@chromium.org
This was introduced in https://codereview.chromium.org/1497903002
Labels: -Restrict-View-Google v8-foozzie-failure
Ping, is this still an issue?
Blockedon: 661579
This is still an issue and is basically the same as issue 661579.
Status: WontFix (was: Assigned)
Fullcodegen and Crankshaft are gone.
Cc: -jochen@chromium.org
I don't see how your conclusion fits to comment 7. But I take "basically the same" as duplicate then?
Mergedinto: 661579
Status: Duplicate (was: WontFix)

Sign in to add a comment