Difference between fullcode and crankshaft_opt: missing reference error |
||||
Issue description
Minimized program:
function apply(code) {
code();
}
typeof boom;
var foo = (function() { huh = 0; });
apply(function() { foo(); });
apply(function() { foo(); });
boom;
# Compared nocrankshaft with noturbo_opt
# Flags of nocrankshaft:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --random-seed 76860675 --nocrankshaft
# Flags of noturbo_opt:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --random-seed 76860675 --always-opt --turbo-filter=~
Difference:
Different total output lines: 6 vs. 0
### Start of configuration nocrankshaft:
out7_opt/fuzz-56167.js.minimized:8: ReferenceError: boom is not defined
boom;
^
ReferenceError: boom is not defined
at out7_opt/fuzz-56167.js.minimized:8:1
### End of configuration nocrankshaft
### Start of configuration noturbo_opt:
### End of configuration noturbo_opt
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/937b8cb6847041dd2801eaa06fdaf0e5305abbc7 commit 937b8cb6847041dd2801eaa06fdaf0e5305abbc7 Author: ishell <ishell@chromium.org> Date: Thu Nov 17 12:18:22 2016 [ic] Support data handlers in LoadGlobalIC. Also fixed handling of load non-existent handlers outside typeof. BUG=v8:5561, chromium:662854 Review-Url: https://codereview.chromium.org/2511603002 Cr-Commit-Position: refs/heads/master@{#41073} [modify] https://crrev.com/937b8cb6847041dd2801eaa06fdaf0e5305abbc7/src/code-stubs.cc [modify] https://crrev.com/937b8cb6847041dd2801eaa06fdaf0e5305abbc7/src/code-stubs.h [modify] https://crrev.com/937b8cb6847041dd2801eaa06fdaf0e5305abbc7/src/full-codegen/full-codegen.cc [modify] https://crrev.com/937b8cb6847041dd2801eaa06fdaf0e5305abbc7/src/globals.h [modify] https://crrev.com/937b8cb6847041dd2801eaa06fdaf0e5305abbc7/src/ic/accessor-assembler-impl.h [modify] https://crrev.com/937b8cb6847041dd2801eaa06fdaf0e5305abbc7/src/ic/accessor-assembler.cc [modify] https://crrev.com/937b8cb6847041dd2801eaa06fdaf0e5305abbc7/src/ic/accessor-assembler.h [modify] https://crrev.com/937b8cb6847041dd2801eaa06fdaf0e5305abbc7/src/ic/ic.cc [modify] https://crrev.com/937b8cb6847041dd2801eaa06fdaf0e5305abbc7/src/objects.h [modify] https://crrev.com/937b8cb6847041dd2801eaa06fdaf0e5305abbc7/src/type-feedback-vector.cc [modify] https://crrev.com/937b8cb6847041dd2801eaa06fdaf0e5305abbc7/src/type-feedback-vector.h [add] https://crrev.com/937b8cb6847041dd2801eaa06fdaf0e5305abbc7/test/mjsunit/regress/regress-crbug-662854.js
,
Nov 17 2016
,
Dec 13 2016
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/695b6ad26f631a9fa56d9f5dcc9e14d08f48eebc commit 695b6ad26f631a9fa56d9f5dcc9e14d08f48eebc Author: ishell@chromium.org <ishell@chromium.org> Date: Wed Jan 04 12:39:07 2017 Merged: [ic] Support data handlers in LoadGlobalIC. Revision: 937b8cb6847041dd2801eaa06fdaf0e5305abbc7 (This backmerge takes only a part from the original CL, namely the support for global object receivers in load IC data handlers) BUG= chromium:662854 ,v8:5561 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=jkummerow@chromium.org Review-Url: https://codereview.chromium.org/2608163005 . Cr-Commit-Position: refs/branch-heads/5.6@{#64} Cr-Branched-From: bdd3886218dfe76e8560eb8a18401942452ae859-refs/heads/5.6.326@{#1} Cr-Branched-From: 879f6599eee6e1dfcbe9a24bf688b261c03e9558-refs/heads/master@{#41014} [modify] https://crrev.com/695b6ad26f631a9fa56d9f5dcc9e14d08f48eebc/src/code-stub-assembler.cc [modify] https://crrev.com/695b6ad26f631a9fa56d9f5dcc9e14d08f48eebc/src/ic/ic.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by jarin@chromium.org
, Nov 8 2016Status: Assigned (was: Untriaged)