Difference between fullcode and crankshaft_opt: stack traces |
||||
Issue descriptionTracker bug for stack trace differences between fullcode and crankshaft_opt.
,
Nov 7 2016
# Next one. Minimized program:
try {
} catch(e) {; }
5,
foo();
# Compared nocrankshaft with noturbo_opt
# Flags of nocrankshaft:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --random-seed 524715207 --nocrankshaft
# Flags of noturbo_opt:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --random-seed 524715207 --always-opt --turbo-filter=~
Difference:
- 5,
+ foo();
### Start of configuration nocrankshaft:
out7_opt/fuzz-47438.js.minimized:3: ReferenceError: foo is not defined
5,
^
ReferenceError: foo is not defined
at out7_opt/fuzz-47438.js.minimized:3:1
### End of configuration nocrankshaft
### Start of configuration noturbo_opt:
out7_opt/fuzz-47438.js.minimized:4: ReferenceError: foo is not defined
foo();
^
ReferenceError: foo is not defined
at out7_opt/fuzz-47438.js.minimized:4:14
### End of configuration noturbo_opt
,
Nov 7 2016
# A different one with proxies:
this.__proto__ = new Proxy({}, {});
(function () {
eval("f()");
})()
# Compared nocrankshaft with noturbo_opt
# Flags of nocrankshaft:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --random-seed 1489761483 --nocrankshaft
# Flags of noturbo_opt:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --random-seed 1489761483 --always-opt --turbo-filter=~
Difference:
- undefined:1: ReferenceError: f is not defined
+ undefined:1: TypeError: Trying to access 'f' through proxy
### Start of configuration nocrankshaft:
undefined:1: ReferenceError: f is not defined
f()
^
ReferenceError: f is not defined
at eval (eval at <anonymous> (out9_noturbo_opt/fuzz-33528.js.minimized:3:3), <anonymous>:1:1)
at out9_noturbo_opt/fuzz-33528.js.minimized:3:3
at out9_noturbo_opt/fuzz-33528.js.minimized:4:3
### End of configuration nocrankshaft
### Start of configuration noturbo_opt:
undefined:1: TypeError: Trying to access 'f' through proxy
f()
^
TypeError: Trying to access 'f' through proxy
at eval (eval at <anonymous> (out9_noturbo_opt/fuzz-33528.js.minimized:3:3), <anonymous>:1:1)
at out9_noturbo_opt/fuzz-33528.js.minimized:3:3
at out9_noturbo_opt/fuzz-33528.js.minimized:4:3
### End of configuration noturbo_opt
,
Nov 22 2016
Interesting. How much do we care for differences between CS and and FCG?
,
Dec 13 2016
,
Mar 10 2017
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/1dfcc4b6876d866e803b0a0af05bd27418443cbe commit 1dfcc4b6876d866e803b0a0af05bd27418443cbe Author: Michael Achenbach <machenbach@chromium.org> Date: Thu Apr 27 14:49:13 2017 [foozzie] Remove obsolete suppressions Most of these suppressions were for the old asm-validator or for the old compiler pipeline. Some more are just optimistically removed. Bug: chromium:681088 , chromium:681241 , chromium:681806, chromium:662840 NOTRY=true Change-Id: I4c6851a72d22070026eeaca90ad3394cfce10f90 Reviewed-on: https://chromium-review.googlesource.com/488641 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#44942} [modify] https://crrev.com/1dfcc4b6876d866e803b0a0af05bd27418443cbe/tools/foozzie/v8_foozzie_test.py [modify] https://crrev.com/1dfcc4b6876d866e803b0a0af05bd27418443cbe/tools/foozzie/v8_suppressions.py |
||||
►
Sign in to add a comment |
||||
Comment 1 by machenb...@chromium.org
, Nov 7 2016Labels: -Pri-1 Pri-2
# Minimized program: a = []; a.__defineGetter__("push", function() { return foo(); }); a.push(); function foo(boom) { var b = new boom(); } # Compared nocrankshaft with noturbo_opt # Flags of nocrankshaft: --abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --random-seed -1856604779 --nocrankshaft # Flags of noturbo_opt: --abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --random-seed -1856604779 --always-opt --turbo-filter=~ Difference: - out7_opt/fuzz-34512.js.minimized:5: TypeError: boom is not a constructor + out7_opt/fuzz-34512.js.minimized:5: TypeError: undefined is not a constructor ### Start of configuration nocrankshaft: out7_opt/fuzz-34512.js.minimized:5: TypeError: boom is not a constructor var b = new boom(); ^ TypeError: boom is not a constructor at foo (out7_opt/fuzz-34512.js.minimized:5:10) at Array.push (out7_opt/fuzz-34512.js.minimized:2:48) at out7_opt/fuzz-34512.js.minimized:3:2 ### End of configuration nocrankshaft ### Start of configuration noturbo_opt: out7_opt/fuzz-34512.js.minimized:5: TypeError: undefined is not a constructor var b = new boom(); ^ TypeError: undefined is not a constructor at foo (out7_opt/fuzz-34512.js.minimized:5:10) at Array.push (out7_opt/fuzz-34512.js.minimized:2:48) at out7_opt/fuzz-34512.js.minimized:3:2 ### End of configuration noturbo_opt