Repeat button not accessible by keyboard |
|||||
Issue descriptionChrome Version: ToT Steps To Reproduce: (1) Open Audio Player app. (2) Hit [Tab] several times and try to move a focus on the repeat button. Expected Result: Repeat button is focusable. Actual Result: Repeat button is not focusable. The focus jumps to the rewind button after the shuffle button. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always What is the impact to the user, and is there a workaround? If so, what is it? Users cannot use the feature when pointing devices nor touchscreen are not available.
,
Nov 9 2016
,
Nov 9 2016
r430897 broke OpenAudioFiles/FileManagerBrowserTest.Test/4 (also 6, 7, 9) in https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/29154. I could reproduce this locally (mostly failed in r430897, always passed in r430896). Because the failure on the bot is 100% since the blamed CL landed, I'm going to revert. Thus reopening this bug.
,
Nov 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76e2c525c63fcb6b744b0e2bb73394f5b17da4c7 commit 76e2c525c63fcb6b744b0e2bb73394f5b17da4c7 Author: vabr <vabr@chromium.org> Date: Wed Nov 09 12:04:32 2016 Revert of Make the repeat button accessible by keyboard. (patchset #7 id:120001 of https://codereview.chromium.org/2482063002/ ) Reason for revert: Broke https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29, more info in http://crbug.com/662829#c3 . Cheers, today's sheriff Original issue's description: > Make the repeat button accessible by keyboard. > As a known issue, duplicated ripple effect will be shown when clicking the icon (instead of keyboard). > > BUG= 662829 > TEST=manual test by hitting [TAB] key several times > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/b5275a7dcc189413073ea961c1eb7d3768ef35b8 > Cr-Commit-Position: refs/heads/master@{#430897} TBR=fukino@chromium.org,oka@chromium.org,yamaguchi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 662829 Review-Url: https://codereview.chromium.org/2483243004 Cr-Commit-Position: refs/heads/master@{#430913} [modify] https://crrev.com/76e2c525c63fcb6b744b0e2bb73394f5b17da4c7/ui/file_manager/audio_player/elements/repeat_button.css [modify] https://crrev.com/76e2c525c63fcb6b744b0e2bb73394f5b17da4c7/ui/file_manager/audio_player/elements/repeat_button.html
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/657661ab30800d46991fca1a0070d050e188b921 commit 657661ab30800d46991fca1a0070d050e188b921 Author: yamaguchi <yamaguchi@chromium.org> Date: Tue Nov 15 06:00:58 2016 Make the repeat button accessible by keyboard. This change also allows to inject the style for keyboard focus of files-icon-button to facilitate having consistent styles with other UI components. BUG= 662829 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2495213002 Cr-Commit-Position: refs/heads/master@{#432124} [modify] https://crrev.com/657661ab30800d46991fca1a0070d050e188b921/ui/file_manager/audio_player/elements/repeat_button.css [modify] https://crrev.com/657661ab30800d46991fca1a0070d050e188b921/ui/file_manager/audio_player/elements/repeat_button.js
,
Nov 15 2016
,
Nov 22 2016
Verified on ChromeOS 9011.0.0, 57.0.2926.0 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Nov 9 2016