New issue
Advanced search Search tips

Issue 662805 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 292996



Sign in to add a comment

UseCounter doesn't work for inline styles

Project Member Reported by timloh@chromium.org, Nov 7 2016

Issue description

CSSStyleSheet::createInline creates a CSSParserContext with nullptr for the UseCounter object. This means that inline styles never count to our usage counts for CSS properties and the other parse-time metrics (generally usage of certain values).
 
Labels: Update-Quarterly
Owner: suzyh@chromium.org

Comment 2 by suzyh@chromium.org, Feb 15 2017

Cc: suzyh@chromium.org
Owner: ericwilligers@chromium.org
Status: Assigned (was: Available)
Eric volunteered to take a look at this

Comment 3 by rbyers@chromium.org, Feb 17 2017

Cc: rbyers@chromium.org foolip@chromium.org
Components: Blink>Infra>Predictability
Labels: -Type-Feature Type-Bug
Yikes, that could definitely be a blind spot.  I'd call this a bug since when we make removal decisions we've always assumed ALL occurrences of a property are counted :-(.  Thanks for looking into this!

Comment 4 by suzyh@chromium.org, Mar 27 2017

Components: -Blink>Infra>Predictability
Labels: Hotlist-Predictability
Owner: dstockwell@chromium.org
Status: Started (was: Assigned)
Taking a look.
Setting the inline style is counted (elem.style = 'property: value'), but setting via the OM is not (elem.style.property = 'value').

Comment 7 by shend@chromium.org, Apr 11 2017

Labels: Blink-Only

Comment 8 by suzyh@chromium.org, Jun 13 2017

Cc: -suzyh@chromium.org
Labels: -Update-Quarterly
Owner: ----
Status: Available (was: Started)
Project Member

Comment 11 by sheriffbot@chromium.org, Yesterday (37 hours ago)

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment