Regression:Outline of overlay stays after zooming the page for pdf file.
Reported by
vku...@etouch.net,
Nov 7 2016
|
|||||||||||
Issue descriptionChrome Version:56.0.2911.0 (Official Build)Revision f902396696551c0a1cac9fd9ad3f9a3faf875aff-refs/heads/master@{#430171} (32/64-bit) OS:Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4) What steps will reproduce the problem? (1)Launch chrome and navigate to http://cb.vu/unixtoolbox.pdf (2)Hover mouse on pdf icon from top R.H.S of page such that tooltip appears (3)Now Zoom in the page to 110 % and observe. Actual: Outline of overlay stays after zooming the page. Expected: Outline of overlay should not be seen after zooming the page. This is a regression issue broken in 'M55' and below is the manual regression range Good Build: 55.0.2844.0 Bad Build: 55.0.2845.0
,
Nov 7 2016
,
Nov 7 2016
+ mcnee@ ... could this be related to your change Kevin?
,
Nov 7 2016
@wjmaclean, I just tested without my change and this bug still occurs. I'm guessing that this doesn't use SetLayerTransform, so it shouldn't hit my change at all.
,
Nov 7 2016
Thanks for testing ... good to rule that out.
,
Nov 9 2016
Thanks for checking. Yes, I'm the right owner.
,
Nov 14 2016
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium.git/+/c75dcd253d75ea93608410d90a3ce1b605590af0 commit c75dcd253d75ea93608410d90a3ce1b605590af0 Author: thestig <thestig@chromium.org> Date: Mon Nov 14 21:15:47 2016 Invalidate a slightly larger rect when updating popup annotations. It looks like sometimes there are rounding errors in the display pipeline when displaying / hiding popup annotations. Compensate by rouding up the damaged rect slightly. BUG= chromium:662804 Review-Url: https://codereview.chromium.org/2492733002 [modify] https://crrev.com/c75dcd253d75ea93608410d90a3ce1b605590af0/fpdfsdk/cpdfsdk_baannothandler.cpp
,
Nov 14 2016
Should be fixed on trunk today. Will wait for QA to verify before requesting a merge.
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/536cf7b135468bc3848faadae2b35089d22d46aa commit 536cf7b135468bc3848faadae2b35089d22d46aa Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org> Date: Tue Nov 15 03:49:39 2016 Roll src/third_party/pdfium/ e3c731526..343980241 (6 commits). https://pdfium.googlesource.com/pdfium.git/+log/e3c731526c04..3439802410dc $ git log e3c731526..343980241 --date=short --no-merges --format='%ad %ae %s' 2016-11-14 dsinclair Cleanup fwl_* classes and cfx_* classes in fwl. 2016-11-14 tsepez Make CPDF_PageContentGenerator methods take object numbers 2016-11-14 thestig Fix nits in CPDF_PageOrganizer. 2016-11-14 npm Fix some nits in pdfium_test 2016-11-14 thestig Invalidate a slightly larger rect when updating popup annotations. 2016-11-14 npm Properly release caches in CPDF_DocRenderData BUG= 660756 , 662804 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2499223002 Cr-Commit-Position: refs/heads/master@{#432083} [modify] https://crrev.com/536cf7b135468bc3848faadae2b35089d22d46aa/DEPS
,
Nov 17 2016
Still able to reproduce the issue on Windows-10, Mac 10.11.6 and Ubuntu 14.04 using latest dev #56.0.2922.0. thestig@ - Could you please confirm on the fix. Thanks...!!
,
Nov 17 2016
The attached video is what I see here. It looks fixed to me.
,
Nov 21 2016
krajshree@ - If it's not fixed, can you post a video to show what the bug looks like on your computer?
,
Nov 22 2016
Verified this issue on Ubuntu 14.04 using chrome latest Dev M56-56.0.2924.0 by following steps mentioned in the original comment. Observed the outline of overlay is not seen while zooming the pdf page. Hence adding TE-Verified. thestig@ Issue is still seen on chrome latest M55-55.0.2883.59. Could you please merge the same fix to M-55 branch version. Thanks!
,
Nov 22 2016
Request to merge https://pdfium.googlesource.com/pdfium.git/+/c75dcd253d75ea93608410d90a3ce1b605590af0 for M55.
,
Nov 22 2016
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.
,
Nov 22 2016
Approving merge to M55 branch 2883 based on comment #13. Please merge ASAP. Thank you.
,
Nov 22 2016
Merged: https://pdfium.googlesource.com/pdfium/+/dad0707d0e7ea3f612dd14a5e35b5af163cedf82 |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by msrchandra@chromium.org
, Nov 7 2016Labels: hasbisect-per-revision
Owner: jaepark@google.com
Status: Assigned (was: Unconfirmed)