New issue
Advanced search Search tips

Issue 662772 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 617492



Sign in to add a comment

Add metrics for memory coordinator

Project Member Reported by bashi@chromium.org, Nov 7 2016

Issue description

Comment 1 by bashi@chromium.org, Nov 7 2016

Blocking: 617492
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/051a90313eb6f6851bb463e415d73d8556d3366d

commit 051a90313eb6f6851bb463e415d73d8556d3366d
Author: bashi <bashi@chromium.org>
Date: Tue Nov 08 04:13:55 2016

Add StateOn{Moderate,Critical}NotificationReceived metrics

Record the global state of memory coordinator when memory pressure
notification is received. The purpose of this metrics is to make
sure the memory coordinator changes its global state to THROTTLED
or SUSPENDED before receiving memory pressure notifications.

BUG= 662772 

Review-Url: https://codereview.chromium.org/2482783002
Cr-Commit-Position: refs/heads/master@{#430517}

[modify] https://crrev.com/051a90313eb6f6851bb463e415d73d8556d3366d/base/memory/memory_coordinator_client.h
[modify] https://crrev.com/051a90313eb6f6851bb463e415d73d8556d3366d/content/browser/browser_main_loop.cc
[modify] https://crrev.com/051a90313eb6f6851bb463e415d73d8556d3366d/content/browser/memory/memory_coordinator.cc
[modify] https://crrev.com/051a90313eb6f6851bb463e415d73d8556d3366d/content/browser/memory/memory_coordinator.h
[modify] https://crrev.com/051a90313eb6f6851bb463e415d73d8556d3366d/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d351969bdb53d2ecf8f61db2987280a826cca738

commit d351969bdb53d2ecf8f61db2987280a826cca738
Author: bashi <bashi@chromium.org>
Date: Thu Nov 10 05:17:58 2016

memory coordinator: Add metrics for Android's onTrimMemory()

Record levels of onTrimMemory()[1]. Define separate histograms for each
memory state so that we can examine the behavior of the memory
coordinator. For example, the number of onTrimMemory() calls should be
smaller in NORMAL state than THROTTLED/SUSPENDED states.

[1]
https://developer.android.com/reference/android/content/ComponentCallbacks2.html#onTrimMemory(int)

Design doc:
https://docs.google.com/document/d/1Mlx7q_8thkoQtg_C7-CNA_y0SxSK0yp_ja9Zs4HmcwU/edit#heading=h.7g1az9n5ec1m

BUG= 662772 

Review-Url: https://codereview.chromium.org/2486573003
Cr-Commit-Position: refs/heads/master@{#431188}

[modify] https://crrev.com/d351969bdb53d2ecf8f61db2987280a826cca738/content/browser/memory/memory_monitor_android.cc
[modify] https://crrev.com/d351969bdb53d2ecf8f61db2987280a826cca738/content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java
[modify] https://crrev.com/d351969bdb53d2ecf8f61db2987280a826cca738/tools/metrics/histograms/histograms.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e7b2c2e9ad184a7e541f3eb1a30b9db34408f7a

commit 3e7b2c2e9ad184a7e541f3eb1a30b9db34408f7a
Author: bashi <bashi@chromium.org>
Date: Sat Nov 12 00:34:25 2016

Add metrics for memory coordinator global state change

Record some metrics when the memory coordinator changes its global
state. Added metrics are:
- Total private working set memory of the browser/renderers
- Elapsed time between state changes

Design doc: https://docs.google.com/document/d/1Mlx7q_8thkoQtg_C7-CNA_y0SxSK0yp_ja9Zs4HmcwU/edit?usp=sharing

BUG= 662772 

Review-Url: https://codereview.chromium.org/2476223002
Cr-Commit-Position: refs/heads/master@{#431709}

[modify] https://crrev.com/3e7b2c2e9ad184a7e541f3eb1a30b9db34408f7a/content/browser/memory/memory_coordinator_impl.cc
[modify] https://crrev.com/3e7b2c2e9ad184a7e541f3eb1a30b9db34408f7a/content/browser/memory/memory_coordinator_impl.h
[modify] https://crrev.com/3e7b2c2e9ad184a7e541f3eb1a30b9db34408f7a/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e2c875dca161e2b897d4cf454633c424b52f55b

commit 5e2c875dca161e2b897d4cf454633c424b52f55b
Author: bashi <bashi@chromium.org>
Date: Fri Dec 02 07:05:40 2016

Add MemoryCoordinator::GetGlobalMemoryState()

MemoryCoordinator::GetCurrentMemoryState() is not always the same as
the global memory state because the browser process won't be suspended
(at least for now). On the other hand, we want to have a way to record
the global memory state to tweak memory coordinator's parameters.
Add GetGlobalMemoryState() method which returns the raw value of the
global state. Keep GetCurrentMemoryState() for clients in the browser
process.

BUG= 662772 

Review-Url: https://codereview.chromium.org/2550623002
Cr-Commit-Position: refs/heads/master@{#435873}

[modify] https://crrev.com/5e2c875dca161e2b897d4cf454633c424b52f55b/content/browser/memory/memory_coordinator.cc
[modify] https://crrev.com/5e2c875dca161e2b897d4cf454633c424b52f55b/content/browser/memory/memory_coordinator.h
[modify] https://crrev.com/5e2c875dca161e2b897d4cf454633c424b52f55b/content/browser/memory/memory_coordinator_impl.cc
[modify] https://crrev.com/5e2c875dca161e2b897d4cf454633c424b52f55b/content/browser/memory/memory_coordinator_impl.h
[modify] https://crrev.com/5e2c875dca161e2b897d4cf454633c424b52f55b/content/browser/memory/memory_monitor_android.cc

Comment 7 by bashi@chromium.org, Feb 28 2017

Many metrics I added weren't very helpful. I'm going to deprecate most of them.

Comment 8 by bashi@chromium.org, Apr 11 2017

Status: WontFix (was: Started)

Sign in to add a comment