New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662771 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 692980



Sign in to add a comment

Buildbucket plugin should refresh token after 1 hour

Project Member Reported by andyb...@chromium.org, Nov 7 2016

Issue description

Currently the Buildbucket plugin only retrieves the token on initial load. It should refresh it after an hour once its lease is up.

 

Comment 1 by aga...@chromium.org, Nov 16 2016

Labels: Milestone-Launch
Owner: andyb...@chromium.org
Cc: andyb...@chromium.org tandrii@chromium.org aga...@chromium.org
 Issue 700890  has been merged into this issue.
Labels: -Pri-2 Pri-1

Comment 5 by aga...@chromium.org, Apr 21 2017

Blocking: 692980
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/c39883c28c004e1b58ff5925d6f72a4e5bb45fae

commit c39883c28c004e1b58ff5925d6f72a4e5bb45fae
Author: Andrew Bonventre <andybons@chromium.org>
Date: Thu Apr 27 20:02:15 2017

Refresh auth token when it expires

Also adds additional unit tests for untested components.

Bug:662771
Bug:680664
Bug:692980

Change-Id: I3dc2ea87a73953a4b4692694d89e4636352d5bcb
Reviewed-on: https://chromium-review.googlesource.com/486986
Reviewed-by: Aaron Gable <agable@chromium.org>

[add] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/src/main/resources/static/cr-buildbucket-client.js
[modify] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/src/main/resources/static/cr-tryjob-picker.js
[modify] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/test/cr-buildbucket-view_test.html
[modify] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/src/main/resources/static/cr-tryjob-picker.html
[add] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/src/main/resources/static/cr-buildbucket-client.html
[modify] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/src/main/resources/static/cr-buildbucket-view.html
[add] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/test/cr-buildbucket-client_test.html
[modify] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/test/index.html
[modify] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/src/main/resources/static/cr-buildbucket-view.js

Status: Fixed (was: Started)
Is this deployed?
It is on canary and will likely be in the main pool later this week. 

Sign in to add a comment