Issue 662761 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	mlamouri@chromium.org
Closed:	Aug 2017
Cc:	liber...@chromium.org foolip@chromium.org
Components:	Blink>Media>Controls
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	2
Type:	Bug
M-61

Blocked on:
issue 669977

Blocking:
issue 731143

Modularise MediaControls (and abstract from HTMLMediaElement)

Project Member Reported by mlamouri@chromium.org, Nov 6 2016

Issue description

The short term goal is for MediaControls to react to HTMLMediaElement changes via event handlers instead of having HTMLMediaElement calling into MediaControls.

The long term goal is to have a MediaControls interface that will allow MediaControls to have different implementations.

Comment 1 by mlamouri@chromium.org, Nov 6 2016

Cc: foolip@chromium.org liber...@chromium.org

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15099fe2bbea4d7a205c0ef6220d23cfc6a802e2

commit 15099fe2bbea4d7a205c0ef6220d23cfc6a802e2
Author: mlamouri <mlamouri@chromium.org>
Date: Tue Nov 15 01:52:09 2016

Media Controls: delegate 'volumechange' and 'focusin' handling to an EventListener.

MediaControls has an EventListener handling some HTMLMediaElement events
in order for the media element to no longer depends on MediaControls.

BUG= 662761 

Review-Url: https://codereview.chromium.org/2477203002
Cr-Commit-Position: refs/heads/master@{#432053}

[add] https://crrev.com/15099fe2bbea4d7a205c0ef6220d23cfc6a802e2/third_party/WebKit/LayoutTests/media/controls/volumechange-muted-attribute-expected.html
[add] https://crrev.com/15099fe2bbea4d7a205c0ef6220d23cfc6a802e2/third_party/WebKit/LayoutTests/media/controls/volumechange-muted-attribute.html
[add] https://crrev.com/15099fe2bbea4d7a205c0ef6220d23cfc6a802e2/third_party/WebKit/LayoutTests/media/controls/volumechange-stopimmediatepropagation-expected.html
[add] https://crrev.com/15099fe2bbea4d7a205c0ef6220d23cfc6a802e2/third_party/WebKit/LayoutTests/media/controls/volumechange-stopimmediatepropagation.html
[modify] https://crrev.com/15099fe2bbea4d7a205c0ef6220d23cfc6a802e2/third_party/WebKit/LayoutTests/media/video-controls-hidden-audio.html
[modify] https://crrev.com/15099fe2bbea4d7a205c0ef6220d23cfc6a802e2/third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/15099fe2bbea4d7a205c0ef6220d23cfc6a802e2/third_party/WebKit/LayoutTests/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/15099fe2bbea4d7a205c0ef6220d23cfc6a802e2/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/15099fe2bbea4d7a205c0ef6220d23cfc6a802e2/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/15099fe2bbea4d7a205c0ef6220d23cfc6a802e2/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/15099fe2bbea4d7a205c0ef6220d23cfc6a802e2/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/15099fe2bbea4d7a205c0ef6220d23cfc6a802e2/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/15099fe2bbea4d7a205c0ef6220d23cfc6a802e2/third_party/WebKit/Source/core/html/shadow/MediaControls.h
[add] https://crrev.com/15099fe2bbea4d7a205c0ef6220d23cfc6a802e2/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp
[add] https://crrev.com/15099fe2bbea4d7a205c0ef6220d23cfc6a802e2/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.h

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88ea177babd78b83478c082a903c45e8b3499703

commit 88ea177babd78b83478c082a903c45e8b3499703
Author: mlamouri <mlamouri@chromium.org>
Date: Wed Nov 30 11:39:01 2016

Media Controls: handle 'timeupdate', 'play' and 'pause' via an EventListener.

Instead of having hard coded plumbing from HTMLMediaElement to MediaControls.

BUG= 662761 

Review-Url: https://codereview.chromium.org/2499883002
Cr-Commit-Position: refs/heads/master@{#435220}

[delete] https://crrev.com/cc9890fd0fc8431b1462b191b5306b25a45c29fa/third_party/WebKit/LayoutTests/media/controls-after-unload-expected.html
[delete] https://crrev.com/cc9890fd0fc8431b1462b191b5306b25a45c29fa/third_party/WebKit/LayoutTests/media/controls-after-unload.html
[add] https://crrev.com/88ea177babd78b83478c082a903c45e8b3499703/third_party/WebKit/LayoutTests/media/controls/time-update-after-unload-expected.html
[add] https://crrev.com/88ea177babd78b83478c082a903c45e8b3499703/third_party/WebKit/LayoutTests/media/controls/time-update-after-unload.html
[modify] https://crrev.com/88ea177babd78b83478c082a903c45e8b3499703/third_party/WebKit/LayoutTests/paint/invalidation/canvas-composite-repaint-by-all-imagesource.html
[modify] https://crrev.com/88ea177babd78b83478c082a903c45e8b3499703/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/88ea177babd78b83478c082a903c45e8b3499703/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/88ea177babd78b83478c082a903c45e8b3499703/third_party/WebKit/Source/core/html/shadow/MediaControls.h
[modify] https://crrev.com/88ea177babd78b83478c082a903c45e8b3499703/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

Comment 4 by mlamouri@chromium.org, Nov 30 2016

Blockedon: 669977

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a069837e9fe584243f357ca535ca0bebd0b7de85

commit a069837e9fe584243f357ca535ca0bebd0b7de85
Author: mlamouri <mlamouri@chromium.org>
Date: Mon Dec 05 16:43:56 2016

Media Controls: Use events to update controls for closed captions.

This is using addtrack, removetrack and change events on the TextTrackList exposed
on the media element to be notified and update the closed captions button. Because
the events are asynchronous, some tests have to be modified to be asynchronous.
They have been moved to media/controls/ too.

There is one hook that was added in order to notify the controls that an
HTMLTrackElement failed to load. There is no clear way to figure that out otherwise.
An HTML issue has been opened: https://github.com/whatwg/html/issues/2121

BUG= 662761 

Review-Url: https://codereview.chromium.org/2539023002
Cr-Commit-Position: refs/heads/master@{#436321}

[modify] https://crrev.com/a069837e9fe584243f357ca535ca0bebd0b7de85/third_party/WebKit/LayoutTests/http/tests/media/video-controls-overflow-menu-updates-appropriately.html
[add] https://crrev.com/a069837e9fe584243f357ca535ca0bebd0b7de85/third_party/WebKit/LayoutTests/media/controls/closed-captions-dynamic-update.html
[add] https://crrev.com/a069837e9fe584243f357ca535ca0bebd0b7de85/third_party/WebKit/LayoutTests/media/controls/closed-captions-on-off.html
[add] https://crrev.com/a069837e9fe584243f357ca535ca0bebd0b7de85/third_party/WebKit/LayoutTests/media/controls/closed-captions-single-track.html
[add] https://crrev.com/a069837e9fe584243f357ca535ca0bebd0b7de85/third_party/WebKit/LayoutTests/media/controls/closed-captions-switch-track.html
[delete] https://crrev.com/d7af8155b1a7a903929b2a932a8a4d807eac487c/third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-multiple-tracks.html
[delete] https://crrev.com/d7af8155b1a7a903929b2a932a8a4d807eac487c/third_party/WebKit/LayoutTests/media/video-controls-caption-single-track.html
[delete] https://crrev.com/d7af8155b1a7a903929b2a932a8a4d807eac487c/third_party/WebKit/LayoutTests/media/video-controls-captions-on-off.html
[delete] https://crrev.com/d7af8155b1a7a903929b2a932a8a4d807eac487c/third_party/WebKit/LayoutTests/media/video-controls-captions.html
[modify] https://crrev.com/a069837e9fe584243f357ca535ca0bebd0b7de85/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/a069837e9fe584243f357ca535ca0bebd0b7de85/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/a069837e9fe584243f357ca535ca0bebd0b7de85/third_party/WebKit/Source/core/html/shadow/MediaControls.h
[modify] https://crrev.com/a069837e9fe584243f357ca535ca0bebd0b7de85/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc2d34472dd3e60dabae58359a7cae0c49ae6555

commit bc2d34472dd3e60dabae58359a7cae0c49ae6555
Author: zqzhang <zqzhang@chromium.org>
Date: Tue Dec 13 22:16:54 2016

[MediaControls] Listen to durationchange instead of letting HTML call methods of MediaControls

BUG= 662761 

Review-Url: https://codereview.chromium.org/2563853003
Cr-Commit-Position: refs/heads/master@{#438309}

[modify] https://crrev.com/bc2d34472dd3e60dabae58359a7cae0c49ae6555/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/bc2d34472dd3e60dabae58359a7cae0c49ae6555/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/bc2d34472dd3e60dabae58359a7cae0c49ae6555/third_party/WebKit/Source/core/html/shadow/MediaControls.h
[modify] https://crrev.com/bc2d34472dd3e60dabae58359a7cae0c49ae6555/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7560683aca33e39e1a4629118267d9e2299d612

commit b7560683aca33e39e1a4629118267d9e2299d612
Author: mlamouri <mlamouri@chromium.org>
Date: Mon Dec 19 18:02:54 2016

Media Controls: use loadedmetadata and error events.

This is temporarily using ::reset() to guarantee backward compatibility
and reduce chances of breakage for now.

BUG= 662761 
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2589873002
Cr-Commit-Position: refs/heads/master@{#439503}

[modify] https://crrev.com/b7560683aca33e39e1a4629118267d9e2299d612/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/b7560683aca33e39e1a4629118267d9e2299d612/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/b7560683aca33e39e1a4629118267d9e2299d612/third_party/WebKit/Source/core/html/shadow/MediaControls.h
[modify] https://crrev.com/b7560683aca33e39e1a4629118267d9e2299d612/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a88699d96b19b3895630c526243411d13873ae5

commit 5a88699d96b19b3895630c526243411d13873ae5
Author: mlamouri <mlamouri@chromium.org>
Date: Mon Dec 19 18:54:53 2016

Media Controls: add comments regarding cast/remote related calls from element.

We can't really make the calls use an event in the current situation.
Adding TODO's to explain how it should be done and rename methods for
future usage

BUG= 662761 
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2587083002
Cr-Commit-Position: refs/heads/master@{#439514}

[modify] https://crrev.com/5a88699d96b19b3895630c526243411d13873ae5/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/5a88699d96b19b3895630c526243411d13873ae5/third_party/WebKit/Source/core/html/shadow/MediaControls.h

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c68be804b1f752a88b2c0e2e7a086945ef0494c

commit 2c68be804b1f752a88b2c0e2e7a086945ef0494c
Author: mlamouri <mlamouri@chromium.org>
Date: Tue Dec 20 13:30:37 2016

Media Controls: use events to enter/exit fullscreen.

This is also adding MediaControlsMediaEventListener::mediaElement() and
always call `m_fullscreenButton->setIsFullscreen` in ::reset() to avoid
the dependency when the controls are first created.

BUG= 662761 
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2592443002
Cr-Commit-Position: refs/heads/master@{#439785}

[modify] https://crrev.com/2c68be804b1f752a88b2c0e2e7a086945ef0494c/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/2c68be804b1f752a88b2c0e2e7a086945ef0494c/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/2c68be804b1f752a88b2c0e2e7a086945ef0494c/third_party/WebKit/Source/core/html/shadow/MediaControls.h
[modify] https://crrev.com/2c68be804b1f752a88b2c0e2e7a086945ef0494c/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp
[modify] https://crrev.com/2c68be804b1f752a88b2c0e2e7a086945ef0494c/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.h

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0651819997c475b2ed28428e0fb81e72c82eab8

commit a0651819997c475b2ed28428e0fb81e72c82eab8
Author: mlamouri <mlamouri@chromium.org>
Date: Tue Dec 20 15:55:41 2016

Media Controls: change how the MediaControls object is created and handled.

The HTMLMediaElement no longer adds the MediaControls to the shadow tree
in order to prepare for the class to be an interface implemented by
modules. This CL also removes a couple of reset() call.

BUG= 662761 
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2588823002
Cr-Commit-Position: refs/heads/master@{#439811}

[modify] https://crrev.com/a0651819997c475b2ed28428e0fb81e72c82eab8/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/a0651819997c475b2ed28428e0fb81e72c82eab8/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/a0651819997c475b2ed28428e0fb81e72c82eab8/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/a0651819997c475b2ed28428e0fb81e72c82eab8/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/a0651819997c475b2ed28428e0fb81e72c82eab8/third_party/WebKit/Source/core/html/shadow/MediaControls.h

Comment 11 by mlamouri@chromium.org, Feb 17 2017

Labels: -M-57 M-59

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56ee1a3113f01d783795890d0235387fdcc8d02e

commit 56ee1a3113f01d783795890d0235387fdcc8d02e
Author: mlamouri <mlamouri@chromium.org>
Date: Thu Apr 06 14:30:07 2017

Move core MediaControls implementation to modules/media_controls/.

This is also moving MediaControlsOrientationLockDelegate because the
tests required to use MediaControlsImpl and the class is only used by
MediaControlsImpl.

This CL will allow other parts of MediaControls to move to modules/ as
MediaControlsImpl has a few components with rare dependencies in core/.

BUG= 662761 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2795783004
Cr-Commit-Position: refs/heads/master@{#462464}

[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/html/media/HTMLMediaElementControlsList.h
[add] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/html/media/MediaControls.cpp
[add] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/html/media/MediaControls.h
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.h
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/html/shadow/MediaControlsWindowEventListener.cpp
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/html/shadow/MediaControlsWindowEventListener.h
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/layout/LayoutMedia.cpp
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[add] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/modules/media_controls/BUILD.gn
[add] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/modules/media_controls/DEPS
[rename] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[rename] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[rename] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
[rename] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.cpp
[rename] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.h
[rename] https://crrev.com/56ee1a3113f01d783795890d0235387fdcc8d02e/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0364a2865e00032fc00d2619371e4975ebdbcf5

commit a0364a2865e00032fc00d2619371e4975ebdbcf5
Author: mlamouri <mlamouri@chromium.org>
Date: Mon Apr 10 13:42:55 2017

Move MediaControlsWindowEventListener to modules/media_controls/.

BUG= 662761 
R=avayvod@chromium.org,haraken@chromium.org

Review-Url: https://codereview.chromium.org/2802133002
Cr-Commit-Position: refs/heads/master@{#463246}

[modify] https://crrev.com/a0364a2865e00032fc00d2619371e4975ebdbcf5/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/a0364a2865e00032fc00d2619371e4975ebdbcf5/third_party/WebKit/Source/core/html/media/MediaControls.h
[modify] https://crrev.com/a0364a2865e00032fc00d2619371e4975ebdbcf5/third_party/WebKit/Source/modules/media_controls/BUILD.gn
[modify] https://crrev.com/a0364a2865e00032fc00d2619371e4975ebdbcf5/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/a0364a2865e00032fc00d2619371e4975ebdbcf5/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/a0364a2865e00032fc00d2619371e4975ebdbcf5/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
[rename] https://crrev.com/a0364a2865e00032fc00d2619371e4975ebdbcf5/third_party/WebKit/Source/modules/media_controls/MediaControlsWindowEventListener.cpp
[rename] https://crrev.com/a0364a2865e00032fc00d2619371e4975ebdbcf5/third_party/WebKit/Source/modules/media_controls/MediaControlsWindowEventListener.h

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e98522ee9fdfac2dde0cc806466f14d87258555f

commit e98522ee9fdfac2dde0cc806466f14d87258555f
Author: mlamouri <mlamouri@chromium.org>
Date: Mon Apr 10 13:50:09 2017

Move MediaControlsMediaEventListener to modules/media_controls/.

BUG= 662761 
R=avayvod@chromium.org,haraken@chromium.org

Review-Url: https://codereview.chromium.org/2805013003
Cr-Commit-Position: refs/heads/master@{#463248}

[modify] https://crrev.com/e98522ee9fdfac2dde0cc806466f14d87258555f/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/e98522ee9fdfac2dde0cc806466f14d87258555f/third_party/WebKit/Source/core/html/media/MediaControls.h
[modify] https://crrev.com/e98522ee9fdfac2dde0cc806466f14d87258555f/third_party/WebKit/Source/modules/media_controls/BUILD.gn
[modify] https://crrev.com/e98522ee9fdfac2dde0cc806466f14d87258555f/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/e98522ee9fdfac2dde0cc806466f14d87258555f/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[rename] https://crrev.com/e98522ee9fdfac2dde0cc806466f14d87258555f/third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.cpp
[rename] https://crrev.com/e98522ee9fdfac2dde0cc806466f14d87258555f/third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.h

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acec8c887e478089826d2e52a93c1a173d2d1fbc

commit acec8c887e478089826d2e52a93c1a173d2d1fbc
Author: mlamouri <mlamouri@chromium.org>
Date: Tue Apr 11 09:14:34 2017

Move a few media controls elements into modules/media_controls/elements/.

This serve two purpose: move the elements implementations to modules/
but also split MediaControlElements.cpp into multiple files as it as
become very messy.

BUG= 662761 
R=avayvod@chromium.org

Review-Url: https://codereview.chromium.org/2811703002
Cr-Commit-Position: refs/heads/master@{#463583}

[modify] https://crrev.com/acec8c887e478089826d2e52a93c1a173d2d1fbc/third_party/WebKit/Source/core/html/media/MediaControls.h
[modify] https://crrev.com/acec8c887e478089826d2e52a93c1a173d2d1fbc/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/acec8c887e478089826d2e52a93c1a173d2d1fbc/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
[modify] https://crrev.com/acec8c887e478089826d2e52a93c1a173d2d1fbc/third_party/WebKit/Source/modules/media_controls/BUILD.gn
[modify] https://crrev.com/acec8c887e478089826d2e52a93c1a173d2d1fbc/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/acec8c887e478089826d2e52a93c1a173d2d1fbc/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[add] https://crrev.com/acec8c887e478089826d2e52a93c1a173d2d1fbc/third_party/WebKit/Source/modules/media_controls/elements/MediaControlMuteButtonElement.cpp
[add] https://crrev.com/acec8c887e478089826d2e52a93c1a173d2d1fbc/third_party/WebKit/Source/modules/media_controls/elements/MediaControlMuteButtonElement.h
[add] https://crrev.com/acec8c887e478089826d2e52a93c1a173d2d1fbc/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayEnclosureElement.cpp
[add] https://crrev.com/acec8c887e478089826d2e52a93c1a173d2d1fbc/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayEnclosureElement.h
[add] https://crrev.com/acec8c887e478089826d2e52a93c1a173d2d1fbc/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPanelEnclosureElement.cpp
[add] https://crrev.com/acec8c887e478089826d2e52a93c1a173d2d1fbc/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPanelEnclosureElement.h

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b02781acf9884bcbea21eb0b7c6de8dfd34d0a0

commit 5b02781acf9884bcbea21eb0b7c6de8dfd34d0a0
Author: mlamouri <mlamouri@chromium.org>
Date: Wed Apr 12 00:40:06 2017

Media Controls: move time display elements to media_controls module.

This is moving the two elements using MediaControlTimeDisplayElement to
the modules directory. The base class will be moved later as it is used
in the accessibility code.

BUG= 662761 
R=avayvod@chromium.org

Review-Url: https://codereview.chromium.org/2814703002
Cr-Commit-Position: refs/heads/master@{#463859}

[modify] https://crrev.com/5b02781acf9884bcbea21eb0b7c6de8dfd34d0a0/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/5b02781acf9884bcbea21eb0b7c6de8dfd34d0a0/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
[modify] https://crrev.com/5b02781acf9884bcbea21eb0b7c6de8dfd34d0a0/third_party/WebKit/Source/modules/media_controls/BUILD.gn
[modify] https://crrev.com/5b02781acf9884bcbea21eb0b7c6de8dfd34d0a0/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/5b02781acf9884bcbea21eb0b7c6de8dfd34d0a0/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/5b02781acf9884bcbea21eb0b7c6de8dfd34d0a0/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
[add] https://crrev.com/5b02781acf9884bcbea21eb0b7c6de8dfd34d0a0/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCurrentTimeDisplayElement.cpp
[add] https://crrev.com/5b02781acf9884bcbea21eb0b7c6de8dfd34d0a0/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCurrentTimeDisplayElement.h
[add] https://crrev.com/5b02781acf9884bcbea21eb0b7c6de8dfd34d0a0/third_party/WebKit/Source/modules/media_controls/elements/MediaControlRemainingTimeDisplayElement.cpp
[add] https://crrev.com/5b02781acf9884bcbea21eb0b7c6de8dfd34d0a0/third_party/WebKit/Source/modules/media_controls/elements/MediaControlRemainingTimeDisplayElement.h

Project Member

Comment 17 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a77b04a2af76e6eb19db28716651912d2621d040

commit a77b04a2af76e6eb19db28716651912d2621d040
Author: mlamouri <mlamouri@chromium.org>
Date: Fri Apr 14 01:39:29 2017

Media Controls: move all MediaControlDivElement sub-classes to modules/.

This isn't moving MediaControlDivElement as all the classes in
MediaControlElementTypes will be handled later. However, there is no
usage of this class outside of modules/ or MediaControlElementTypes
itself now.

BUG= 662761 
R=avayvod@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2810173003
Cr-Commit-Position: refs/heads/master@{#464649}

[modify] https://crrev.com/a77b04a2af76e6eb19db28716651912d2621d040/third_party/WebKit/Source/core/html/media/MediaControls.h
[modify] https://crrev.com/a77b04a2af76e6eb19db28716651912d2621d040/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/a77b04a2af76e6eb19db28716651912d2621d040/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
[modify] https://crrev.com/a77b04a2af76e6eb19db28716651912d2621d040/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp
[modify] https://crrev.com/a77b04a2af76e6eb19db28716651912d2621d040/third_party/WebKit/Source/modules/media_controls/BUILD.gn
[modify] https://crrev.com/a77b04a2af76e6eb19db28716651912d2621d040/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/a77b04a2af76e6eb19db28716651912d2621d040/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/a77b04a2af76e6eb19db28716651912d2621d040/third_party/WebKit/Source/modules/media_controls/MediaControlsWindowEventListener.cpp
[add] https://crrev.com/a77b04a2af76e6eb19db28716651912d2621d040/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.cpp
[add] https://crrev.com/a77b04a2af76e6eb19db28716651912d2621d040/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.h
[add] https://crrev.com/a77b04a2af76e6eb19db28716651912d2621d040/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuListElement.cpp
[add] https://crrev.com/a77b04a2af76e6eb19db28716651912d2621d040/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuListElement.h
[add] https://crrev.com/a77b04a2af76e6eb19db28716651912d2621d040/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPanelElement.cpp
[add] https://crrev.com/a77b04a2af76e6eb19db28716651912d2621d040/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPanelElement.h
[add] https://crrev.com/a77b04a2af76e6eb19db28716651912d2621d040/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTextTrackListElement.cpp
[add] https://crrev.com/a77b04a2af76e6eb19db28716651912d2621d040/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTextTrackListElement.h

Project Member

Comment 18 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4e2060346a37d1916e79ad33692c27722cfd917

commit e4e2060346a37d1916e79ad33692c27722cfd917
Author: mlamouri <mlamouri@chromium.org>
Date: Fri Apr 14 17:11:40 2017

Media Controls: move simple buttons to modules/.

This is moving the simple buttons, leaving two buttons with some more
logic and the two sliders.

BUG= 662761 
R=avayvod@chromium.org

Review-Url: https://codereview.chromium.org/2820633003
Cr-Commit-Position: refs/heads/master@{#464741}

[modify] https://crrev.com/e4e2060346a37d1916e79ad33692c27722cfd917/third_party/WebKit/Source/core/html/media/MediaControls.h
[modify] https://crrev.com/e4e2060346a37d1916e79ad33692c27722cfd917/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/e4e2060346a37d1916e79ad33692c27722cfd917/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
[modify] https://crrev.com/e4e2060346a37d1916e79ad33692c27722cfd917/third_party/WebKit/Source/modules/media_controls/BUILD.gn
[modify] https://crrev.com/e4e2060346a37d1916e79ad33692c27722cfd917/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/e4e2060346a37d1916e79ad33692c27722cfd917/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[add] https://crrev.com/e4e2060346a37d1916e79ad33692c27722cfd917/third_party/WebKit/Source/modules/media_controls/elements/MediaControlFullscreenButtonElement.cpp
[add] https://crrev.com/e4e2060346a37d1916e79ad33692c27722cfd917/third_party/WebKit/Source/modules/media_controls/elements/MediaControlFullscreenButtonElement.h
[add] https://crrev.com/e4e2060346a37d1916e79ad33692c27722cfd917/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuButtonElement.cpp
[add] https://crrev.com/e4e2060346a37d1916e79ad33692c27722cfd917/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuButtonElement.h
[add] https://crrev.com/e4e2060346a37d1916e79ad33692c27722cfd917/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp
[add] https://crrev.com/e4e2060346a37d1916e79ad33692c27722cfd917/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.h
[add] https://crrev.com/e4e2060346a37d1916e79ad33692c27722cfd917/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPlayButtonElement.cpp
[add] https://crrev.com/e4e2060346a37d1916e79ad33692c27722cfd917/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPlayButtonElement.h
[add] https://crrev.com/e4e2060346a37d1916e79ad33692c27722cfd917/third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.cpp
[add] https://crrev.com/e4e2060346a37d1916e79ad33692c27722cfd917/third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.h

Project Member

Comment 19 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be87179197a85107c1953022480f5284618b687f

commit be87179197a85107c1953022480f5284618b687f
Author: mlamouri <mlamouri@chromium.org>
Date: Fri Apr 14 17:57:54 2017

Media Controls: move last buttons to modules/.

Only the two sliders are defined in core/html/shadow and will be moved
next. MediaControlElementTypes classes will be moved afterward.

BUG= 662761 
R=avayvod@chromium.org

Review-Url: https://codereview.chromium.org/2813103006
Cr-Commit-Position: refs/heads/master@{#464752}

[modify] https://crrev.com/be87179197a85107c1953022480f5284618b687f/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/be87179197a85107c1953022480f5284618b687f/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
[modify] https://crrev.com/be87179197a85107c1953022480f5284618b687f/third_party/WebKit/Source/modules/media_controls/BUILD.gn
[modify] https://crrev.com/be87179197a85107c1953022480f5284618b687f/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/be87179197a85107c1953022480f5284618b687f/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/be87179197a85107c1953022480f5284618b687f/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
[modify] https://crrev.com/be87179197a85107c1953022480f5284618b687f/third_party/WebKit/Source/modules/media_controls/MediaControlsWindowEventListener.cpp
[add] https://crrev.com/be87179197a85107c1953022480f5284618b687f/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp
[add] https://crrev.com/be87179197a85107c1953022480f5284618b687f/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.h
[add] https://crrev.com/be87179197a85107c1953022480f5284618b687f/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp
[add] https://crrev.com/be87179197a85107c1953022480f5284618b687f/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.h

Project Member

Comment 20 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/322f0d1c2543907fcc64ebcf55845d91c8b7e88b

commit 322f0d1c2543907fcc64ebcf55845d91c8b7e88b
Author: mlamouri <mlamouri@chromium.org>
Date: Thu Apr 20 17:25:34 2017

Media Controls: move timeline related code to modules.

This is moving the timeline slider code and its metrics helper class. It
is also moving a method out of MediaControls.h that should have happen
in a different CL. Because of headers being reduced, the CL also
requires to add a few headers to implement files.

BUG= 662761 
R=avayvod@chromium.org,jochen@chromium.org

Review-Url: https://codereview.chromium.org/2820343002
Cr-Commit-Position: refs/heads/master@{#466048}

[modify] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/core/html/media/MediaControls.h
[modify] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
[modify] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/core/layout/LayoutSlider.h
[modify] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/core/layout/api/LayoutSliderItem.h
[modify] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/modules/media_controls/BUILD.gn
[modify] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
[modify] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/modules/media_controls/MediaControlsWindowEventListener.cpp
[modify] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp
[modify] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp
[modify] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.cpp
[modify] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.h
[modify] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuButtonElement.cpp
[add] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp
[add] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h
[rename] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineMetrics.cpp
[rename] https://crrev.com/322f0d1c2543907fcc64ebcf55845d91c8b7e88b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineMetrics.h

Project Member

Comment 21 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0718c3ee0d51683879cf7817f3615e8a0ed69a80

commit 0718c3ee0d51683879cf7817f3615e8a0ed69a80
Author: mlamouri <mlamouri@chromium.org>
Date: Tue Apr 25 17:59:34 2017

Media Controls: move volume slider to modules/.

This is also removing MediaControlElements.{h,cpp} from core/html/shadow/.

BUG= 662761 
R=avayvod@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2830653002
Cr-Commit-Position: refs/heads/master@{#467043}

[modify] https://crrev.com/0718c3ee0d51683879cf7817f3615e8a0ed69a80/third_party/WebKit/Source/core/html/BUILD.gn
[delete] https://crrev.com/536eef87010475f6ba4b24a080192499e3487561/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[delete] https://crrev.com/536eef87010475f6ba4b24a080192499e3487561/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
[modify] https://crrev.com/0718c3ee0d51683879cf7817f3615e8a0ed69a80/third_party/WebKit/Source/core/layout/BUILD.gn
[modify] https://crrev.com/0718c3ee0d51683879cf7817f3615e8a0ed69a80/third_party/WebKit/Source/core/layout/LayoutTheme.cpp
[add] https://crrev.com/0718c3ee0d51683879cf7817f3615e8a0ed69a80/third_party/WebKit/Source/core/layout/api/LayoutSliderItem.cpp
[modify] https://crrev.com/0718c3ee0d51683879cf7817f3615e8a0ed69a80/third_party/WebKit/Source/core/layout/api/LayoutSliderItem.h
[modify] https://crrev.com/0718c3ee0d51683879cf7817f3615e8a0ed69a80/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp
[modify] https://crrev.com/0718c3ee0d51683879cf7817f3615e8a0ed69a80/third_party/WebKit/Source/modules/accessibility/AXMediaControls.h
[modify] https://crrev.com/0718c3ee0d51683879cf7817f3615e8a0ed69a80/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/0718c3ee0d51683879cf7817f3615e8a0ed69a80/third_party/WebKit/Source/modules/media_controls/BUILD.gn
[modify] https://crrev.com/0718c3ee0d51683879cf7817f3615e8a0ed69a80/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/0718c3ee0d51683879cf7817f3615e8a0ed69a80/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/0718c3ee0d51683879cf7817f3615e8a0ed69a80/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
[modify] https://crrev.com/0718c3ee0d51683879cf7817f3615e8a0ed69a80/third_party/WebKit/Source/modules/media_controls/MediaControlsWindowEventListener.cpp
[modify] https://crrev.com/0718c3ee0d51683879cf7817f3615e8a0ed69a80/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.cpp
[add] https://crrev.com/0718c3ee0d51683879cf7817f3615e8a0ed69a80/third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.cpp
[add] https://crrev.com/0718c3ee0d51683879cf7817f3615e8a0ed69a80/third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.h

Comment 22 by mlamouri@chromium.org, Apr 28 2017

Labels: -M-59 M-61

Comment 23 by mlamouri@chromium.org, Jun 8 2017

Blocking: 731143

Comment 24 by mlamouri@chromium.org, Jul 6 2017

Summary: Modularise MediaControls (and abstract from HTMLMediaElement) (was: Abstract MediaControls from HTMLMediaElement)

Renaming the bug as it's been used for modularisation and abstraction.

Project Member

Comment 25 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31d3264bf520dacadd6c0c695a8df1d3754497d9

commit 31d3264bf520dacadd6c0c695a8df1d3754497d9
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Thu Jul 06 14:02:25 2017

Move MediaControlTimeDisplayElement to modules/media_controls/

Bug:  662761 
Change-Id: I1f5aeb2a14602444ccc808545b51bd398f8c195b
Reviewed-on: https://chromium-review.googlesource.com/559153
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Anton Vayvod <avayvod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484575}
[modify] https://crrev.com/31d3264bf520dacadd6c0c695a8df1d3754497d9/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp
[modify] https://crrev.com/31d3264bf520dacadd6c0c695a8df1d3754497d9/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h
[modify] https://crrev.com/31d3264bf520dacadd6c0c695a8df1d3754497d9/third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp
[modify] https://crrev.com/31d3264bf520dacadd6c0c695a8df1d3754497d9/third_party/WebKit/Source/modules/accessibility/DEPS
[modify] https://crrev.com/31d3264bf520dacadd6c0c695a8df1d3754497d9/third_party/WebKit/Source/modules/media_controls/BUILD.gn
[modify] https://crrev.com/31d3264bf520dacadd6c0c695a8df1d3754497d9/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCurrentTimeDisplayElement.h
[modify] https://crrev.com/31d3264bf520dacadd6c0c695a8df1d3754497d9/third_party/WebKit/Source/modules/media_controls/elements/MediaControlRemainingTimeDisplayElement.h
[add] https://crrev.com/31d3264bf520dacadd6c0c695a8df1d3754497d9/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimeDisplayElement.cpp
[add] https://crrev.com/31d3264bf520dacadd6c0c695a8df1d3754497d9/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimeDisplayElement.h

Project Member

Comment 26 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1d5caac1a8ed64ca5539ca7070ea9426e30fe4c

commit a1d5caac1a8ed64ca5539ca7070ea9426e30fe4c
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Thu Jul 06 17:40:22 2017

Remove latest MediaControlElementTypes dependency from core/.

This will allow to move the remainder of the file to modules/.

This is duplicating some logic in MediaControlPainter and media_controls/
code but in the long term, MediaControlPainter should either moved to
modules/ or be removed in favour of painting with CSS.

Bug:  662761 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iaaafacf224cd080128890ab09e14614be4d26699
Reviewed-on: https://chromium-review.googlesource.com/558246
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484658}
[modify] https://crrev.com/a1d5caac1a8ed64ca5539ca7070ea9426e30fe4c/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp

Project Member

Comment 27 by bugdroid1@chromium.org, Jul 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b9102f9588fb6cf639a6165fd4777658d5ade0d

commit 4b9102f9588fb6cf639a6165fd4777658d5ade0d
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Sat Jul 08 09:30:36 2017

Remove MediaControlElementTypes.* from core/html/ (to modules/).

This is moving the remaining three classes and enum to modules as none
of these are now used outside of modules/media_controls/ and
modules/accessibility/.

Bug:  662761 
Change-Id: I6e89ae252e6f6a10c25a7650cb8a88f90d798880
Reviewed-on: https://chromium-review.googlesource.com/563300
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Anton Vayvod <avayvod@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485143}
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/core/html/media/MediaControls.h
[delete] https://crrev.com/981fa39e2dde70f5933ea2db88123582ab955632/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp
[delete] https://crrev.com/981fa39e2dde70f5933ea2db88123582ab955632/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/accessibility/AXMediaControls.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/BUILD.gn
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.h
[add] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDivElement.cpp
[add] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDivElement.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.h
[add] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementBase.cpp
[add] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementBase.h
[add] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementType.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.cpp
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlFullscreenButtonElement.cpp
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlFullscreenButtonElement.h
[add] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.cpp
[add] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlMuteButtonElement.cpp
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlMuteButtonElement.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuButtonElement.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuListElement.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayEnclosureElement.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPanelElement.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPanelEnclosureElement.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPlayButtonElement.cpp
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPlayButtonElement.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTextTrackListElement.cpp
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTextTrackListElement.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimeDisplayElement.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.cpp
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.h
[modify] https://crrev.com/4b9102f9588fb6cf639a6165fd4777658d5ade0d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.h

Project Member

Comment 28 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c36b9d6d6ca3e3ee06dd11c82955a18f4f1409d

commit 7c36b9d6d6ca3e3ee06dd11c82955a18f4f1409d
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Mon Jul 17 16:48:19 2017

Remove static_cast<MediaControlsImpl*> that are no longer needed with the refactoring.

With all the media controls code moved the modules, there is no need to
cast from the MediaControls interface to the its modules' implementation.
The few remaining static_cast<> are from code calling the GetMediaControls()
method defined on the HTMLMediaElement.

Bug:  662761 
Change-Id: Ic72baca68f1c54d6117ea47efdf9a808b3d02aea
Reviewed-on: https://chromium-review.googlesource.com/571820
Reviewed-by: Jennifer Apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487118}
[modify] https://crrev.com/7c36b9d6d6ca3e3ee06dd11c82955a18f4f1409d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlFullscreenButtonElement.cpp
[modify] https://crrev.com/7c36b9d6d6ca3e3ee06dd11c82955a18f4f1409d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuButtonElement.cpp
[modify] https://crrev.com/7c36b9d6d6ca3e3ee06dd11c82955a18f4f1409d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayEnclosureElement.cpp
[modify] https://crrev.com/7c36b9d6d6ca3e3ee06dd11c82955a18f4f1409d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTextTrackListElement.cpp
[modify] https://crrev.com/7c36b9d6d6ca3e3ee06dd11c82955a18f4f1409d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp
[modify] https://crrev.com/7c36b9d6d6ca3e3ee06dd11c82955a18f4f1409d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.cpp

Project Member

Comment 29 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8aca0c8cc76b2f1c29a71433668c2dd502deb90

commit a8aca0c8cc76b2f1c29a71433668c2dd502deb90
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Aug 22 02:08:44 2017

Update video-[un]mute-repaint.html to actually test paint invalidation

After https://codereview.chromium.org/2477203002, media volume changes
are not handled immediately but in the next document cycle. The CL
updated the expectations of video-[un]mute-repaint.html to include no
paint invalidations.

Modify the tests to actually test paint invalidations and update
expectations.

BUG= 662761 

Change-Id: Idce781efdf7b20432f6bdc6afca2465fc5fc8d65
Reviewed-on: https://chromium-review.googlesource.com/624896
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496174}
[delete] https://crrev.com/565455711291591cf96dad685cba4f946eaa018b/third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/a8aca0c8cc76b2f1c29a71433668c2dd502deb90/third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint.html
[delete] https://crrev.com/565455711291591cf96dad685cba4f946eaa018b/third_party/WebKit/LayoutTests/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/a8aca0c8cc76b2f1c29a71433668c2dd502deb90/third_party/WebKit/LayoutTests/paint/invalidation/video-unmute-repaint.html
[add] https://crrev.com/a8aca0c8cc76b2f1c29a71433668c2dd502deb90/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-mute-repaint-expected.txt
[add] https://crrev.com/a8aca0c8cc76b2f1c29a71433668c2dd502deb90/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-unmute-repaint-expected.txt
[add] https://crrev.com/a8aca0c8cc76b2f1c29a71433668c2dd502deb90/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-mute-repaint-expected.txt
[add] https://crrev.com/a8aca0c8cc76b2f1c29a71433668c2dd502deb90/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-unmute-repaint-expected.txt

Comment 30 by mlamouri@chromium.org, Aug 27 2017

Closing this as it's done. We could reduce the MediaControls.h interface but it's now fully modular.

Comment 31 by mlamouri@chromium.org, Aug 27 2017

Status: Fixed (was: Started)

►

Issue 662761 link

Issue metadata

Modularise MediaControls (and abstract from HTMLMediaElement)

Issue description

Comment 1 by mlamouri@chromium.org, Nov 6 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Nov 15 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Nov 30 2016

Comment 3 Deleted

Comment 4 by mlamouri@chromium.org, Nov 30 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Dec 5 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Dec 13 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Dec 19 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Dec 19 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Dec 20 2016

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Dec 20 2016

Comment 10 Deleted

Comment 11 by mlamouri@chromium.org, Feb 17 2017

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Apr 6 2017

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Apr 10 2017

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Apr 10 2017

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Apr 11 2017

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Apr 12 2017

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Apr 14 2017

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Apr 14 2017

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Apr 14 2017

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Apr 20 2017

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Apr 25 2017

Comment 21 Deleted

Comment 22 by mlamouri@chromium.org, Apr 28 2017

Comment 22 Deleted

Comment 23 by mlamouri@chromium.org, Jun 8 2017

Comment 23 Deleted

Comment 24 by mlamouri@chromium.org, Jul 6 2017

Comment 24 Deleted

Comment 25 by bugdroid1@chromium.org, Jul 6 2017

Comment 25 Deleted

Comment 26 by bugdroid1@chromium.org, Jul 6 2017

Comment 26 Deleted

Comment 27 by bugdroid1@chromium.org, Jul 8 2017

Comment 27 Deleted

Comment 28 by bugdroid1@chromium.org, Jul 17 2017

Comment 28 Deleted

Comment 29 by bugdroid1@chromium.org, Aug 22 2017

Comment 29 Deleted

Comment 30 by mlamouri@chromium.org, Aug 27 2017

Comment 30 Deleted

Comment 31 by mlamouri@chromium.org, Aug 27 2017

Comment 31 Deleted

Sign in to add a comment