When setting up a new printer, we need to lookup and pull the corresponding PPD file from the PPD server.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e845d5589dcc88bcfb1945c190bb47ca7d568c5a commit e845d5589dcc88bcfb1945c190bb47ca7d568c5a Author: justincarlson <justincarlson@chromium.org> Date: Fri Nov 11 21:00:23 2016 Add in-memory caching to PpdCache available printers. This should help make the printer make/model selection ui a little more responsive. BUG= 662755 Review-Url: https://codereview.chromium.org/2487343006 Cr-Commit-Position: refs/heads/master@{#431641} [modify] https://crrev.com/e845d5589dcc88bcfb1945c190bb47ca7d568c5a/chromeos/printing/ppd_cache.cc [modify] https://crrev.com/e845d5589dcc88bcfb1945c190bb47ca7d568c5a/chromeos/printing/ppd_cache.h [modify] https://crrev.com/e845d5589dcc88bcfb1945c190bb47ca7d568c5a/chromeos/printing/ppd_cache_unittest.cc [modify] https://crrev.com/e845d5589dcc88bcfb1945c190bb47ca7d568c5a/chromeos/printing/ppd_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf123fc79469b4b77050b828bf3c94bf88af7183 commit cf123fc79469b4b77050b828bf3c94bf88af7183 Author: justincarlson <justincarlson@chromium.org> Date: Tue Nov 15 03:46:35 2016 Create ppd_cache directory if it doesn't exist. Also, rename it to CamelCase to match the observed conventions of other things in /home/chronos. The name change is safe because no one uses this directory yet. No one uses it yet because all the functionality that *would* use it is failing because...the directory is never created. BUG= 662755 Review-Url: https://codereview.chromium.org/2500163002 Cr-Commit-Position: refs/heads/master@{#432080} [modify] https://crrev.com/cf123fc79469b4b77050b828bf3c94bf88af7183/chrome/common/chrome_paths.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f55b637f4b2f0dc5887b1e35b6ca7f7788c1701 commit 4f55b637f4b2f0dc5887b1e35b6ca7f7788c1701 Author: justincarlson <justincarlson@chromium.org> Date: Wed Nov 16 00:52:29 2016 Change PPDCache to use a path inside the per-user profile. BUG= 662755 Review-Url: https://codereview.chromium.org/2504763002 Cr-Commit-Position: refs/heads/master@{#432328} [modify] https://crrev.com/4f55b637f4b2f0dc5887b1e35b6ca7f7788c1701/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc [modify] https://crrev.com/4f55b637f4b2f0dc5887b1e35b6ca7f7788c1701/chrome/common/chrome_paths.cc [modify] https://crrev.com/4f55b637f4b2f0dc5887b1e35b6ca7f7788c1701/chrome/common/chrome_paths.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f95cbf5190c34a748ef3bd93a4c751f9581fd91d commit f95cbf5190c34a748ef3bd93a4c751f9581fd91d Author: Justin Carlson <justincarlson@chromium.org> Date: Mon Nov 14 22:55:52 2016 debugd: Fill in ppd cache directory as a source for ppd copies. Also, fix a potential memory corruption bug using std::equals, adjust some internal function signatures to make path components instead of full paths the common representation. TEST=manual invocation BUG= chromium:662755 Change-Id: Id37979c708724feaef4fc59568feee9700969480 Reviewed-on: https://chromium-review.googlesource.com/411448 Commit-Ready: Justin Carlson <justincarlson@chromium.org> Tested-by: Justin Carlson <justincarlson@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/f95cbf5190c34a748ef3bd93a4c751f9581fd91d/debugd/src/cups_tool.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d96dd555f99419bee86970516993aa9631421d58 commit d96dd555f99419bee86970516993aa9631421d58 Author: skau <skau@chromium.org> Date: Sat Dec 10 01:58:26 2016 Interrogate PpdProvider from PrintPreview. Make use of the PpdCache from PrintPreview. Setup downloading ppds from the quirks server. BUG= 662755 TEST=Setup a printer. Log out. Rename ppd file. Open printer from print preview. Review-Url: https://codereview.chromium.org/2542363002 Cr-Commit-Position: refs/heads/master@{#437718} [modify] https://crrev.com/d96dd555f99419bee86970516993aa9631421d58/chrome/browser/chromeos/BUILD.gn [add] https://crrev.com/d96dd555f99419bee86970516993aa9631421d58/chrome/browser/chromeos/printing/ppd_provider_factory.cc [add] https://crrev.com/d96dd555f99419bee86970516993aa9631421d58/chrome/browser/chromeos/printing/ppd_provider_factory.h [modify] https://crrev.com/d96dd555f99419bee86970516993aa9631421d58/chrome/browser/ui/webui/print_preview/print_preview_handler.cc [modify] https://crrev.com/d96dd555f99419bee86970516993aa9631421d58/chrome/browser/ui/webui/print_preview/print_preview_handler.h [modify] https://crrev.com/d96dd555f99419bee86970516993aa9631421d58/chrome/browser/ui/webui/print_preview/printer_backend_proxy.cc [modify] https://crrev.com/d96dd555f99419bee86970516993aa9631421d58/chrome/browser/ui/webui/print_preview/printer_backend_proxy.h [modify] https://crrev.com/d96dd555f99419bee86970516993aa9631421d58/chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc [modify] https://crrev.com/d96dd555f99419bee86970516993aa9631421d58/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
Print preview now requests ppds from the PPDProvider. Closing.
Comment 1 by bugdroid1@chromium.org
, Nov 11 2016