Do not silently fail when installing WebAPKs when "installation from Unknown sources" is disabled |
||
Issue descriptionRepro steps: 1) Disable "Installation from Unknown Sources" in Android Settings > Security 2) Navigate to https://tests.peter.sh/notification-generator/ 3) Select "Add to Homescreen" from the App Menu Expected: Dialog in attached Screenshot Actual: Installation fails silently
,
Nov 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01ae00b9a5dbef08b338551f9e5d050059ecec1c commit 01ae00b9a5dbef08b338551f9e5d050059ecec1c Author: pkotwicz <pkotwicz@chromium.org> Date: Mon Nov 07 20:36:26 2016 Show warning dialog when user installs WebAPK when "installation from Unknown sources" is disabled Currently, we detect if "installation from Unknown sources" is disabled and cause installation to silently fail. This behavior is confusing. This CL changes the behavior to show a warning dialog telling the user that the installation was blocked with a button to go to "Android Security Settings". This behavior is provided by default by the Android OS when an intent is sent to install an APK when "installation from Unknown sources" is disabled. BUG= 662739 Review-Url: https://codereview.chromium.org/2485503002 Cr-Commit-Position: refs/heads/master@{#430361} [modify] https://crrev.com/01ae00b9a5dbef08b338551f9e5d050059ecec1c/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
,
Nov 10 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by pkotw...@chromium.org
, Nov 6 2016