Issue metadata
Sign in to add a comment
|
Regression: Fullscreen toolbar doesn't reappear after ending html5 fullscreen
Reported by
jleedev@gmail.com,
Nov 6 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version : 56.0.2911.0 OS Version: OS X 10.12.1 What steps will reproduce the problem? 1. Enter full screen 2. Open youtube for example, and click full screen inside the player 3. Leave the html5 full screen (by pressing escape, switching tabs, or with the button inside the player) What is the expected result? The toolbar should reappear, as we are back in normal full screen mode. What happens instead of that? The toolbar doesn't reappear. You have to press cmd-shift-F twice to fix it, or exit and leave full screen. (Or, if "Always show toolbar in full screen" is off, the toolbar doesn't reappear when moving the mouse to the top of the screen or focusing the omnibox, until performing the workaround steps.) Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2911.0 Safari/537.36
,
Nov 7 2016
,
Nov 8 2016
Removing Needs-Bisect Label for now as the Dev is looking into it. Please feel free to add labels if any help required . Thanks !
,
Nov 9 2016
,
Nov 11 2016
,
Nov 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47279775a3f42b190afcb962c917a24beb12612b commit 47279775a3f42b190afcb962c917a24beb12612b Author: spqchan <spqchan@chromium.org> Date: Fri Nov 11 23:10:24 2016 [Mac] Fix for fullscreen toolbar layout issues - Fullscreen toolbar style is now updating properly when you exit tab fullscreen - Info bars should appear under the floatingBarBackingView - Fullscreen toolbar should be placed above the window's height if the style is TOOLBAR_NONE. Otherwise, we'll end up with a glimpse of it. BUG= 662734 , 608271 Review-Url: https://codereview.chromium.org/2491343003 Cr-Commit-Position: refs/heads/master@{#431676} [modify] https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm [modify] https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b/chrome/browser/ui/cocoa/browser_window_controller.h [modify] https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b/chrome/browser/ui/cocoa/browser_window_layout.mm [modify] https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h [modify] https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm
,
Nov 15 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Nov 7 2016Components: UI>Browser>FullScreen
Labels: -Type-Bug -Pri-3 Needs-Bisect Pri-1 Type-Bug-Regression
Status: Untriaged (was: Unconfirmed)