New issue
Advanced search Search tips

Issue 662710 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Data race in blink::UserGestureIndicator::UserGestureIndicator

Project Member Reported by ClusterFuzz, Nov 6 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5785701691162624

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race READ 8
Crash Address: 0x7fd929bd43a0
Crash State:
  blink::UserGestureIndicator::UserGestureIndicator
  blink::DOMTimer::fired
  blink::TimerBase::runInternal
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_tsan_chrome_mp&range=429267:429319

Minimized Testcase (0.55 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97GjiI4z9eAHBino-3gsPtDgOlm-x-cBiiuOxjWX4e7UXpCpUbFbcjjjscYMMy9Ekxn0wDGMn-j26A9w1FxIAQcEiBjc3mNn9PnZgKZkKZf9H7lpSvGltJT97kI2H44PPX-ztHMUu8nLFLNxxPzwPH1LyWHGg?testcase_id=5785701691162624

Additional requirements: Requires Gestures

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: nyerramilli@chromium.org
Labels: -Type-Bug M-56 Test-Predator-Correct-CLs Type-Bug-Regression
Owner: rdevlin....@chromium.org
Status: Assigned (was: Untriaged)
Findit results:
Suspected CLs	The result is a list of CLs that change the crashed files.

Author: rdevlin.cronin
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/b1ae4b4c9d29625f4ab07eadbeac10a42262bbf2
Time: Wed Nov 02 14:56:30 2016
Lines 122 of file UserGestureIndicator.cpp which potentially caused crash are changed in this cl (frame #0, "blink::UserGestureIndicator::UserGestureIndicator").
Minimum distance from crash line to modified line: 0. (file: UserGestureIndicator.cpp, crashed on: 122, modified: 122).

Suspected Project: chromium

based on findit results, assigning to rdevlin.cronin, Could you please check the issue and help.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28da3bf9d966cb3048f4dff0284f2173ecb5c5e7

commit 28da3bf9d966cb3048f4dff0284f2173ecb5c5e7
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Tue Nov 08 00:51:32 2016

[Blink] Check thread access in UserGestureIndicator

We silently ignore UserGestureIndicators on non-main threads, but tried
checking equality against s_rootToken before checking the thread. Check
the thread before token equality.

BUG= 662710 

Review-Url: https://codereview.chromium.org/2483983002
Cr-Commit-Position: refs/heads/master@{#430450}

[modify] https://crrev.com/28da3bf9d966cb3048f4dff0284f2173ecb5c5e7/third_party/WebKit/Source/platform/UserGestureIndicator.cpp

I think this should be fixed by #2, but am hoping that clusterfuzz will automatically update with a fix detection.
Project Member

Comment 4 by ClusterFuzz, Nov 8 2016

ClusterFuzz has detected this issue as fixed in range 430398:430495.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5785701691162624

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race READ 8
Crash Address: 0x7fd929bd43a0
Crash State:
  blink::UserGestureIndicator::UserGestureIndicator
  blink::DOMTimer::fired
  blink::TimerBase::runInternal
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_tsan_chrome_mp&range=429267:429319
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_tsan_chrome_mp&range=430398:430495

Minimized Testcase (0.55 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97GjiI4z9eAHBino-3gsPtDgOlm-x-cBiiuOxjWX4e7UXpCpUbFbcjjjscYMMy9Ekxn0wDGMn-j26A9w1FxIAQcEiBjc3mNn9PnZgKZkKZf9H7lpSvGltJT97kI2H44PPX-ztHMUu8nLFLNxxPzwPH1LyWHGg?testcase_id=5785701691162624

Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Nov 8 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Yay!  Good job, clusterfuzz.
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment