New issue
Advanced search Search tips

Issue 662688 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.android_webview.test.AwContentsTest#testCreateLoadDestroyManyTimes with {--webview-sandboxed-renderer}" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Nov 5 2016

Issue description

"org.chromium.android_webview.test.AwContentsTest#testCreateLoadDestroyManyTimes with {--webview-sandboxed-renderer}" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyfgsSBUZsYWtlInNvcmcuY2hyb21pdW0uYW5kcm9pZF93ZWJ2aWV3LnRlc3QuQXdDb250ZW50c1Rlc3QjdGVzdENyZWF0ZUxvYWREZXN0cm95TWFueVRpbWVzIHdpdGggey0td2Vidmlldy1zYW5kYm94ZWQtcmVuZGVyZXJ9DA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, Nov 6 2016

Detected 5 new flakes for test/step "org.chromium.android_webview.test.AwContentsTest#testCreateLoadDestroyManyTimes with {--webview-sandboxed-renderer}". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyfgsSBUZsYWtlInNvcmcuY2hyb21pdW0uYW5kcm9pZF93ZWJ2aWV3LnRlc3QuQXdDb250ZW50c1Rlc3QjdGVzdENyZWF0ZUxvYWREZXN0cm95TWFueVRpbWVzIHdpdGggey0td2Vidmlldy1zYW5kYm94ZWQtcmVuZGVyZXJ9DA. This message was posted automatically by the chromium-try-flakes app.
Cc: boliu@chromium.org
Owner: tzik@chromium.org
Status: Assigned (was: Untriaged)
This is flaky in the main waterfall

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29?numbuilds=200

e.g. https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/37010 and the 3 cycles before that

Earlies flake I found was https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36979 - There's one CL (r430159), but of course flake culprit could be earlier. But I scanned back to builds/36970 and nothing stood out.


Changed by	tzik@chromium.org
Call MessageFilter clean up handlers even for pending filters

MessageFilters, specifically ResourceMessageFilter, need a chance to
clean up its state on IO thread, even if the IPC channel is closed before
the connection is fully established. Though in the existing code,
ChannelProxy doesn't call clean up functions for its |pending_filters_|.
After this CL, MessageFilter::OnChannelClosing and OnFilterRemoved will
be called for all MessageFilters passed to ChannelProxy::AddFilter.

Review-Url: https://codereview.chromium.org/2469123003
Cr-Commit-Position: refs/heads/master@{#430159}
Changed files

content/browser/memory/memory_pressure_controller_impl.cc
ipc/ipc_channel_proxy.cc


The output is pretty useless. Errors like:
org.chromium.android_webview.test.AwContentsTest#testCreateLoadDestroyManyTimes with {--webview-sandboxed-renderer} (run #1):

I  273.302s run_tests_on_device(06b829dd13c869d3)  detected failure in org.chromium.android_webview.test.AwContentsTest#testCreateLoadDestroyManyTimes with {--webview-sandboxed-renderer}. raw output:
I  273.302s run_tests_on_device(06b829dd13c869d3)    INSTRUMENTATION_STATUS: numtests=1
I  273.302s run_tests_on_device(06b829dd13c869d3)    INSTRUMENTATION_STATUS: stream=
I  273.302s run_tests_on_device(06b829dd13c869d3)    org.chromium.android_webview.test.AwContentsTest:
I  273.302s run_tests_on_device(06b829dd13c869d3)    INSTRUMENTATION_STATUS: id=InstrumentationTestRunner
I  273.302s run_tests_on_device(06b829dd13c869d3)    INSTRUMENTATION_STATUS: test=testCreateLoadDestroyManyTimes
I  273.302s run_tests_on_device(06b829dd13c869d3)    INSTRUMENTATION_STATUS: class=org.chromium.android_webview.test.AwContentsTest
I  273.302s run_tests_on_device(06b829dd13c869d3)    INSTRUMENTATION_STATUS: current=1
I  273.302s run_tests_on_device(06b829dd13c869d3)    INSTRUMENTATION_STATUS_CODE: 1
I  273.302s run_tests_on_device(06b829dd13c869d3)    INSTRUMENTATION_RESULT: shortMsg=Native crash
I  273.302s run_tests_on_device(06b829dd13c869d3)    INSTRUMENTATION_RESULT: longMsg=Native crash: Aborted
I  273.302s run_tests_on_device(06b829dd13c869d3)    INSTRUMENTATION_CODE: 0


C  387.793s Main  [==========] 959 tests ran.
C  387.794s Main  [  PASSED  ] 958 tests.
C  387.794s Main  [  FAILED  ] 1 test, listed below:
C  387.794s Main  [  FAILED  ] org.chromium.android_webview.test.AwContentsTest#testCreateLoadDestroyManyTimes with {--webview-sandboxed-renderer} (CRASHED)
C  387.794s Main  
C  387.794s Main  1 FAILED TEST


Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b2ebaec3cb21c2b8cf78e2aa3c864545e9c4c6a

commit 1b2ebaec3cb21c2b8cf78e2aa3c864545e9c4c6a
Author: tapted <tapted@chromium.org>
Date: Mon Nov 07 00:11:28 2016

Disable flaky AwContentsTest#testCreateLoadDestroyManyTimes

Crashes flakily. Couldn't find a culprit.

BUG=662688
TBR=tzik@chromium.org,boliu@chromium.org

Review-Url: https://codereview.chromium.org/2484543002
Cr-Commit-Position: refs/heads/master@{#430201}

[modify] https://crrev.com/1b2ebaec3cb21c2b8cf78e2aa3c864545e9c4c6a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java

Labels: -Sheriff-Chromium

Comment 6 by boliu@chromium.org, Nov 7 2016

Components: Mobile>WebView
F chromium: [FATAL:gpu_channel.cc(464)] Check failed: channel_.

That's..odd

Comment 7 by boliu@chromium.org, Nov 7 2016

Full stack:
Stack Trace:
  RELADDR   FUNCTION                   FILE:LINE
  00041f50  tgkill+12                  /system/lib/libc.so
  0003fb5d  pthread_kill+32            /system/lib/libc.so
  0001c30f  raise+10                   /system/lib/libc.so
  000194c1  __libc_android_abort+34    /system/lib/libc.so
  000174ac  abort+4                    /system/lib/libc.so
  v------>  DebugBreak                 /android/chromium/src/base/debug/debugger_posix.cc:221
  00080d91  BreakDebugger              /android/chromium/src/base/debug/debugger_posix.cc:251
  000971cb  ~LogMessage                /android/chromium/src/base/logging.cc:748
  001193c3  OnFilterRemoved            /android/chromium/src/gpu/ipc/service/gpu_channel.cc:464
  0001e9f9  OnChannelClosed            /android/chromium/src/ipc/ipc_channel_proxy.cc:216
  v------>  Run                        /android/chromium/src/base/callback.h:47
  0008158f  RunTask                    /android/chromium/src/base/debug/task_annotator.cc:52
  0009eaef  RunTask                    /android/chromium/src/base/message_loop/message_loop.cc:413
  0009ed51  DeferOrRunPendingTask      /android/chromium/src/base/message_loop/message_loop.cc:422
  0009efc5  DoWork                     /android/chromium/src/base/message_loop/message_loop.cc:515
  000a147d  Run                        /android/chromium/src/base/message_loop/message_pump_libevent.cc:218
  0009e87d  RunHandler                 /android/chromium/src/base/message_loop/message_loop.cc:378
  000ba78f  Run                        /android/chromium/src/base/run_loop.cc:35
  000dfeb3  Run                        /android/chromium/src/base/threading/thread.cc:245
  000e022b  ThreadMain                 /android/chromium/src/base/threading/thread.cc:333
  000da8e3  ThreadFunc                 /android/chromium/src/base/threading/platform_thread_posix.cc:71
Project Member

Comment 8 by chromium...@appspot.gserviceaccount.com, Nov 7 2016

Labels: Sheriff-Chromium
Detected 5 new flakes for test/step "org.chromium.android_webview.test.AwContentsTest#testCreateLoadDestroyManyTimes with {--webview-sandboxed-renderer}". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyfgsSBUZsYWtlInNvcmcuY2hyb21pdW0uYW5kcm9pZF93ZWJ2aWV3LnRlc3QuQXdDb250ZW50c1Rlc3QjdGVzdENyZWF0ZUxvYWREZXN0cm95TWFueVRpbWVzIHdpdGggey0td2Vidmlldy1zYW5kYm94ZWQtcmVuZGVyZXJ9DA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 9 Deleted

Disabled here by tapted https://codereview.chromium.org/2484543002
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8826eda8787c97736f2b671a2548dbcafd0b89aa

commit 8826eda8787c97736f2b671a2548dbcafd0b89aa
Author: tzik <tzik@chromium.org>
Date: Wed Nov 09 04:30:28 2016

Remove a DCHECK in GpuChannelMessageFilter

GpuChannelMessageFilter::OnFilterRemoved asserts |channel_| is non null.
This is no longer true after r430159 or 0e85f1d17a35bbe7, since in new code,
ChannelProxy calls MessageFilter::OnFilterRemoved even when the channel
is closed while the filter registration is pending.

This CL just removes the assertion, since null |channel_| should be harmless
here.

BUG= 662693 ,662688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2482053002
Cr-Commit-Position: refs/heads/master@{#430862}

[modify] https://crrev.com/8826eda8787c97736f2b671a2548dbcafd0b89aa/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
[modify] https://crrev.com/8826eda8787c97736f2b671a2548dbcafd0b89aa/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/8826eda8787c97736f2b671a2548dbcafd0b89aa/gpu/ipc/service/gpu_channel.cc

Sign in to add a comment