--show-composited-layer-borders broken on Mac
Reported by
lo...@yandex-team.ru,
Nov 5 2016
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 YaBrowser/16.10.0.2309 Safari/537.36 Steps to reproduce the problem: 1. Launch Chromium with --show-composited-layer-borders flag What is the expected behavior? Lines are drawn, GPU process exists. What went wrong? GPU process crashed. Did this work before? No Chrome version: 53.0.2785.116 Channel: stable OS Version: OS X 10.11.6 Flash Version: Shockwave Flash 24.0 r0 OpenGL on OSX doesn't support Line Width > 1.0f ( https://developer.apple.com/opengl/capabilities/ see LINE_WIDTH constants ) DoLineWidth has check for it ( see https://cs.chromium.org/chromium/src/gpu/command_buffer/service/gles2_cmd_decoder.cc?q=DoLineWidth&sq=package:chromium&dr=CSs&l=8465 ) But we save incorrect LineWidth state and then try to apply it without any check ( see https://cs.chromium.org/chromium/src/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h?q=DoLineWidth&sq=package:chromium&l=2390&dr=C ) That's why GPU process crashed.
,
Nov 8 2016
Not sure if this is the correct component tag. I've marked this as started, but made piman@ an owner because you're reviewing the CL and lof84@yandex.. isn't a project member. Please feel free to edit as necessary! (This is mostly just to get this bug out of the mac triage queue.)
,
Nov 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5e3696056f67a01e595bc7c62b9270052deb1f2 commit d5e3696056f67a01e595bc7c62b9270052deb1f2 Author: lof84 <lof84@yandex-team.ru> Date: Thu Nov 10 00:35:54 2016 fix --show-composited-layer-borders on Mac Fix GPU process crash due to incorrect glLineWidth value on Mac. BUG= 662682 R=piman CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2482673002 Cr-Commit-Position: refs/heads/master@{#431102} [modify] https://crrev.com/d5e3696056f67a01e595bc7c62b9270052deb1f2/gpu/command_buffer/build_gles2_cmd_buffer.py [modify] https://crrev.com/d5e3696056f67a01e595bc7c62b9270052deb1f2/gpu/command_buffer/service/context_state.cc [modify] https://crrev.com/d5e3696056f67a01e595bc7c62b9270052deb1f2/gpu/command_buffer/service/context_state.h [modify] https://crrev.com/d5e3696056f67a01e595bc7c62b9270052deb1f2/gpu/command_buffer/service/context_state_impl_autogen.h [modify] https://crrev.com/d5e3696056f67a01e595bc7c62b9270052deb1f2/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/d5e3696056f67a01e595bc7c62b9270052deb1f2/gpu/command_buffer/service/gles2_cmd_decoder_unittest_0_autogen.h [modify] https://crrev.com/d5e3696056f67a01e595bc7c62b9270052deb1f2/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc [modify] https://crrev.com/d5e3696056f67a01e595bc7c62b9270052deb1f2/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
,
Jan 27 2017
,
Jan 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by lo...@yandex-team.ru
, Nov 5 2016