New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 662670 link

Starred by 1 user
Status: Fixed
Owner:
█ gch...@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Flaky NotificationPromoTest tests on ios

Project Member Reported by roc...@chromium.org, Nov 5 2016 
Example failure: https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/101516

Very likely floating point rounding error. The tests should use EXPECT_DOUBLE_EQ to compare doubles, as this has builtin tolerance for rounding errors.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e0fffa9c011d3a3125528ffddf146403d524dab

commit 0e0fffa9c011d3a3125528ffddf146403d524dab
Author: gchatz <gchatz@chromium.org>
Date: Thu Nov 10 19:04:13 2016

Use EXPECT_DOUBLE_EQ for doubles in NotificationPromoTest.

Use EXPECT_DOUBLE_EQ when evaluating doubles in NotificationPromoTest
instead of EXPECT_EQ, as EXPECT_EQ was causing double rounding
flakes.

BUG= 662670 

Review-Url: https://codereview.chromium.org/2487033002
Cr-Commit-Position: refs/heads/master@{#431308}

[modify] https://crrev.com/0e0fffa9c011d3a3125528ffddf146403d524dab/ios/chrome/browser/notification_promo_unittest.cc

Comment 2 by gch...@chromium.org, Nov 10 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment