This will only be visible on 56.0.2910.0 and later. On earlier versions of Chrome, the omnibox warning does not get removed dynamically.

spqchan, do you have any ideas on this?

maxwalker: what do you think of the sudden disappearance of the warning? (see screencast) Eric pointed out that he thought it was intentional so as to not draw more attention.

Yes, that's intentional. I had an implementation where it would animate out, but it was drawing attention so that got removed.

Let me see if I can find the email thread for that...

Oh, ok, great! One fewer bug to fix :)

We decided to not animate out when going from site A to site B to avoid too many transitions happening at the same time (1. animate out, 2. whole URL and page content replaced 3. another verbose states animates in).

In the HTTP-bad case, the URL changes only slightly (or not at all) and we transition back to the http icon-only state, so I think an animation would work well here to make things feel more smooth. Would it be possible to animate the label out if you stay on the same http site, like in the NYT example?

Ah, ok, that makes sense to me. Re-opening and tentatively assigning to spqchan. Let me know if you don't think this will be doable, Sarah.

This is doable, since I already have code for it :)

I want to make some clarifications first:
- Basically if the security verbose chip is showing and the page switches to HTTP-only, the chip will animate out. 
- Will the flag setting affect if it animates out or not?

Thanks!

1. yep, that makes sense
2. i dont think we need a separate flag for this

thanks!

Yes, correct. You could also define it in the following way:

If the page switches from state A verbose to state A icon-only, the chip will animate out. This currently only applies to the transition from a http-bad to a http page.

The animation properties for the show- and hide-animation are the same (specs: https://docs.google.com/document/d/1WpdSVOC4r97kghn2p66Cgn11X3UoJRQV2HbZRoJRgso/edit?pli=1#heading=h.iom7a87uxl9c).

Thanks, Sarah!

Awesome, so it's non-secure only that will animate out. Thanks!

Sorry, just one more clarification. If the "no animation" flag is set, it shouldn't animate out right?

Correct, when "no animation" there shouldn't be animations in OR out.

Thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d4901746d188f60327a85ae807bad0429810da5

commit 2d4901746d188f60327a85ae807bad0429810da5
Author: spqchan <spqchan@chromium.org>
Date: Wed Nov 16 01:37:45 2016

[Mac] Changes for the security chip

- Decoration should now animate out if it's no longer shown
- Fix the logic so that the chip will animate in when the tab has changed

BUG= 662666 

Review-Url: https://codereview.chromium.org/2501753002
Cr-Commit-Position: refs/heads/master@{#432346}

[modify] https://crrev.com/2d4901746d188f60327a85ae807bad0429810da5/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/2d4901746d188f60327a85ae807bad0429810da5/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Tested the issue on Mac OS X 10.11.6 using Chrome Dev# 56.0.2923.0 and is working as intended.
The animation is seen properly when login form is opened and closed. Hence adding TE-Verified Labels.
Attaching screen cast for reference.
Thank You.

Deleted: 662666.mov 3.3 MB

662666.mov 3.3 MB Download

spqchan, anything else to do on this or can we close it out? Thanks!

Yep, it can be closed out!

Verified per comment #15