New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662654 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue 649202



Sign in to add a comment

try changes to recipes without landing

Project Member Reported by no...@chromium.org, Nov 5 2016

Issue description

problem: a change in a core recipe module, such as infra_paths, may cause breakage across the board. Deploying these changes and rolling them back is slow (goes through recipe roller) so it worsens the problem.

Goal: make it possible to try changes to recipes without landing

Proposal:
- recipe engine: extend -O flag value format. If the value starts with @, it is followed by a treeish. If it is a hash, fetch master and checkout the hash. Otherwise treat as ref name and fetch that instead of master.
- kitchen: add -O flag
- swarmbucket: add support for -O in kitchen through a build parameter

use case: 
- upload a change to Gerrit (even if we typically use Rietveld for repo)
- schedule a buildbucket build that overrides a recipe package
- see if build succeeds

 
This sounds good. Is it a blocker for running chromium try builds on swarming or can it be part of another milestone?

Comment 2 by no...@chromium.org, Nov 7 2016

I think we want it but it is not required, hence p2. The motivation is to avoid global breakages when making changes in core recipe modules, like the Friday one caused by https://codereview.chromium.org/2477033002/

This will make fixing  issue 662586  safer. 
Components: -Infra>Platform Infra>Platform>Recipes
I think we should use a different milestone but agree this is good to solve so we're not slowed down.
Robbie, how much of this will become easier with your bundling and recipe testing support for chromium?
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/aa6520e3f6a62cb313861f953ae271205ef000cb

commit aa6520e3f6a62cb313861f953ae271205ef000cb
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Feb 21 20:19:43 2017

[recipes.py] upgrade recipes.py to allow recipe_engine override

BUG= 662654 
TBR=nodir@chromium.org

Change-Id: Ifbce962d4968af9871ee62862b485dc1cc06cc22
Reviewed-on: https://chromium-review.googlesource.com/445044
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/aa6520e3f6a62cb313861f953ae271205ef000cb/recipes.py

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/7dbefd7983e3350256e623d1c456e4029793cc3f

commit 7dbefd7983e3350256e623d1c456e4029793cc3f
Author: Robert Iannucci <iannucci@google.com>
Date: Tue Feb 21 20:22:21 2017

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/7dbefd7983e3350256e623d1c456e4029793cc3f

commit 7dbefd7983e3350256e623d1c456e4029793cc3f
Author: Robert Iannucci <iannucci@google.com>
Date: Tue Feb 21 20:22:21 2017

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/11f554ec0252fa90d399daffa07befde406ea5d1

commit 11f554ec0252fa90d399daffa07befde406ea5d1
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Feb 21 20:23:12 2017

[recipes.py] upgrade recipes.py to allow recipe_engine override

BUG= 662654 
TBR=nodir@chromium.org

Change-Id: I7d163f484011da2eff905f92afed898ce9e8d99c
Reviewed-on: https://chromium-review.googlesource.com/444832
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/11f554ec0252fa90d399daffa07befde406ea5d1/scripts/slave/recipes.py

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/89822d768000597fbf40e3169c2c6947af424107

commit 89822d768000597fbf40e3169c2c6947af424107
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Feb 21 20:26:41 2017

[recipes.py] upgrade recipes.py to allow recipe_engine override

BUG= 662654 
TBR=nodir@chromium.org

Change-Id: I63661e59bc724dfdbc5978048a971e155aa0f821
Reviewed-on: https://chromium-review.googlesource.com/444988
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/89822d768000597fbf40e3169c2c6947af424107/recipes/recipes.py

Comment 10 by no...@chromium.org, Feb 22 2017

Cc: phajdan.jr@chromium.org estaab@chromium.org vadimsh@chromium.org borenet@chromium.org d...@chromium.org
 Issue 632384  has been merged into this issue.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/777b2783b01a04a6ff47dba89bed1e6a0044745c

commit 777b2783b01a04a6ff47dba89bed1e6a0044745c
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Mar 02 02:03:46 2017

[kitchen] add support for recipe bundles.

Now if you `cook` without -repository and -revision, it will look for
bundled recipes in -checkout-dir and run them.

BUG= 662654 

Change-Id: I412f14adf28096b92ad2ef6c55c7dec6c356ced9
Reviewed-on: https://chromium-review.googlesource.com/448110
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/777b2783b01a04a6ff47dba89bed1e6a0044745c/go/src/infra/tools/kitchen/cook.go
[modify] https://crrev.com/777b2783b01a04a6ff47dba89bed1e6a0044745c/go/src/infra/tools/kitchen/recipe.go

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/57ad97640d5bd1e59e82253c353ec7153f6d9b45

commit 57ad97640d5bd1e59e82253c353ec7153f6d9b45
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Mar 02 03:26:37 2017

[kitchen] fix regular cook case

BUG= 662654 

Change-Id: I49b657671e9f4a13d176a836035efa3f6b632241
Reviewed-on: https://chromium-review.googlesource.com/448678
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/57ad97640d5bd1e59e82253c353ec7153f6d9b45/go/src/infra/tools/kitchen/cook.go

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b48cb021e1649ce61a605d6424d2cc78bb84f851

commit b48cb021e1649ce61a605d6424d2cc78bb84f851
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Apr 11 03:22:18 2017

[try-recipe] Restructure commandline stuff to be more standardish.

Bug:  662654 
Change-Id: Ifef7b3fede734cd4aa2912ccbab998155f987f76
Reviewed-on: https://chromium-review.googlesource.com/471267
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/b48cb021e1649ce61a605d6424d2cc78bb84f851/go/src/infra/tools/try-recipe/main.go
[modify] https://crrev.com/b48cb021e1649ce61a605d6424d2cc78bb84f851/go/src/infra/tools/try-recipe/isolate.go

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/eabc417eae191ec58ce7820085b4902217dae071

commit eabc417eae191ec58ce7820085b4902217dae071
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Apr 11 03:33:48 2017

[try-recipe] add isolate subcommand parsing

Bug:  662654 
Change-Id: Ic63bd2f2bd9764c7eec2f2f9e6d5099954e83f56
Reviewed-on: https://chromium-review.googlesource.com/469092
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/eabc417eae191ec58ce7820085b4902217dae071/go/src/infra/tools/try-recipe/main.go
[modify] https://crrev.com/eabc417eae191ec58ce7820085b4902217dae071/go/src/infra/tools/try-recipe/isolate.go

Project Member

Comment 17 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/399eb08afbbeae9d568fe3c1c42e92e24cbe075f

commit 399eb08afbbeae9d568fe3c1c42e92e24cbe075f
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Apr 11 03:57:38 2017

[try-recipe] implement logic to find recipes.py file in a repo

Bug:  662654 
Change-Id: I9c7b9b7ccd31bade2dfbfa583d102c513df5cd4d
Reviewed-on: https://chromium-review.googlesource.com/474211
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/399eb08afbbeae9d568fe3c1c42e92e24cbe075f/go/src/infra/tools/try-recipe/isolate.go

Project Member

Comment 21 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0b56264951ff4ea4fc117a60c1daa25394e2f329

commit 0b56264951ff4ea4fc117a60c1daa25394e2f329
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Apr 12 22:28:01 2017

[try-recipe] implement project overrides

Bug:  662654 
Change-Id: I0525d850f64d65d4c9b810298d4960febbd4fda9
Reviewed-on: https://chromium-review.googlesource.com/475008
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/0b56264951ff4ea4fc117a60c1daa25394e2f329/go/src/infra/tools/try-recipe/isolate.go
[modify] https://crrev.com/0b56264951ff4ea4fc117a60c1daa25394e2f329/go/src/infra/tools/try-recipe/cmd_isolate.go

Project Member

Comment 24 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8613afcfd617d0bdd3cc1fc8344ddf9e3afbb5be

commit 8613afcfd617d0bdd3cc1fc8344ddf9e3afbb5be
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Apr 25 04:29:54 2017

[try-recipe] grab builder definition from swarmbucket.

This grabs a builder definition from swarmbucket, parses the kitchen
command-line parameter to extract the recipe properties, and emits the
whole thing in a 'JobDefinition' intermediate format.

Subsequent commands in try-recipe will be able to manipulate and consume
this JobDefinition format.

Bug:  662654 

R=dnj@chromium.org, nodir@chromium.org

Change-Id: Id8d20381c712f7ea259b1bfb6039400dbf08aa78
Reviewed-on: https://chromium-review.googlesource.com/485224
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[add] https://crrev.com/8613afcfd617d0bdd3cc1fc8344ddf9e3afbb5be/go/src/infra/tools/try-recipe/job.go
[add] https://crrev.com/8613afcfd617d0bdd3cc1fc8344ddf9e3afbb5be/go/src/infra/tools/try-recipe/bot_definition.go
[modify] https://crrev.com/8613afcfd617d0bdd3cc1fc8344ddf9e3afbb5be/go/src/infra/tools/try-recipe/cmd_bot_definition.go

Project Member

Comment 26 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/137802d8e8e395c7af5eb84eef5940d3c1b8794e

commit 137802d8e8e395c7af5eb84eef5940d3c1b8794e
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Apr 25 23:10:33 2017

buildbucket: encode *_secs swarming fields as strings

Swarming RPC messages accept integers as strings, so we should send them as
strings too.

R=iannucci@chromium.org
Bug= 662654 

Change-Id: I7ffcebe4fb6f663901a09072376154d64601506c
Reviewed-on: https://chromium-review.googlesource.com/487088
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/137802d8e8e395c7af5eb84eef5940d3c1b8794e/appengine/cr-buildbucket/swarming/swarming.py
[modify] https://crrev.com/137802d8e8e395c7af5eb84eef5940d3c1b8794e/appengine/cr-buildbucket/swarming/test/swarming_test.py

Blocking: 649202
Owner: iannucci@chromium.org
Status: Started (was: Untriaged)
Cc: dpranke@chromium.org aga...@chromium.org
 Issue 403437  has been merged into this issue.
Project Member

Comment 34 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/450a1d81eef6361d9fa7f70a6565d1c4c7e55b1b

commit 450a1d81eef6361d9fa7f70a6565d1c4c7e55b1b
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri May 19 07:43:26 2017

[kitchen] refactor cook flag parsing and validation into new package.

This will allow the `try-recipe` command to use precisely the same
parser that kitchen uses for flags to avoid re-implementing a weird
pseudoparser.

R=dnj@chromium.org, martiniss@chromium.org, nodir@chromium.org

Bug:  662654 
Change-Id: I4a3bff68e67c898e36648e9b0728fcdd01eebb1d
Reviewed-on: https://chromium-review.googlesource.com/508161
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[add] https://crrev.com/450a1d81eef6361d9fa7f70a6565d1c4c7e55b1b/go/src/infra/tools/kitchen/cookflags/flags.go
[add] https://crrev.com/450a1d81eef6361d9fa7f70a6565d1c4c7e55b1b/go/src/infra/tools/kitchen/cookflags/logdog_flags.go
[add] https://crrev.com/450a1d81eef6361d9fa7f70a6565d1c4c7e55b1b/go/src/infra/tools/kitchen/cookflags/flags_test.go
[add] https://crrev.com/450a1d81eef6361d9fa7f70a6565d1c4c7e55b1b/go/src/infra/tools/kitchen/cookflags/logdog_flags_test.go
[add] https://crrev.com/450a1d81eef6361d9fa7f70a6565d1c4c7e55b1b/go/src/infra/tools/kitchen/cookflags/cookmode_string.go
[modify] https://crrev.com/450a1d81eef6361d9fa7f70a6565d1c4c7e55b1b/go/src/infra/tools/kitchen/cook_logdog.go
[modify] https://crrev.com/450a1d81eef6361d9fa7f70a6565d1c4c7e55b1b/go/src/infra/tools/kitchen/cook.go
[add] https://crrev.com/450a1d81eef6361d9fa7f70a6565d1c4c7e55b1b/go/src/infra/tools/kitchen/cookflags/cookflags.infra_testing
[modify] https://crrev.com/450a1d81eef6361d9fa7f70a6565d1c4c7e55b1b/go/src/infra/tools/kitchen/cook_mode.go
[add] https://crrev.com/450a1d81eef6361d9fa7f70a6565d1c4c7e55b1b/go/src/infra/tools/kitchen/cookflags/validate.go
[add] https://crrev.com/450a1d81eef6361d9fa7f70a6565d1c4c7e55b1b/go/src/infra/tools/kitchen/cookflags/cookmode.go
[modify] https://crrev.com/450a1d81eef6361d9fa7f70a6565d1c4c7e55b1b/go/src/infra/tools/kitchen/cook_logdog_test.go

Project Member

Comment 37 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/59b2de0cd664d3040118fc0ce27e84c829dc6e87

commit 59b2de0cd664d3040118fc0ce27e84c829dc6e87
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed May 24 01:11:54 2017

[cookflags] make cook flags json friendly.

R=dnj@chromium.org, nodir@chromium.org

Bug:  662654 
Change-Id: Iba1ac8a8074df2363dbace419c76f0e00a0f71aa
Reviewed-on: https://chromium-review.googlesource.com/511943
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/59b2de0cd664d3040118fc0ce27e84c829dc6e87/go/src/infra/tools/kitchen/cookflags/flags.go
[modify] https://crrev.com/59b2de0cd664d3040118fc0ce27e84c829dc6e87/go/src/infra/tools/kitchen/cookflags/logdog_flags.go
[add] https://crrev.com/59b2de0cd664d3040118fc0ce27e84c829dc6e87/go/src/infra/tools/kitchen/cookflags/property_flag_test.go
[modify] https://crrev.com/59b2de0cd664d3040118fc0ce27e84c829dc6e87/go/src/infra/tools/kitchen/cookflags/flags_test.go
[modify] https://crrev.com/59b2de0cd664d3040118fc0ce27e84c829dc6e87/go/src/infra/tools/kitchen/cook.go
[add] https://crrev.com/59b2de0cd664d3040118fc0ce27e84c829dc6e87/go/src/infra/tools/kitchen/cookflags/property_flag.go
[modify] https://crrev.com/59b2de0cd664d3040118fc0ce27e84c829dc6e87/go/src/infra/tools/kitchen/cookflags/validate.go
[modify] https://crrev.com/59b2de0cd664d3040118fc0ce27e84c829dc6e87/go/src/infra/tools/kitchen/cookflags/cookmode.go

Project Member

Comment 41 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0eec89fc58421c877b5a85943f9b2b1390a581ee

commit 0eec89fc58421c877b5a85943f9b2b1390a581ee
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu May 25 01:13:14 2017

[try-recipe] pass api_explorer_link=false

R=nodir@chromium.org

Bug:  662654 
Change-Id: I72d15646a2b2f1de07287b9e2567df486bafe344
Reviewed-on: https://chromium-review.googlesource.com/507016
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/0eec89fc58421c877b5a85943f9b2b1390a581ee/go/src/infra/tools/try-recipe/get_builder.go

Project Member

Comment 44 by bugdroid1@chromium.org, May 25 2017

Project Member

Comment 45 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7d8ffab9885d608329c2a3aaf303acecbbaa4dd6

commit 7d8ffab9885d608329c2a3aaf303acecbbaa4dd6
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri May 26 02:44:25 2017

[led] try-recipe is henceforth known as `led`.

This tool is a bit more general than manipulating just recipes.

'LUCI editor' or 'led' (in the style of 'ed', 'sed', etc.) is a unixey
PIPE-oriented tool that lets you quickly try out changes to a bunch of
layers of the stack.

R=smut@google.com

Bug:  662654 
Change-Id: I36c24db9713275d0dca127b08a1115e5ba02a418
Reviewed-on: https://chromium-review.googlesource.com/516550
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: smut <smut@chromium.org>

[rename] https://crrev.com/7d8ffab9885d608329c2a3aaf303acecbbaa4dd6/go/src/infra/tools/led/clients.go
[rename] https://crrev.com/7d8ffab9885d608329c2a3aaf303acecbbaa4dd6/go/src/infra/tools/led/cmd_launch.go
[rename] https://crrev.com/7d8ffab9885d608329c2a3aaf303acecbbaa4dd6/go/src/infra/tools/led/cmd_edit_recipe_bundle.go
[rename] https://crrev.com/7d8ffab9885d608329c2a3aaf303acecbbaa4dd6/go/src/infra/tools/led/job.go
[rename] https://crrev.com/7d8ffab9885d608329c2a3aaf303acecbbaa4dd6/go/src/infra/tools/led/cmd_get_swarm.go
[rename] https://crrev.com/7d8ffab9885d608329c2a3aaf303acecbbaa4dd6/go/src/infra/tools/led/cmd_edit_system.go
[rename] https://crrev.com/7d8ffab9885d608329c2a3aaf303acecbbaa4dd6/go/src/infra/tools/led/util.go
[rename] https://crrev.com/7d8ffab9885d608329c2a3aaf303acecbbaa4dd6/go/src/infra/tools/led/main.go
[rename] https://crrev.com/7d8ffab9885d608329c2a3aaf303acecbbaa4dd6/go/src/infra/tools/led/led.infra_testing
[rename] https://crrev.com/7d8ffab9885d608329c2a3aaf303acecbbaa4dd6/go/src/infra/tools/led/cmd_get_builder.go
[rename] https://crrev.com/7d8ffab9885d608329c2a3aaf303acecbbaa4dd6/go/src/infra/tools/led/cmd_edit.go
[rename] https://crrev.com/7d8ffab9885d608329c2a3aaf303acecbbaa4dd6/go/src/infra/tools/led/get_builder.go
[rename] https://crrev.com/7d8ffab9885d608329c2a3aaf303acecbbaa4dd6/go/src/infra/tools/led/isolate.go

Project Member

Comment 46 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8961ccdf7ab0f479faf6a701d75053c23c1706d4

commit 8961ccdf7ab0f479faf6a701d75053c23c1706d4
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri May 26 04:12:36 2017

[led] Add package definition

R=dnj@chromium.org, nodir@chromium.org, smut@google.com

Bug:  662654 
Change-Id: I92de0f4d5c9a972f598a99431d6d950d5bdd2c72
Reviewed-on: https://chromium-review.googlesource.com/516490
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[add] https://crrev.com/8961ccdf7ab0f479faf6a701d75053c23c1706d4/build/packages/led.yaml

Project Member

Comment 47 by bugdroid1@chromium.org, May 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/5dd7cd6e8fe33118cc9dbbe40412ed3c0f2c7003

commit 5dd7cd6e8fe33118cc9dbbe40412ed3c0f2c7003
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat May 27 02:45:05 2017

[led] add LUCI editor to depot_tools.

R=nodir@chromium.org

Bug:  662654 
Change-Id: I18898cb426ccbb895a82410dc61910a8b8e48f14
Reviewed-on: https://chromium-review.googlesource.com/517664
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/5dd7cd6e8fe33118cc9dbbe40412ed3c0f2c7003/cipd_manifest.txt
[add] https://crrev.com/5dd7cd6e8fe33118cc9dbbe40412ed3c0f2c7003/led
[add] https://crrev.com/5dd7cd6e8fe33118cc9dbbe40412ed3c0f2c7003/led.bat

Project Member

Comment 48 by bugdroid1@chromium.org, May 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/712c596d2a593eb976d2bd202aee3e580990d3f5

commit 712c596d2a593eb976d2bd202aee3e580990d3f5
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat May 27 03:03:36 2017

[led] correctly allow milo.

TBR=dnj@chromium.org, nodir@chromium.org

Bug:  662654 
Change-Id: I94d621739411ea06f3c87df0f5272c83c6cc2224
Reviewed-on: https://chromium-review.googlesource.com/517315
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/712c596d2a593eb976d2bd202aee3e580990d3f5/go/src/infra/tools/led/job.go

Project Member

Comment 50 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/42bb05cc325bb27704206c49fbc4b2a53ff7ffe6

commit 42bb05cc325bb27704206c49fbc4b2a53ff7ffe6
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Jun 05 17:29:43 2017

[led] support symlinks.

R=dnj@chromium.org

Bug:  662654 
Change-Id: I1f716e91e4515d0084ae017b2aa67ca336232005
Reviewed-on: https://chromium-review.googlesource.com/522940
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/42bb05cc325bb27704206c49fbc4b2a53ff7ffe6/go/src/infra/tools/led/isolate.go

Project Member

Comment 51 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/42bb05cc325bb27704206c49fbc4b2a53ff7ffe6

commit 42bb05cc325bb27704206c49fbc4b2a53ff7ffe6
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Jun 05 17:29:43 2017

[led] support symlinks.

R=dnj@chromium.org

Bug:  662654 
Change-Id: I1f716e91e4515d0084ae017b2aa67ca336232005
Reviewed-on: https://chromium-review.googlesource.com/522940
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/42bb05cc325bb27704206c49fbc4b2a53ff7ffe6/go/src/infra/tools/led/isolate.go

Project Member

Comment 52 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/42bb05cc325bb27704206c49fbc4b2a53ff7ffe6

commit 42bb05cc325bb27704206c49fbc4b2a53ff7ffe6
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Jun 05 17:29:43 2017

[led] support symlinks.

R=dnj@chromium.org

Bug:  662654 
Change-Id: I1f716e91e4515d0084ae017b2aa67ca336232005
Reviewed-on: https://chromium-review.googlesource.com/522940
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/42bb05cc325bb27704206c49fbc4b2a53ff7ffe6/go/src/infra/tools/led/isolate.go

Project Member

Comment 54 by bugdroid1@chromium.org, Jun 5 2017

Project Member

Comment 58 by bugdroid1@chromium.org, Jun 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/aff74dbecfc70344a72c5fee7fc85eabcb7cb9a4

commit aff74dbecfc70344a72c5fee7fc85eabcb7cb9a4
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Jun 10 02:45:59 2017

[partial reland] Remove a bunch of old Skia stuff

This partially relands https://chromium-review.googlesource.com/c/526270/,
but without the recipe bits, which landed in
https://chromium-review.googlesource.com/c/527897/.

R=borenet@chromium.org, dimu@chromium.org, dnj@chromium.org

Bug:  662654 , 729336
Change-Id: If99c3639f1c126721bb30e6cb48b02a7c8afae7c
Reviewed-on: https://chromium-review.googlesource.com/530285
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Di Mu <dimu@chromium.org>

[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.compile/builders.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/OWNERS
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.compile/Makefile
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/builders.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.fyi/slaves.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/master_site_config.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.android/builders.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.android/master_site_config.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/master/skia/OWNERS
[modify] https://crrev.com/aff74dbecfc70344a72c5fee7fc85eabcb7cb9a4/tests/masters_test.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.fyi/builders.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/Makefile
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/common/skia/builder_name_schema.json
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/master/skia/skia_notifier.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/common/skia/OWNERS
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.fyi/master_site_config.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.fyi/OWNERS
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.compile/slaves.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/master/skia/status_json.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/public_html/default.css
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.android/slaves.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.compile/master.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.compile/OWNERS
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.fyi/master.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/public_html/favicon.ico
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.android/OWNERS
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/common/skia/__init__.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/templates/console.html
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/master.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/common/skia/builder_name_schema.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/master/skia/skia_master_utils.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.android/Makefile
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/common/skia/global_constants.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.compile/master_site_config.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.android/master.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/templates/tree_status.html
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/public_html/common-resources
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.fyi/Makefile
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/master/skia/__init__.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/slaves.cfg
[modify] https://crrev.com/aff74dbecfc70344a72c5fee7fc85eabcb7cb9a4/scripts/slave/logdog-params.pyl
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/templates/announce.html
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/templates/horizontal_one_box_per_build.html

Project Member

Comment 59 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/823e17daf9ff73a9783f48e91d37f704193fcca5

commit 823e17daf9ff73a9783f48e91d37f704193fcca5
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Jun 13 18:14:44 2017

[led] add edit-cr-cl subcommand.

This subcommand understands old and new-style gerrit URLs, as well as
rietveld URLs, and will manipulate the recipe properties appropriately.

This means you can do, e.g.:

  led get-builder 'luci.infra.try:Some Try Builder' |
    led edit-cr-cl https://chromium-review.googlesource.com/c/532516/

To take a Try Builder definition, and populate its properties with the given
CL URL.

R=dnj@chromium.org, nodir@chromium.org

Bug:  662654 
Change-Id: I96e05bf2e17776d74da3cc4a1fc145443aaafd07
Reviewed-on: https://chromium-review.googlesource.com/532516
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>

[add] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/job_edit_cl.go
[modify] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/main.go
[modify] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/cmd_launch.go
[modify] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/cmd_edit_recipe_bundle.go
[modify] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/cmd_get_swarm.go
[modify] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/cmd_edit_system.go
[modify] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/job_def.go
[add] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/cmd_edit_cr_cl.go
[modify] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/cmd_get_builder.go
[modify] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/cmd_edit.go

Project Member

Comment 60 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/823e17daf9ff73a9783f48e91d37f704193fcca5

commit 823e17daf9ff73a9783f48e91d37f704193fcca5
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Jun 13 18:14:44 2017

[led] add edit-cr-cl subcommand.

This subcommand understands old and new-style gerrit URLs, as well as
rietveld URLs, and will manipulate the recipe properties appropriately.

This means you can do, e.g.:

  led get-builder 'luci.infra.try:Some Try Builder' |
    led edit-cr-cl https://chromium-review.googlesource.com/c/532516/

To take a Try Builder definition, and populate its properties with the given
CL URL.

R=dnj@chromium.org, nodir@chromium.org

Bug:  662654 
Change-Id: I96e05bf2e17776d74da3cc4a1fc145443aaafd07
Reviewed-on: https://chromium-review.googlesource.com/532516
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>

[add] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/job_edit_cl.go
[modify] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/main.go
[modify] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/cmd_launch.go
[modify] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/cmd_edit_recipe_bundle.go
[modify] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/cmd_get_swarm.go
[modify] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/cmd_edit_system.go
[modify] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/job_def.go
[add] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/cmd_edit_cr_cl.go
[modify] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/cmd_get_builder.go
[modify] https://crrev.com/823e17daf9ff73a9783f48e91d37f704193fcca5/go/src/infra/tools/led/cmd_edit.go

Project Member

Comment 61 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/21d6ec4814cc5462b91fd0439f38dfe34fb48ad1

commit 21d6ec4814cc5462b91fd0439f38dfe34fb48ad1
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Jun 13 19:52:08 2017

[led] update led to 823e17daf9ff73a9783f48e91d37f704193fcca5.

823e17daf [led] add edit-cr-cl subcommand.
076fbac3c [led] refactor job.go
19c9d154e [led] refactor command-specific functions into their commands.
4e734e2f1 [led] fix broken help messages
9b90d51e6 [led] set buildbucket host instead of url.
42bb05cc3 [led] support symlinks.
3345e64e2 [led] fix some bugs.

TBR=dnj@chromium.org, nodir@chromium.org

Bug:  662654 
Change-Id: Ifb68bb490fe4c8c535b5342e4163057d07844685
Reviewed-on: https://chromium-review.googlesource.com/533819
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/21d6ec4814cc5462b91fd0439f38dfe34fb48ad1/cipd_manifest.txt

Project Member

Comment 62 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4f33697c56b55a27bdce94fc6ff72e119e829f1c

commit 4f33697c56b55a27bdce94fc6ff72e119e829f1c
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Jun 13 22:22:46 2017

[led] fix property typo

R=dnj@chromium.org, nodir@chromium.org

Bug:  662654 
Change-Id: I4786603d34a1873d0813b3bae95528142ece1a1d
Reviewed-on: https://chromium-review.googlesource.com/533821
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/4f33697c56b55a27bdce94fc6ff72e119e829f1c/go/src/infra/tools/led/job_edit_cl.go

Project Member

Comment 63 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bb62539e38b9ca0857e746a82efbd1a54680590f

commit bb62539e38b9ca0857e746a82efbd1a54680590f
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Jun 14 01:04:29 2017

[led] add hack to set luci_project.

This allows milo's embedded veiw inside swarming to render correctly.

R=dnj@chromium.org, nodir@chromium.org

Bug:  662654 
Change-Id: Icd8af07d9fb32580065e59931650b34a70effc8a
Reviewed-on: https://chromium-review.googlesource.com/534659
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/bb62539e38b9ca0857e746a82efbd1a54680590f/go/src/infra/tools/led/cmd_get_builder.go

Project Member

Comment 64 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/c7f8791a0dde00b091dd6c924dd0ec1817b5076c

commit c7f8791a0dde00b091dd6c924dd0ec1817b5076c
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Jun 14 19:20:10 2017

[led] update to a05c9b0865abbfa27673528c5d95c80b55ff87bb

bb62539e3 [led] add hack to set luci_project.
4f33697c5 [led] fix property typo

TBR=dnj@chromium.org, nodir@chromium.org

Bug:  662654 
Change-Id: I42c2742bee5cf30fe529e91f7ec522745a76bac9
Reviewed-on: https://chromium-review.googlesource.com/535893
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/c7f8791a0dde00b091dd6c924dd0ec1817b5076c/cipd_manifest.txt

Project Member

Comment 66 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/72dd7271eff3ca15875437a83f50c28c2dee62d0

commit 72dd7271eff3ca15875437a83f50c28c2dee62d0
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Jun 15 16:40:58 2017

[led] minor improvements.

  * Add swarming priority to `edit-system` subcommand
  * Add "led: " prefix to swarming task name by default (to help
    differentiate it on the swarming task list page).

R=dnj@chromium.org, nodir@chromium.org

Bug:  662654 
Change-Id: I899525a381cc0360a187f66fee84b9533f024aa3
Reviewed-on: https://chromium-review.googlesource.com/536199
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/72dd7271eff3ca15875437a83f50c28c2dee62d0/go/src/infra/tools/led/job.go
[modify] https://crrev.com/72dd7271eff3ca15875437a83f50c28c2dee62d0/go/src/infra/tools/led/cmd_edit_system.go
[modify] https://crrev.com/72dd7271eff3ca15875437a83f50c28c2dee62d0/go/src/infra/tools/led/job_edit.go

Project Member

Comment 67 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/61373ee4bcaf9c875536cd877547725939f7d9cf

commit 61373ee4bcaf9c875536cd877547725939f7d9cf
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Jun 15 19:04:02 2017

[led] update led to a3890a6e0b276b35d734b13a82b164dd7fd8f2b5.

72dd7271e [led] minor improvements.

R=dnj@chromium.org, nodir@chromium.org

Bug:  662654 
Change-Id: I680709209a172c13115b96117f1708cdb15304ae
Reviewed-on: https://chromium-review.googlesource.com/537156
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/61373ee4bcaf9c875536cd877547725939f7d9cf/cipd_manifest.txt

Status: Fixed (was: Started)
done enough for now

Sign in to add a comment