New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Make WebGL2 pass conformance suite 2.0.1

Project Member Reported by zmo@chromium.org, Nov 5 2016

Issue description

This is a meta bug
 

Comment 1 by zmo@chromium.org, Nov 5 2016

Blockedon: 660824

Comment 2 by zmo@chromium.org, Nov 5 2016

Blockedon: 526748

Comment 3 by zmo@chromium.org, Nov 5 2016

Owner: zmo@chromium.org
Status: Fixed (was: Available)

Comment 4 by zmo@chromium.org, Nov 5 2016

Status: Assigned (was: Fixed)

Comment 5 by zmo@chromium.org, Nov 5 2016

Blockedon: 613206

Comment 6 by zmo@chromium.org, Nov 5 2016

Blockedon: 619403

Comment 7 by zmo@chromium.org, Nov 5 2016

Blockedon: 656478

Comment 8 by zmo@chromium.org, Nov 5 2016

Blockedon: 656492

Comment 9 by zmo@chromium.org, Nov 5 2016

Blockedon: 658724

Comment 10 by zmo@chromium.org, Nov 5 2016

Blockedon: 643866

Comment 11 by zmo@chromium.org, Nov 5 2016

Blockedon: 645298

Comment 12 by zmo@chromium.org, Nov 8 2016

Blockedon: 663184

Comment 13 by zmo@chromium.org, Nov 8 2016

Blockedon: 663188

Comment 14 by zmo@chromium.org, Nov 8 2016

Blockedon: 606114

Comment 15 by zmo@chromium.org, Nov 8 2016

Blockedon: 614174

Comment 16 by zmo@chromium.org, Nov 8 2016

Blockedon: 616562

Comment 17 by zmo@chromium.org, Nov 8 2016

Blockedon: 621178

Comment 18 by zmo@chromium.org, Nov 8 2016

Blockedon: 644740

Comment 19 by zmo@chromium.org, Nov 8 2016

Blockedon: 654790

Comment 20 by zmo@chromium.org, Nov 8 2016

Blockedon: 628064

Comment 21 by zmo@chromium.org, Nov 10 2016

Blockedon: 664180

Comment 22 by kbr@chromium.org, Nov 16 2016

Blockedon: 666064

Comment 23 by zmo@chromium.org, Nov 17 2016

Blockedon: 666145

Comment 24 by kbr@chromium.org, Nov 17 2016

Blockedon: 666209

Comment 25 by zmo@chromium.org, Nov 18 2016

Blockedon: 630800

Comment 26 by zmo@chromium.org, Dec 1 2016

Blockedon: 658930

Comment 27 by zmo@chromium.org, Dec 1 2016

Blockedon: 642822

Comment 28 by zmo@chromium.org, Dec 2 2016

Blockedon: 634519
Project Member

Comment 29 by bugdroid1@chromium.org, Dec 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bd07c5ece0d361045873c551c0e474d38edfba6

commit 3bd07c5ece0d361045873c551c0e474d38edfba6
Author: zmo <zmo@chromium.org>
Date: Sat Dec 03 00:13:30 2016

Update WebGL conformance test suite version to 2.0.1

BUG=662644
TEST=GPU FYI bots
NOTRY=true
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2549513003
Cr-Commit-Position: refs/heads/master@{#436090}

[modify] https://crrev.com/3bd07c5ece0d361045873c551c0e474d38edfba6/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/3bd07c5ece0d361045873c551c0e474d38edfba6/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/3bd07c5ece0d361045873c551c0e474d38edfba6/testing/buildbot/chromium.gpu.fyi.json

I think
WebglConformance_conformance2_rendering_blitframebuffer_outside_readbuffer
WebglConformance_conformance2_rendering_clear_srgb_color_buffer
WebglConformance_conformance2_rendering_clipping_wide_points
WebglConformance_conformance2_textures_misc_tex_srgb_mipmap
fail now on Linux Release (AMD R5 230) because of this.
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28AMD%20R5%20230%29/builds/275

Comment 31 by kbr@chromium.org, Dec 3 2016

On both these two:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28AMD%20R5%20230%29/builds/275
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28AMD%20R7%20240%29/builds/956

these four tests fail:

WebglConformance_conformance2_rendering_blitframebuffer_outside_readbuffer
WebglConformance_conformance2_rendering_clear_srgb_color_buffer
WebglConformance_conformance2_rendering_clipping_wide_points
WebglConformance_conformance2_textures_misc_tex_srgb_mipmap
 

On https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28New%20Intel%29/builds/3432 :

webgl2_conformance_angle_tests fails these:
WebglConformance_conformance2_rendering_clear_srgb_color_buffer
WebglConformance_conformance2_rendering_clipping_wide_points
WebglConformance_conformance2_textures_misc_tex_srgb_mipmap

while webgl2_conformance_tests fails these:
WebglConformance_conformance2_rendering_clear_srgb_color_buffer
WebglConformance_conformance2_rendering_clipping_wide_points

Adding suppressions in https://codereview.chromium.org/2550023002/ .

Project Member

Comment 32 by bugdroid1@chromium.org, Dec 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab3ad5dbdd9f8317c18d9f519f51d5b51138659e

commit ab3ad5dbdd9f8317c18d9f519f51d5b51138659e
Author: kbr <kbr@chromium.org>
Date: Sun Dec 04 00:59:54 2016

Add suppressions for WebGL 2.0.1 tests failing on Linux AMD and Intel.

BUG=662644
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2550023002
Cr-Commit-Position: refs/heads/master@{#436182}

[modify] https://crrev.com/ab3ad5dbdd9f8317c18d9f519f51d5b51138659e/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 33 by bugdroid1@chromium.org, Dec 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7f2ba2d6735a1eecc893c37e0bfcf9b1faae76a

commit b7f2ba2d6735a1eecc893c37e0bfcf9b1faae76a
Author: kbr <kbr@chromium.org>
Date: Sun Dec 04 23:43:03 2016

Mark tex-subimage3d-pixel-buffer-bug as an expected failure on Linux Intel.

BUG=662644
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2550983002
Cr-Commit-Position: refs/heads/master@{#436206}

[modify] https://crrev.com/b7f2ba2d6735a1eecc893c37e0bfcf9b1faae76a/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 34 by bugdroid1@chromium.org, Dec 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0756df749c376d7e47b063d5e324a3a713d20df

commit a0756df749c376d7e47b063d5e324a3a713d20df
Author: kbr <kbr@chromium.org>
Date: Mon Dec 05 01:45:36 2016

Suppressions for WebGL 2.0.1 failures on Win Intel.

BUG=662644
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2549003002
Cr-Commit-Position: refs/heads/master@{#436214}

[modify] https://crrev.com/a0756df749c376d7e47b063d5e324a3a713d20df/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 35 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6aae51477ada40703d4e4db8f9f5336048230790

commit 6aae51477ada40703d4e4db8f9f5336048230790
Author: zmo <zmo@chromium.org>
Date: Tue Dec 06 17:26:34 2016

Implement GetIntegerv(SAMPLER_BINDING/TRANSFORM_FEEDBACK_BINDING) in command buffer.

It's always return 0 at the moment. WebGL2 is OK because it returns cached value, but we should still make command buffer work for other clients like Skia.

Also, remove a unnecessary BindAttribLocation call.

BUG=662644
TEST=gpu_unittests
R=vmiura@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2556623002
Cr-Commit-Position: refs/heads/master@{#436625}

[modify] https://crrev.com/6aae51477ada40703d4e4db8f9f5336048230790/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/6aae51477ada40703d4e4db8f9f5336048230790/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
[modify] https://crrev.com/6aae51477ada40703d4e4db8f9f5336048230790/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/6aae51477ada40703d4e4db8f9f5336048230790/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
[modify] https://crrev.com/6aae51477ada40703d4e4db8f9f5336048230790/gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc
[modify] https://crrev.com/6aae51477ada40703d4e4db8f9f5336048230790/gpu/command_buffer/service/sampler_manager.cc
[modify] https://crrev.com/6aae51477ada40703d4e4db8f9f5336048230790/gpu/command_buffer/service/sampler_manager.h
[modify] https://crrev.com/6aae51477ada40703d4e4db8f9f5336048230790/gpu/command_buffer/service/transform_feedback_manager.cc
[modify] https://crrev.com/6aae51477ada40703d4e4db8f9f5336048230790/gpu/command_buffer/service/transform_feedback_manager.h

Blockedon: 672380
Project Member

Comment 37 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a252ab12dc9a944a697c32a0ec2c761c06b59cb

commit 4a252ab12dc9a944a697c32a0ec2c761c06b59cb
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Fri Dec 09 04:58:06 2016

Roll WebGL f554de2..e9afa18

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/f554de2..e9afa18

BUG= 672380 , 662644

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2563603002
Cr-Commit-Position: refs/heads/master@{#437472}

[modify] https://crrev.com/4a252ab12dc9a944a697c32a0ec2c761c06b59cb/DEPS
[modify] https://crrev.com/4a252ab12dc9a944a697c32a0ec2c761c06b59cb/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/4a252ab12dc9a944a697c32a0ec2c761c06b59cb/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Blockedon: 672719
Blockedon: 672722
Project Member

Comment 40 by bugdroid1@chromium.org, Jan 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d44e971a41797ff8bf686d92d0e58480be5c6b3

commit 4d44e971a41797ff8bf686d92d0e58480be5c6b3
Author: zmo <zmo@chromium.org>
Date: Thu Jan 05 17:43:03 2017

Add compressedTex{Sub}Image{2|3}D using PBO signatures to WebGL2

BUG=662644
TEST=conformance
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2613803002
Cr-Commit-Position: refs/heads/master@{#441695}

[modify] https://crrev.com/4d44e971a41797ff8bf686d92d0e58480be5c6b3/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/4d44e971a41797ff8bf686d92d0e58480be5c6b3/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
[modify] https://crrev.com/4d44e971a41797ff8bf686d92d0e58480be5c6b3/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl

Comment 41 by zmo@chromium.org, Feb 4 2017

Blockedon: 688598
Blockedon: 693136
Project Member

Comment 43 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ac9902a04fadaa7e3f307cee39659578e53fe18

commit 1ac9902a04fadaa7e3f307cee39659578e53fe18
Author: zmo <zmo@chromium.org>
Date: Fri Jun 09 04:56:41 2017

Update WebGL2 conformance test expectations for Win bots

BUG= 491419 , 614418 ,662644, 676848 ,680754,693090,705865, 709484 
TEST=GPU FYI bots
TBR=kbr@chromium.org,kainino@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2927233002
Cr-Commit-Position: refs/heads/master@{#478203}

[modify] https://crrev.com/1ac9902a04fadaa7e3f307cee39659578e53fe18/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 44 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5f88b7e35a567c40e25e21b285ec7e8c687e6d6

commit a5f88b7e35a567c40e25e21b285ec7e8c687e6d6
Author: James Darpinian <jdarpinian@chromium.org>
Date: Mon Nov 12 23:09:19 2018

Cleaning up WebGL test failure expectations.

Many of these are leftover failure expectations from fixed bugs.
Some were fixed on some platforms but not others. There are some
new failures that were hidden by previous broad suppressions. Also
some tests are only failing because we haven't updated the drivers
on the bots (http://crbug.com/887241).

Bug:  757097 ,  838133 ,  672380 , 625738,  angleproject:2325 
Bug:  534697 , 849572, 625738, 703779,  angleproject:2142 
Bug: 757098, 644740, 705865, 602688,  angleproject:2103 
Bug: 903903,  740769 , 662644,  680720 ,  angleproject:1932 
Bug:  709874 , 887241,  625365 , angleproject:2952
Change-Id: I4e39e5a09d31d788d8a8615ad06d1ec88f064f00
Reviewed-on: https://chromium-review.googlesource.com/c/1325197
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607367}
[modify] https://crrev.com/a5f88b7e35a567c40e25e21b285ec7e8c687e6d6/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/a5f88b7e35a567c40e25e21b285ec7e8c687e6d6/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/a5f88b7e35a567c40e25e21b285ec7e8c687e6d6/content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py

Project Member

Comment 45 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3aedb8056e4def49921da9c716368676f5171772

commit 3aedb8056e4def49921da9c716368676f5171772
Author: James Darpinian <jdarpinian@chromium.org>
Date: Tue Nov 13 23:54:11 2018

File individual bugs for failing tests.

These were assigned to large meta bugs. I'm filing individual bugs for
each failure so we can track them in our conformance effort.

Bug:  483282 , 662644, 905001, 905003, 905004
Bug: 905006, 905007, 905011
TBR: kbr@chromium.org
Change-Id: I8f7a19d6cf80e1e448ce159622705b1da1445b28
Reviewed-on: https://chromium-review.googlesource.com/c/1334296
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607819}
[modify] https://crrev.com/3aedb8056e4def49921da9c716368676f5171772/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/3aedb8056e4def49921da9c716368676f5171772/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Owner: jdarpinian@chromium.org

Sign in to add a comment