Issue 662626 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ justincarlson@chromium.org Last visit > 30 days ago
Closed:	Nov 2016
Components:	Internals>Printing>CUPS
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

cups printing: ppdprovider crashes on disk output

Project Member Reported by justincarlson@chromium.org, Nov 5 2016

Issue description

Basically, we are doing disk io on the UI thread, and so crashing.

#0 0x2b6f67cd5d9e base::debug::StackTrace::StackTrace()
#1 0x2b6f67d3dd8c logging::LogMessage::~LogMessage()
#2 0x2b6f67ea8294 base::ThreadRestrictions::AssertIOAllowed()
#3 0x2b6f67d0a1c6 base::File::DoInitialize()
#4 0x2b6f67ce7f5e base::File::Initialize()
#5 0x2b6f67ce7ea6 base::File::File()
#6 0x2b6f71a430f0 chromeos::printing::(anonymous namespace)::PpdCacheImpl::MaybeReadAvailablePrintersCache()
#7 0x2b6f71a421a7 chromeos::printing::(anonymous namespace)::PpdCacheImpl::FindAvailablePrinters()
#8 0x2b6f71a46b53 chromeos::printing::(anonymous namespace)::PpdProviderImpl::QueryAvailable()
#9 0x2b6f638265fa <unknown>
#10 0x2b6f5ec3493d <unknown>
#11 0x2b6f5ec34846 <unknown>
#12 0x2b6f63829117 <unknown>
#13 0x2b6f6382904c <unknown>
#14 0x2b6f6b8e1fe6 base::internal::RunMixin<>::Run()
#15 0x2b6f6ce667db content::WebUIImpl::ProcessWebUIMessage()
#16 0x2b6f6ce655ed content::WebUIImpl::OnWebUISend()

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c31c58ba48632b1713cde7c0e83483595907fb20

commit c31c58ba48632b1713cde7c0e83483595907fb20
Author: justincarlson <justincarlson@chromium.org>
Date: Tue Nov 15 02:24:15 2016

Update PpdProvider threading model.

We are crashing the browser right now because PpdProvider does disk
operations (via PpdCache), and those are invoked on the UI thread.  Fix
this by making PpdProvider take an explicit task runner on which to do
disk operations and pull them off the UI thread.

BUG= 662626 

Review-Url: https://codereview.chromium.org/2476073003
Cr-Commit-Position: refs/heads/master@{#432062}

[modify] https://crrev.com/c31c58ba48632b1713cde7c0e83483595907fb20/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/c31c58ba48632b1713cde7c0e83483595907fb20/chromeos/printing/ppd_cache.cc
[modify] https://crrev.com/c31c58ba48632b1713cde7c0e83483595907fb20/chromeos/printing/ppd_provider.cc
[modify] https://crrev.com/c31c58ba48632b1713cde7c0e83483595907fb20/chromeos/printing/ppd_provider.h
[modify] https://crrev.com/c31c58ba48632b1713cde7c0e83483595907fb20/chromeos/printing/ppd_provider_unittest.cc