Issue 662621 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	dcasta...@chromium.org
Closed:	Dec 2016
Cc:	█ reve...@chromium.org
Components:	Internals>GPU
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
Hotlist-Merge-Approved merge-merged-2883 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Disable full screen overlay optimization when using software mirroring

Project Member Reported by dcasta...@chromium.org, Nov 5 2016

Issue description

Software mirroring works copying to a texture the content of the current framebuffer and then drawing the texture to the other screen.

When an overlay candidate covers the whole screen, we schedule that as primary plane instead of compositing to the framebuffer, if possible.
This means when the optimization is active, software mirroring will not show the content presented on the primary screen.

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccca423509d132e9c704188c284e7f11cba4f856

commit ccca423509d132e9c704188c284e7f11cba4f856
Author: dcastagna <dcastagna@chromium.org>
Date: Thu Nov 10 04:47:06 2016

Disable fullscren fb optimization with sw mirroring.

Display software mirroring copies the current fb into a texture
and draws with that.

This CL disables fullscreen fb optimization and always falls back
to GL compositing when SW mirroring is enabled.

BUG= 662621 
TEST=ran on kevin with sw mirroring and fs app.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2476103002
Cr-Commit-Position: refs/heads/master@{#431184}

[modify] https://crrev.com/ccca423509d132e9c704188c284e7f11cba4f856/cc/output/overlay_strategy_fullscreen.cc
[modify] https://crrev.com/ccca423509d132e9c704188c284e7f11cba4f856/cc/output/overlay_strategy_fullscreen.h
[modify] https://crrev.com/ccca423509d132e9c704188c284e7f11cba4f856/cc/output/overlay_unittest.cc
[modify] https://crrev.com/ccca423509d132e9c704188c284e7f11cba4f856/components/display_compositor/compositor_overlay_candidate_validator_ozone.cc

Comment 2 by dcasta...@chromium.org, Nov 10 2016

Labels: Merge-Request-55

Comment 3 by dimu@chromium.org, Nov 11 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved

Your change meets the bar and is auto-approved for M55 (branch: 2883)

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 15 2016

Labels: -merge-approved-55 merge-merged-2883

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b732ee740840e3d3083911f3fe34e919cae0309

commit 0b732ee740840e3d3083911f3fe34e919cae0309
Author: dcastagna <dcastagna@chromium.org>
Date: Tue Nov 15 01:42:13 2016

Disable fullscren fb optimization with sw mirroring.

Merge to M55.

Display software mirroring copies the current fb into a texture
and draws with that.

This CL disables fullscreen fb optimization and always falls back
to GL compositing when SW mirroring is enabled.

BUG= 662621 
TEST=ran on kevin with sw mirroring and fs app.
NOTRY=true
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2476103002
Cr-Commit-Position: refs/heads/master@{#431184}
(cherry picked from commit ccca423509d132e9c704188c284e7f11cba4f856)

Review-Url: https://codereview.chromium.org/2501773002
Cr-Commit-Position: refs/branch-heads/2883@{#571}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/0b732ee740840e3d3083911f3fe34e919cae0309/cc/output/overlay_strategy_fullscreen.cc
[modify] https://crrev.com/0b732ee740840e3d3083911f3fe34e919cae0309/cc/output/overlay_strategy_fullscreen.h
[modify] https://crrev.com/0b732ee740840e3d3083911f3fe34e919cae0309/cc/output/overlay_unittest.cc
[modify] https://crrev.com/0b732ee740840e3d3083911f3fe34e919cae0309/components/display_compositor/compositor_overlay_candidate_validator_ozone.cc