New issue
Advanced search Search tips

Issue 662618 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Task throttling is broken for off screen frames

Project Member Reported by esprehn@chromium.org, Nov 5 2016

Issue description

See: https://codereview.chromium.org/2272773002#msg135

"""
This patch broke timer throttling for hidden iframes, it removed the calls to

setCrossOrigin and setFrameVisible that were in there, those now have no callers so I think we're never throttling off screen cross origin frame tasks which is supposed to be shipped per:

TimerThrottlingForHiddenFrames status=stable

looks like there's no tests for this, just unit tests for the scheduler:
RepeatingTimer_FrameHidden_SameOrigin

there should really be some layout tests for timer throttling too. :)
"""
 
Labels: TE-NeedsTriageHelp
Labels: -TE-NeedsTriageHelp
#1: I think this bug is already triaged correctly.
Labels: OS-All
This looks like OS-All but please correct me if I'm wrong.
@skyostil -- Could you please give us any update on this issue as there is ReleasezBlock_stable label.

Thanks!
Labels: -ReleaseBlock-Stable
This is blocked on a gmail change reaching production (cl/141148114).

I don't think we should block the release for this because we haven't actually shipped offscreen timer throttling yet.
Status: Fixed (was: Assigned)
Fixed by https://codereview.chromium.org/2468863002/ (which also added some tests)

Sign in to add a comment