New issue
Advanced search Search tips

Issue 662605 link

Starred by 1 user
Status: Fixed
Owner:
est...@chromium.org
Closed: Nov 2016
Cc:
sky@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug

Blocking:
issue 657159



Sign in to add a comment

NativeScrollBar should be folded into NativeScrollBarViews

Project Member Reported by est...@chromium.org, Nov 5 2016 
I think NativeScrollBar must exist for historical reasons. I expect it used to wrap more than one kind of native scroll bar (e.g. a Windows one, a mac one, etc.). That's no longer the case, so it's an awkward relationship that is mostly a pass-through to NativeScrollBarViews.

(Note that it's not used on MacOS at all.)

Comment 1 by est...@chromium.org, Nov 5 2016

Blocking: 657159
Labels: -Pri-3 M-56 Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c40d5ad5f0814c514aa366e4b8cb9e7218dc008

commit 4c40d5ad5f0814c514aa366e4b8cb9e7218dc008
Author: estade <estade@chromium.org>
Date: Mon Nov 07 18:10:46 2016

Remove NativeScrollBar*.

NativeScrollBar used to wrap NativeScrollBarViews, but it was almost
entirely a pass-through shim. Thus, now we just have one layer of views
scrollbars called ScrollBarViews.

BUG= 662605 

Review-Url: https://codereview.chromium.org/2480763005
Cr-Commit-Position: refs/heads/master@{#430316}

[modify] https://crrev.com/4c40d5ad5f0814c514aa366e4b8cb9e7218dc008/chrome/browser/ui/views/status_bubble_views.cc
[modify] https://crrev.com/4c40d5ad5f0814c514aa366e4b8cb9e7218dc008/ui/views/BUILD.gn
[modify] https://crrev.com/4c40d5ad5f0814c514aa366e4b8cb9e7218dc008/ui/views/controls/scroll_view_unittest.cc
[modify] https://crrev.com/4c40d5ad5f0814c514aa366e4b8cb9e7218dc008/ui/views/controls/scrollbar/base_scroll_bar.h
[delete] https://crrev.com/1d6f92104c5044b1c9057a08980088e4f3b43b75/ui/views/controls/scrollbar/native_scroll_bar.cc
[delete] https://crrev.com/1d6f92104c5044b1c9057a08980088e4f3b43b75/ui/views/controls/scrollbar/native_scroll_bar.h
[delete] https://crrev.com/1d6f92104c5044b1c9057a08980088e4f3b43b75/ui/views/controls/scrollbar/native_scroll_bar_views.h
[delete] https://crrev.com/1d6f92104c5044b1c9057a08980088e4f3b43b75/ui/views/controls/scrollbar/native_scroll_bar_wrapper.h
[rename] https://crrev.com/4c40d5ad5f0814c514aa366e4b8cb9e7218dc008/ui/views/controls/scrollbar/scroll_bar_views.cc
[add] https://crrev.com/4c40d5ad5f0814c514aa366e4b8cb9e7218dc008/ui/views/controls/scrollbar/scroll_bar_views.h
[modify] https://crrev.com/4c40d5ad5f0814c514aa366e4b8cb9e7218dc008/ui/views/controls/scrollbar/scrollbar_unittest.cc
[modify] https://crrev.com/4c40d5ad5f0814c514aa366e4b8cb9e7218dc008/ui/views/style/platform_style.cc

Comment 3 by est...@chromium.org, Nov 7 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment