New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 662596 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
dbeam@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Content settings] policy controls for category toggle

Project Member Reported by dschuyler@chromium.org, Nov 4 2016 
in chrome://md-settings/content/* each page has a top-level toggle to enable/disable the category. That control doesn't currently show when it's controlled by policy and it should. 
(The value of the setting is currently a string about whether it's enabled and it should be a dictionary that relays the current setting along with the source (policy info) for that setting).

Comment 1 by dschuyler@chromium.org, Nov 17 2016

Blocking: 614265
Cc: dbeam@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2e359aa4089b7123cce6263658a35ac66eaa45d

commit a2e359aa4089b7123cce6263658a35ac66eaa45d
Author: dschuyler <dschuyler@chromium.org>
Date: Wed Dec 07 23:09:29 2016

[MD settings] include source of policy for content settings

This CL is a step toward showing policy (controlled by) indicators in
the content settings. This CL adds the C++ side and proxy layer changes.
The UI changes will be in a separate CL.

This CL is a breakout piece from the lager prior CL 2509163004.

BUG= 662596 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2552883009
Cr-Commit-Position: refs/heads/master@{#437103}

[modify] https://crrev.com/a2e359aa4089b7123cce6263658a35ac66eaa45d/chrome/browser/resources/settings/site_settings/site_settings_category.js
[modify] https://crrev.com/a2e359aa4089b7123cce6263658a35ac66eaa45d/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/a2e359aa4089b7123cce6263658a35ac66eaa45d/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/a2e359aa4089b7123cce6263658a35ac66eaa45d/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
[modify] https://crrev.com/a2e359aa4089b7123cce6263658a35ac66eaa45d/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/a2e359aa4089b7123cce6263658a35ac66eaa45d/chrome/browser/ui/webui/site_settings_helper.h
[modify] https://crrev.com/a2e359aa4089b7123cce6263658a35ac66eaa45d/chrome/test/data/webui/settings/site_settings_category_tests.js

Comment 3 by dbeam@chromium.org, Dec 8 2016

Labels: -Pri-3 Pri-2

Comment 4 by dbeam@chromium.org, Dec 8 2016

Blocking: -614265
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc70cf415de67da7837b1fd7a8cb6109bf102799

commit bc70cf415de67da7837b1fd7a8cb6109bf102799
Author: dschuyler <dschuyler@chromium.org>
Date: Wed Dec 21 23:47:05 2016

[MD settings] content category policy

This CL adds a controlled-by indicator to the top-level content settings
categories.

BUG= 662596 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2509163004
Cr-Commit-Position: refs/heads/master@{#440266}

[modify] https://crrev.com/bc70cf415de67da7837b1fd7a8cb6109bf102799/chrome/browser/resources/settings/site_settings/category_default_setting.html
[modify] https://crrev.com/bc70cf415de67da7837b1fd7a8cb6109bf102799/chrome/browser/resources/settings/site_settings/category_default_setting.js
[modify] https://crrev.com/bc70cf415de67da7837b1fd7a8cb6109bf102799/chrome/test/data/webui/settings/category_default_setting_tests.js

Comment 6 by dschuyler@chromium.org, Dec 21 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment