Tracking bug for upstreaming iOS native app launching to Chromium.
rohitrao: I forgot who's supposed to do this task. Please reassign if necessary.
Assigning to me.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a720602de2706c6bc5a47e3bee207e9d52e669e2 commit a720602de2706c6bc5a47e3bee207e9d52e669e2 Author: sczs <sczs@google.com> Date: Wed Nov 09 22:34:40 2016 [ios] Create NativeAppTypes class This class contains enums that will be used by native_app_launcher classes. BUG= 662573 Review-Url: https://codereview.chromium.org/2483303003 Cr-Commit-Position: refs/heads/master@{#431055} [modify] https://crrev.com/a720602de2706c6bc5a47e3bee207e9d52e669e2/ios/public/provider/chrome/browser/BUILD.gn [add] https://crrev.com/a720602de2706c6bc5a47e3bee207e9d52e669e2/ios/public/provider/chrome/browser/native_app_launcher/native_app_types.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50d00a67e659fd519e1ed60f132becd9e65b4a79 commit 50d00a67e659fd519e1ed60f132becd9e65b4a79 Author: sczs <sczs@google.com> Date: Fri Nov 11 13:14:26 2016 Adds protocols for native app launching. BUG= 662573 Review-Url: https://codereview.chromium.org/2464963004 Cr-Commit-Position: refs/heads/master@{#431555} [modify] https://crrev.com/50d00a67e659fd519e1ed60f132becd9e65b4a79/ios/public/provider/chrome/browser/BUILD.gn [modify] https://crrev.com/50d00a67e659fd519e1ed60f132becd9e65b4a79/ios/public/provider/chrome/browser/chrome_browser_provider.h [modify] https://crrev.com/50d00a67e659fd519e1ed60f132becd9e65b4a79/ios/public/provider/chrome/browser/chrome_browser_provider.mm [add] https://crrev.com/50d00a67e659fd519e1ed60f132becd9e65b4a79/ios/public/provider/chrome/browser/native_app_launcher/OWNERS [add] https://crrev.com/50d00a67e659fd519e1ed60f132becd9e65b4a79/ios/public/provider/chrome/browser/native_app_launcher/native_app_metadata.h [add] https://crrev.com/50d00a67e659fd519e1ed60f132becd9e65b4a79/ios/public/provider/chrome/browser/native_app_launcher/native_app_whitelist_manager.h [modify] https://crrev.com/50d00a67e659fd519e1ed60f132becd9e65b4a79/ios/public/provider/chrome/browser/test_chrome_browser_provider.h [modify] https://crrev.com/50d00a67e659fd519e1ed60f132becd9e65b4a79/ios/public/provider/chrome/browser/test_chrome_browser_provider.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/b55d72858a8378c463f26fd17d9afd66b6409b44 commit b55d72858a8378c463f26fd17d9afd66b6409b44 Author: sczs <sczs@google.com> Date: Tue Nov 15 22:18:01 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6db193bb9e47e9a6dc442e379f73441aca51a281 commit 6db193bb9e47e9a6dc442e379f73441aca51a281 Author: sczs <sczs@google.com> Date: Tue Nov 22 18:37:12 2016 [ios] Move NativeAppLauncher upstream BUG= 662573 Review-Url: https://codereview.chromium.org/2508663002 Cr-Commit-Position: refs/heads/master@{#433923} [modify] https://crrev.com/6db193bb9e47e9a6dc442e379f73441aca51a281/ios/chrome/BUILD.gn [modify] https://crrev.com/6db193bb9e47e9a6dc442e379f73441aca51a281/ios/chrome/app/strings/ios_strings.grd [add] https://crrev.com/6db193bb9e47e9a6dc442e379f73441aca51a281/ios/chrome/browser/native_app_launcher/BUILD.gn [add] https://crrev.com/6db193bb9e47e9a6dc442e379f73441aca51a281/ios/chrome/browser/native_app_launcher/ios_appstore_ids.h [add] https://crrev.com/6db193bb9e47e9a6dc442e379f73441aca51a281/ios/chrome/browser/native_app_launcher/ios_appstore_ids.mm [add] https://crrev.com/6db193bb9e47e9a6dc442e379f73441aca51a281/ios/chrome/browser/native_app_launcher/native_app_infobar_controller.h [add] https://crrev.com/6db193bb9e47e9a6dc442e379f73441aca51a281/ios/chrome/browser/native_app_launcher/native_app_infobar_controller.mm [add] https://crrev.com/6db193bb9e47e9a6dc442e379f73441aca51a281/ios/chrome/browser/native_app_launcher/native_app_infobar_controller_unittest.mm [add] https://crrev.com/6db193bb9e47e9a6dc442e379f73441aca51a281/ios/chrome/browser/native_app_launcher/native_app_infobar_delegate.h [add] https://crrev.com/6db193bb9e47e9a6dc442e379f73441aca51a281/ios/chrome/browser/native_app_launcher/native_app_infobar_delegate.mm [add] https://crrev.com/6db193bb9e47e9a6dc442e379f73441aca51a281/ios/chrome/browser/native_app_launcher/native_app_infobar_delegate_unittest.mm [add] https://crrev.com/6db193bb9e47e9a6dc442e379f73441aca51a281/ios/chrome/browser/native_app_launcher/native_app_navigation_controller_protocol.h
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/2ad35704921365684f6b0f752079f02947e72d34 commit 2ad35704921365684f6b0f752079f02947e72d34 Author: sczs <sczs@google.com> Date: Sat Nov 26 12:36:22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/361b7f0fcda579b98df8e77090ff994bebcdd4cc commit 361b7f0fcda579b98df8e77090ff994bebcdd4cc Author: sczs <sczs@google.com> Date: Wed Nov 30 01:50:30 2016 Create FakeProviders for NativeAppMetadata and NativeAppManager These 2 classes will be used instead of Mocks for all tests where a basic NativeApp* implementation is needed. BUG= 662573 Review-Url: https://codereview.chromium.org/2529763002 Cr-Commit-Position: refs/heads/master@{#435116} [modify] https://crrev.com/361b7f0fcda579b98df8e77090ff994bebcdd4cc/ios/public/provider/chrome/browser/BUILD.gn [modify] https://crrev.com/361b7f0fcda579b98df8e77090ff994bebcdd4cc/ios/public/provider/chrome/browser/native_app_launcher/BUILD.gn [add] https://crrev.com/361b7f0fcda579b98df8e77090ff994bebcdd4cc/ios/public/provider/chrome/browser/native_app_launcher/fake_native_app_metadata.h [add] https://crrev.com/361b7f0fcda579b98df8e77090ff994bebcdd4cc/ios/public/provider/chrome/browser/native_app_launcher/fake_native_app_metadata.mm [add] https://crrev.com/361b7f0fcda579b98df8e77090ff994bebcdd4cc/ios/public/provider/chrome/browser/native_app_launcher/fake_native_app_whitelist_manager.h [add] https://crrev.com/361b7f0fcda579b98df8e77090ff994bebcdd4cc/ios/public/provider/chrome/browser/native_app_launcher/fake_native_app_whitelist_manager.mm
native_app_navigation_controller is the only class that remains to be upstreamed. Other than that everything else is upstream.
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/e1cd212f12417d6b04994256afb467d97196fe89 commit e1cd212f12417d6b04994256afb467d97196fe89 Author: rohitrao <rohitrao@google.com> Date: Wed Dec 07 13:40:11 2016
Comment 1 by pkl@chromium.org
, Nov 7 2016Status: Assigned (was: Untriaged)