XFormTest.BlendScale, XFormTest.verifyIsInvertible fail on arm |
|||
Issue descriptionI figured we should run gfx_unittests on Android (https://codereview.chromium.org/2483493002). https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/62130/steps/gfx_unittests%20%28with%20patch%29%20on%20Android/logs/XFormTest.verifyIsInvertible XFormTest.BlendScale (run #1): [ RUN ] XFormTest.BlendScale ../../ui/gfx/transform_unittest.cc:773: Failure Value of: to.matrix().get(1, 1) Actual: 0 Expected: t * 3 + 1 Which is: 5.5511151e-17 i: -3 [ FAILED ] XFormTest.BlendScale (0 ms) (Looks like this test already does EXPECT_FLOAT_EQ(), but that apparently requires more precision than what we get on arm?) https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/62130/steps/gfx_unittests%20%28with%20patch%29%20on%20Android/logs/XFormTest.BlendScale XFormTest.verifyIsInvertible (run #1): [ RUN ] XFormTest.verifyIsInvertible ../../ui/gfx/transform_unittest.cc:2066: Failure Value of: A.IsInvertible() Actual: true Expected: false [ FAILED ] XFormTest.verifyIsInvertible (0 ms) (Probably also some float precision thing) Enne, can you take a look? This blocks running gfx_unittests on Android.
,
Nov 8 2016
Sure, I can take a look. I think we should add more slop to EXPECT_FLOAT_EQ here and not worry too much about it. 5e-17 is close enough to zero for me. I'm honestly surprised that EXPECT_FLOAT_EQ disagrees.
,
Nov 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c10e8e86d03fb5308bc00d1d468662e6eff59268 commit c10e8e86d03fb5308bc00d1d468662e6eff59268 Author: thakis <thakis@chromium.org> Date: Thu Nov 10 03:02:39 2016 android: run gfx_unittests on bots. Also disable a few tests that don't pass on Android. BUG= 662559 , 642010 , 662556 , 662558 , 662561 Review-Url: https://codereview.chromium.org/2483493002 Cr-Commit-Position: refs/heads/master@{#431157} [modify] https://crrev.com/c10e8e86d03fb5308bc00d1d468662e6eff59268/testing/buildbot/chromium.android.json [modify] https://crrev.com/c10e8e86d03fb5308bc00d1d468662e6eff59268/ui/gfx/font_unittest.cc [modify] https://crrev.com/c10e8e86d03fb5308bc00d1d468662e6eff59268/ui/gfx/geometry/quad_unittest.cc [modify] https://crrev.com/c10e8e86d03fb5308bc00d1d468662e6eff59268/ui/gfx/geometry/vector3d_unittest.cc [modify] https://crrev.com/c10e8e86d03fb5308bc00d1d468662e6eff59268/ui/gfx/platform_font_android.cc [modify] https://crrev.com/c10e8e86d03fb5308bc00d1d468662e6eff59268/ui/gfx/transform_unittest.cc
,
Nov 11 2016
I can fix BlendScale, but IsInvertible is part of Skia's SkMatrix44. It calculates the determinant, which is -2.2329881363207037e-13 when I ran it through android_n5x_swarming_rel. 1 / det is finite, so Skia says it can be inverted. I'm not sure what we want to do with close-to-not-invertible matrices. I'm not sure that this test is really buying that much tbh either.
,
Nov 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6ef18f5d02dec16cd8f8413f75e974aadaac043 commit c6ef18f5d02dec16cd8f8413f75e974aadaac043 Author: enne <enne@chromium.org> Date: Fri Nov 11 21:29:18 2016 Reenable XFormTest.BlendScale on ARM This changes the numerical calculation to be similar to how it is calculated in practice to have the same amount of floating point error in both cases. BUG= 662558 Review-Url: https://codereview.chromium.org/2495703002 Cr-Commit-Position: refs/heads/master@{#431650} [modify] https://crrev.com/c6ef18f5d02dec16cd8f8413f75e974aadaac043/ui/gfx/transform_unittest.cc
,
Dec 13 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by thakis@chromium.org
, Nov 4 2016