New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662548 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Unit Test for the "Execute JavaScript" AppleScript command

Project Member Reported by spqc...@chromium.org, Nov 4 2016

Issue description

Write a unit test for  Issue 661810 

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c5d541e0f6be90e74f6b20dd92e963d0115213d

commit 2c5d541e0f6be90e74f6b20dd92e963d0115213d
Author: spqchan <spqchan@chromium.org>
Date: Wed Oct 25 07:07:11 2017

[Mac] "Disable Javascript via Apple Events" menu item

Remove and replace the "Disable Applescript Javascript" finch
flag with a "Enable JavaScript in Apple Events" menu item.

The menu item is behind a finch flag and is attached to the
new profile preference: "browser.allow_javascript_apple_events"

New tests are also added.

Testing: Browser tests (TabAppleScriptTest, WindowAppleScriptTest,
BookmarkItemAppleScriptTest)

Bug:  662548 , 777644
Change-Id: I6b1f0f308b3f25974cdaceb66b7c60903c6378a9
Reviewed-on: https://chromium-review.googlesource.com/603882
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511400}
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/app/generated_resources.grd
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/app/nibs/MainMenu.xib
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/browser/ui/browser_ui_prefs.cc
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/browser/ui/cocoa/applescript/apple_event_util.h
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/browser/ui/cocoa/applescript/apple_event_util.mm
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/browser/ui/cocoa/applescript/bookmark_item_applescript.mm
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/browser/ui/cocoa/applescript/bookmark_item_applescript_browsertest.mm
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/browser/ui/cocoa/applescript/tab_applescript.h
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/browser/ui/cocoa/applescript/tab_applescript.mm
[add] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/browser/ui/cocoa/applescript/tab_applescript_browsertest.mm
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/browser/ui/cocoa/browser_window_command_handler.mm
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/common/chrome_features.cc
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/common/chrome_features.h
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/common/pref_names.cc
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/common/pref_names.h
[modify] https://crrev.com/2c5d541e0f6be90e74f6b20dd92e963d0115213d/chrome/test/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment