New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 662545 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Nov 2016
Cc:
█ scottchen@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Action menu pop-up styling

Project Member Reported by dschuyler@chromium.org, Nov 4 2016 
In this mock 

https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_menu.png%3Fz=width

The styling calls for 8px border at the top and bottom of the menu.
Also, the highlighting is a sold grey background (rather than a grey outline border).

Alan, we are not sure if those mocks are up to date. How would you like this styling to be? After making a note of what you'd like, please assign this to dpapad@ or scottchen@.

Comment 1 by bettes@chromium.org, Nov 7 2016

Cc: -dpa...@chromium.org
Owner: dpa...@chromium.org
>> The styling calls for 8px border at the top and bottom of the menu.

That's correct. Still expected (part of default polymer?)

>> the highlighting is a sold grey background (rather than a grey outline border).

Not expected. I believe we opted to use default polymer behavior as described on their site under "Paper Icon Button + Paper Menu"

https://elements.polymer-project.org/elements/paper-menu-button?view=demo:demo/index.html&active=paper-menu-button

>> (rather than a grey outline border).

I assume this is equivalent to the blue border on my Mac? This looks bad. Hopefully with the default polymer behavior you can remove

Comment 2 by dpa...@chromium.org, Nov 8 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66c9c9b813fcc5e538b0b17e28d816a0e7d292fb

commit 66c9c9b813fcc5e538b0b17e28d816a0e7d292fb
Author: dpapad <dpapad@chromium.org>
Date: Wed Nov 09 23:25:29 2016

MD Settings: Tweak action menu styling to match the mocks.

 - Adding 8px top/bottom padding.
 - Adding background-color for focused options.
 - Removing default focus highlight (outline).

BUG= 662545 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2489723002
Cr-Commit-Position: refs/heads/master@{#431077}

[modify] https://crrev.com/66c9c9b813fcc5e538b0b17e28d816a0e7d292fb/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html

Comment 4 by dpa...@chromium.org, Nov 10 2016

Status: Fixed (was: Started)
►

Sign in to add a comment