New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 662543 link

Starred by 1 user
Status: Fixed
Owner:
lukasza@chromium.org
Closed: Sep 2017
Cc:
a...@chromium.org
█ nick@chromium.org
█ jcivelli@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Try to remove domAutomationController.setAutomationId

Project Member Reported by lukasza@chromium.org, Nov 4 2016 
Value passed to domAutomationController.setAutomationId is no longer looked at (only compared against MSG_ROUTING_NONE).

Almost all calls to domAutomationController.send are prefix with a call to domAutomationController.setAutomationId.

Let's try to just remove domAutomationController.setAutomationId.

Comment 1 by lukasza@chromium.org, Nov 4 2016

Cc: jcivelli@chromium.org
I also see a TODO:
  // TODO(jcampan): we should make the domAutomationController not require an
  //                automation id.

Comment 2 by lukasza@chromium.org, Nov 4 2016 

I am trying to put together a CL @ https://crrev.com/2478803003.
Wish me luck :-)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7d6bd3d4561ae85c1e2baf25136e930aa33b055

commit c7d6bd3d4561ae85c1e2baf25136e930aa33b055
Author: lukasza <lukasza@chromium.org>
Date: Tue Jul 11 00:19:55 2017

Remove DOMAutomationController::automation_id_

Main change in this CL
======================

For a long time now the DOMAutomationController::automation_id_ value has
not been used for its original purpose (associating sends with
particular "jobs" / "automations" / render_views).  Right now, the
argument of domAutomationController::send is always routed back to
WebContents (not to any more granular/specific destination).

Right now the DOMAutomationController::automation_id_ field is still
used to enable/disable domAutomationController::send - the send only
works if setAutomationId was called previously (with a value different
than MSG_ROUTING_NONE).  In fact - in almost all cases, the scripts
say:
  domAutomationController.setAutomationId(0)
  domAutomationController.send(...)

This CL removes DOMAutomationController::automation_id_ field and
makes domAutomationController.send work unconditionally.

After this CL lands, we will be able to remove all calls to
setAutomationId (after this CL they will be no-ops).

Other changes needed by this CL
===============================

The CL needed to make the following, additional fixes:

1. ExecuteScript (in content/public/test/browser_test_utils.h / .cc)
   appends "; domAutomationController.send(0);" to the script provided
   by the caller.  This extra value would be usually ignored before
   this CL, but gets in the way after this CL (e.g. can get confused
   with other calls to domAutomationController.send(...)).  To account
   for this a new ExecuteScriptAsync function has been provided in
   this CL.

   Ideally ExecuteScript would become ExecuteScriptAsync, but
   there are multiple tests that depend on the extra pumping of the
   message loop that happens in ExecuteScript and not in
   ExecuteScriptAsync.  Therefore, ExecuteScriptAsync is
   a lesser evil, that minimizes amount of changes needed right now.

   To make sure that ExecuteScript stops waiting after the call to
   |domAutomationController.send(...)| that is added by ExecuteScript
   (and not by some other, accidental send) this CL sends a GUID that
   is unique in each call to ExecuteScript and verifies that the same
   GUID has been received back.  This change has flushed out a few
   additional cases where ExecuteScriptAsync needs to be used
   as well as cases where a call to domAutomationController.send
   can be removed.

   The following callers of ExecuteScript had to be switched to
   call ExecuteScriptAsync instead:

   - ExecuteWebUIResourceTest (consumes messages via DOMMessageQueue
     and relies on the fact that this queue is not stumped upon).
     Additionally, it turned out that client_renderer.js and
     media_internals.js (used by WebUIResourceBrowserTest tests) were
     always erroring out before this CL (this has gone unnoticed,
     because the "FAILURE" string would have been eaten by
     ExecuteScript).

   - SecurityExploitBrowserTest.InterstitialCommandFromUnderlyingContent
     (otherwise the artificual "0" ends up in interstitial->last_command()).

   - captive_portal_browsertest.cc (otherwise we trigger a CHECK in
     captive_portal_blocking_page.cc: Command 0 isn't handled by the
     captive portal interstitial).

     Note that CaptivePortalBrowserTest /
     ShowCaptivePortalInterstitialOnCertError was relying on message
     pumping done by ExecuteScript.  This was fragile - the timing of
     exiting the message pump was not related to the timing of the event
     the test needs to wait for.  This was broken after going through
     ExecuteScriptAsync.  This is fixed by introducing an explicit
     TabActivationWaiter.

   - ExecuteScriptInBackgroundPageNoWait (otherwise DOMMessageQueue
     used by ProcessManagerBrowserTest.ExtensionProcessReuse would
     have unexpectedly gotten a value sent by ExecuteScript, rather
     than the value send by the script itself;  additionally, calling
     Execute*Unmodified*Script here makes sense in a function named
     "NoWait" - ExecuteScript would have waited).

   - saml_browsertest.cc - there was undesired interaction with
     listening to the value sent by SetupAuthFlowChangeListener.

   - ChromeSitePerProcessTest.PopupWindowFocus - this would conflict
     with domAutomationController.send from
     chrome/test/data/page_with_focus_events.html

   The following callers of ExecuteScript were needlessly calling
   domAutomationController.send from the script:

   - ProxyAuthOnUserBoardScreenTest.ProxyAuthDialogOnUserBoardScreen
   - WizardControllerTest::JSExecute
   - NavigationControllerBrowserTest.PostInSubframe
   - SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs

2. autofill_interactive_uitest.cc used to call
   domAutomationController.send(true) from onfocus DOM event handlers.
   This would confuse expectations of ExecuteScriptAndExtractInt running
   "domAutomationController.send(42)" (it would sometimes receive a
   boolean rather than int back).  This is fixed by using a one-time
   onfocus handlers (rather than permanent handlers) from
   FocusFieldByName method.

3. After the changes some GeolocationBrowserTest would receive
   "geoposition-updated" message twice - once from the
   geoSuccessCallbackWithResponse callback (from
   chrome/test/data/geolocation/basic_geolocation.js)
   and once from a checkIfGeopositionUpdated function.

   There is no need to resolve the race via checkIfGeopositionUpdated if
   we start listening (via DOMMessageQueue) *before* trigerring an
   update in the geo position.  This way we can keep just the callback
   and remove the no longer needed checkIfGeopositionUpdated function.

4. content::IsWebcamAvailableOnSystem (via kHasVideoInputDeviceOnSystem)
   would call domAutomationController.send(...) twice before this CL.
   After this CL it is only called once.

Other, opportunistic changes
============================

I've noticed that DOMMessageQueue::message_loop_runner_ can be null
and therefore uses of this field need to be guarded.  This required
remembering result of DOMMessageQueue::RenderProcessGone, so that
it still has an effect when there was no runner when the renderer
crash notification happened.

BUG= 662543 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2478803003
Cr-Commit-Position: refs/heads/master@{#485461}

[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/chrome/browser/autofill/autofill_interactive_uitest.cc
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/chrome/browser/captive_portal/captive_portal_browsertest.cc
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/chrome/browser/chrome_site_per_process_browsertest.cc
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/chrome/browser/chromeos/login/saml/saml_browsertest.cc
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/chrome/browser/extensions/browsertest_util.cc
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/chrome/browser/geolocation/geolocation_browsertest.cc
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/chrome/test/data/geolocation/basic_geolocation.js
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/chrome/test/data/geolocation/two_watches.html
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/content/browser/resources/media/client_renderer.js
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/content/browser/resources/media/media_internals.js
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/content/public/test/browser_test_utils.h
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/content/renderer/dom_automation_controller.cc
[modify] https://crrev.com/c7d6bd3d4561ae85c1e2baf25136e930aa33b055/content/renderer/dom_automation_controller.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e11581c14be9b15a9ac690d6a62483fbb92abd8

commit 9e11581c14be9b15a9ac690d6a62483fbb92abd8
Author: lukasza <lukasza@chromium.org>
Date: Wed Jul 12 01:25:19 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=boliu@chromium.org

Review-Url: https://codereview.chromium.org/2982473002
Cr-Commit-Position: refs/heads/master@{#485764}

[modify] https://crrev.com/9e11581c14be9b15a9ac690d6a62483fbb92abd8/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/9e11581c14be9b15a9ac690d6a62483fbb92abd8/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/9e11581c14be9b15a9ac690d6a62483fbb92abd8/content/browser/zoom_browsertest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2303f1d6f15af92835125298d092b6a19063b38a

commit 2303f1d6f15af92835125298d092b6a19063b38a
Author: lukasza <lukasza@chromium.org>
Date: Wed Jul 12 01:27:31 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=raymes@chromium.org

Review-Url: https://codereview.chromium.org/2974343002
Cr-Commit-Position: refs/heads/master@{#485768}

[modify] https://crrev.com/2303f1d6f15af92835125298d092b6a19063b38a/chrome/browser/geolocation/geolocation_browsertest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6b4b2a6760bfaef7ec1ba72e5369fd99351ce71

commit a6b4b2a6760bfaef7ec1ba72e5369fd99351ce71
Author: lukasza <lukasza@chromium.org>
Date: Wed Jul 12 01:29:54 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2977733002
Cr-Commit-Position: refs/heads/master@{#485771}

[modify] https://crrev.com/a6b4b2a6760bfaef7ec1ba72e5369fd99351ce71/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcbb1b6ea802c3490dab3ee1ff1ab2ce1c58e156

commit dcbb1b6ea802c3490dab3ee1ff1ab2ce1c58e156
Author: lukasza <lukasza@chromium.org>
Date: Wed Jul 12 01:30:49 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=creis@chromium.org

Review-Url: https://codereview.chromium.org/2980673002
Cr-Commit-Position: refs/heads/master@{#485773}

[modify] https://crrev.com/dcbb1b6ea802c3490dab3ee1ff1ab2ce1c58e156/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08a9521d2776ab1601fd6010ce055939cde43946

commit 08a9521d2776ab1601fd6010ce055939cde43946
Author: lukasza <lukasza@chromium.org>
Date: Wed Jul 12 01:58:07 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=raymes@chromium.org

Review-Url: https://codereview.chromium.org/2982483002
Cr-Commit-Position: refs/heads/master@{#485790}

[modify] https://crrev.com/08a9521d2776ab1601fd6010ce055939cde43946/ppapi/tests/test_case.html
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0196cbd5239c2ebd82b8cdb478f16e7f909e3cb

commit d0196cbd5239c2ebd82b8cdb478f16e7f909e3cb
Author: lukasza <lukasza@chromium.org>
Date: Wed Jul 12 02:35:08 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=aelias@chromium.org

Review-Url: https://codereview.chromium.org/2981563002
Cr-Commit-Position: refs/heads/master@{#485812}

[modify] https://crrev.com/d0196cbd5239c2ebd82b8cdb478f16e7f909e3cb/content/browser/renderer_host/render_widget_host_view_browsertest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bd45405064ad250f27663f089a00af8769244bc

commit 6bd45405064ad250f27663f089a00af8769244bc
Author: lukasza <lukasza@chromium.org>
Date: Wed Jul 12 15:25:14 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=nasko@chromium.org

Review-Url: https://codereview.chromium.org/2978693002
Cr-Commit-Position: refs/heads/master@{#485958}

[modify] https://crrev.com/6bd45405064ad250f27663f089a00af8769244bc/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbe11ccccad66e2228b1622adda81dc651042788

commit dbe11ccccad66e2228b1622adda81dc651042788
Author: lukasza <lukasza@chromium.org>
Date: Wed Jul 12 15:32:36 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=avi@chromium.org

Review-Url: https://codereview.chromium.org/2976803002
Cr-Commit-Position: refs/heads/master@{#485961}

[modify] https://crrev.com/dbe11ccccad66e2228b1622adda81dc651042788/chrome/browser/site_per_process_interactive_browsertest.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69865754e32f123cc290989423647504c4aa86c2

commit 69865754e32f123cc290989423647504c4aa86c2
Author: lukasza <lukasza@chromium.org>
Date: Wed Jul 12 15:56:27 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2974983002
Cr-Commit-Position: refs/heads/master@{#485978}

[modify] https://crrev.com/69865754e32f123cc290989423647504c4aa86c2/chrome/browser/chrome_service_worker_browsertest.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80b7c8a8aae2c2f9472962e59b11fb619d52d420

commit 80b7c8a8aae2c2f9472962e59b11fb619d52d420
Author: lukasza <lukasza@chromium.org>
Date: Wed Jul 12 21:46:52 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2979783002
Cr-Commit-Position: refs/heads/master@{#486098}

[modify] https://crrev.com/80b7c8a8aae2c2f9472962e59b11fb619d52d420/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a8995615b091ab5aed072b742d98eb441f41bb8

commit 0a8995615b091ab5aed072b742d98eb441f41bb8
Author: lukasza <lukasza@chromium.org>
Date: Thu Jul 13 05:22:03 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=davidben@chromium.org

Review-Url: https://codereview.chromium.org/2980683002
Cr-Commit-Position: refs/heads/master@{#486278}

[modify] https://crrev.com/0a8995615b091ab5aed072b742d98eb441f41bb8/chrome/browser/ui/login/login_interstitial_delegate.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c87d5b108ffc143f32a7a0d5d77d77d67c355ae

commit 8c87d5b108ffc143f32a7a0d5d77d77d67c355ae
Author: lukasza <lukasza@chromium.org>
Date: Fri Jul 14 01:21:41 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=mattm@chromium.org

Review-Url: https://codereview.chromium.org/2979773002
Cr-Commit-Position: refs/heads/master@{#486598}

[modify] https://crrev.com/8c87d5b108ffc143f32a7a0d5d77d77d67c355ae/components/security_interstitials/core/common/resources/interstitial_common.js
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1431083215d32c6af92fa27cbb89d45d6815eda

commit c1431083215d32c6af92fa27cbb89d45d6815eda
Author: lukasza <lukasza@chromium.org>
Date: Fri Jul 14 02:19:14 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=michaelpg@chromium.org

Review-Url: https://codereview.chromium.org/2974323003
Cr-Commit-Position: refs/heads/master@{#486638}

[modify] https://crrev.com/c1431083215d32c6af92fa27cbb89d45d6815eda/ui/webui/resources/js/webui_resource_test.js
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab0cb861b3b6abef9d49d55fdf872a860e818aeb

commit ab0cb861b3b6abef9d49d55fdf872a860e818aeb
Author: lukasza <lukasza@chromium.org>
Date: Tue Jul 18 21:07:34 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=sehr@chromium.org

Review-Url: https://codereview.chromium.org/2980653003
Cr-Commit-Position: refs/heads/master@{#487605}

[modify] https://crrev.com/ab0cb861b3b6abef9d49d55fdf872a860e818aeb/ppapi/native_client/tools/browser_tester/browserdata/nacltest.js
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56933bcdf74463f0df578118fb00c1faf93fb9bb

commit 56933bcdf74463f0df578118fb00c1faf93fb9bb
Author: lukasza <lukasza@chromium.org>
Date: Tue Jul 18 23:07:12 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=agl@chromium.org

Review-Url: https://codereview.chromium.org/2975983002
Cr-Commit-Position: refs/heads/master@{#487649}

[modify] https://crrev.com/56933bcdf74463f0df578118fb00c1faf93fb9bb/chrome/browser/ssl/ssl_browser_tests.cc
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe9cc5ebcb4a02561eb090c3c8f0ca4788e0aacb

commit fe9cc5ebcb4a02561eb090c3c8f0ca4788e0aacb
Author: lukasza <lukasza@chromium.org>
Date: Wed Jul 19 20:18:41 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=tommi@chromium.org

Review-Url: https://codereview.chromium.org/2977633004
Cr-Commit-Position: refs/heads/master@{#487944}

[modify] https://crrev.com/fe9cc5ebcb4a02561eb090c3c8f0ca4788e0aacb/content/public/test/browser_test_utils.cc
Project Member

Comment 22 by bugdroid1@chromium.org, Aug 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2

commit c91fdd56c49d8c96889c4dafe0ed1f585a0632b2
Author: lukasza <lukasza@chromium.org>
Date: Mon Aug 21 23:54:34 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG= 662543 
This CL was uploaded by git cl split.

R=nick

Review-Url: https://codereview.chromium.org/2976793002
Cr-Commit-Position: refs/heads/master@{#496129}

[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/ads_observer/docwrite_provisional_frame.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/automation/sends_message_on_load.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/chrome_extension_resource.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/drag_and_drop/event_monitoring.js
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/gpu/canvas_popup.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/gpu/feature_canvas2d.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/gpu/feature_multisampling.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/gpu/feature_raf_no_damage.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/gpu/feature_webgl.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/gpu/webgl_conformance.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/gpu/webgl_popup.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/keyevents_test.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/local_ntp_browsertest.js
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/page_with_focus_events.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/password/frame_detached_on_submit.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/password/password_fetch_submit.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/password/password_xhr_submit.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/popup_iframe.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/supervised_user/with_iframes.html
[modify] https://crrev.com/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2/chrome/test/data/tab-restore-visibility.html
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e72ec855f95e9c37078bbeb2469fc96e653e0c03

commit e72ec855f95e9c37078bbeb2469fc96e653e0c03
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Tue Aug 22 16:29:54 2017

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

Bug:  662543 
Change-Id: I6b41f25666e85bca88678a5955f27aeb121ea453
Tbr: nick@chromium.org, ncarter@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/624819
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496325}
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/cross_site_document_request.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/fullscreen_frame.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/concave_paths.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/filter_effects.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/functional_3d_css.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/functional_canvas_demo.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/functional_files/context.js
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/functional_video.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_background.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_browser_plugin.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_canvas2d.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_canvas2d_accelerated.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_canvas2d_untagged.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_canvas2d_webgl.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_canvas_display_linear-rgb.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_css3d.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_worker.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_offscreenCanvas_2d_resize_on_worker.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_offscreenCanvas_transferToImageBitmap_main.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_offscreenCanvas_transferToImageBitmap_worker.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_offscreenCanvas_transfer_after_style_resize.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_offscreenCanvas_transfer_before_style_resize.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_main.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_offscreenCanvas_webgl_resize_on_worker.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_scissor.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_video_mp4.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_video_vp9.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_webgl_noalpha_implicit_clear.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/pixel_webgl_util.js
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/gpu/webgl.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/net_info.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/page_with_blur.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/page_with_input_field.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/post_message.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/resource_loading/resource_loading_non_mobile.html
[modify] https://crrev.com/e72ec855f95e9c37078bbeb2469fc96e653e0c03/content/test/data/simple_database.html
Project Member

Comment 24 by bugdroid1@chromium.org, Sep 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2daf02a9104a0a2ac2241e6d0cdc46566677e6f

commit d2daf02a9104a0a2ac2241e6d0cdc46566677e6f
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Tue Sep 05 20:20:54 2017

Remove domAutomationController.setAutomationId/sendWithId/sendJSON.

The 3 methods can be removed, because:

*) domAutomationController.setAutomationId is a no-op after r485461
*) after a series of CLs associated with  bug 662543 , there are no
   more calls to domAutomationController.setAutomationId

*) this CL replaces the only 2 calls of
   domAutomationController.sendWithId with calls to
   domAutomationController.send (they are equivalent, because the
   |automation_id| parameter has been ignored r350364)

*) there were/are no callers of
   domAutomationController.sendJSON

Bug:  662543 
Change-Id: Iab8b2034861b2096ff5b7b24329d600e6fb0b89c
Reviewed-on: https://chromium-review.googlesource.com/626697
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499728}
[modify] https://crrev.com/d2daf02a9104a0a2ac2241e6d0cdc46566677e6f/chrome/test/data/apptest/basic.html
[modify] https://crrev.com/d2daf02a9104a0a2ac2241e6d0cdc46566677e6f/content/renderer/dom_automation_controller.cc
[modify] https://crrev.com/d2daf02a9104a0a2ac2241e6d0cdc46566677e6f/content/renderer/dom_automation_controller.h
[modify] https://crrev.com/d2daf02a9104a0a2ac2241e6d0cdc46566677e6f/google_apis/test/service_login.html

Comment 25 by lukasza@chromium.org, Sep 5 2017

Cc: a...@chromium.org
Status: Fixed (was: Started)
This should be fixed now.  Let's hope that all the CLs will stick.
Project Member

Comment 26 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23cf5bd6421dbcf33675df786136983141a5456a

commit 23cf5bd6421dbcf33675df786136983141a5456a
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Thu Nov 16 18:02:24 2017

Fix domAutomationController.sendWithId -> send transition from r499728.

r499728 has incorrectly translated domAutomationController.sendWithId
calls into domAutomationController.send calls - the first argument of
the calls should have been dropped.  This CL fixes this.

Bug:  662543 
Change-Id: If06e033ddddfe3e86000c2cbd68e49f9039dd706
Reviewed-on: https://chromium-review.googlesource.com/741921
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517121}
[modify] https://crrev.com/23cf5bd6421dbcf33675df786136983141a5456a/chrome/test/data/apptest/basic.html
[modify] https://crrev.com/23cf5bd6421dbcf33675df786136983141a5456a/google_apis/test/service_login.html
►

Sign in to add a comment