sizes step failing on Mac Builder |
|||||
Issue descriptionhttps://build.chromium.org/p/chromium.perf/builders/Mac%20Builder/builds/50899 is an example build. The sizes step fails, with this traceback: Traceback (most recent call last): File "/b/rr/tmppEbI4_/rw/checkout/infra/.recipe_deps/build/scripts/slave/runtest.py", line 1782, in <module> sys.exit(main()) File "/b/rr/tmppEbI4_/rw/checkout/infra/.recipe_deps/build/scripts/slave/runtest.py", line 1745, in main result = _MainMac(options, args, extra_env) File "/b/rr/tmppEbI4_/rw/checkout/infra/.recipe_deps/build/scripts/slave/runtest.py", line 1015, in _MainMac log_processor, _ResultsDashboardDict(options)): File "/b/rr/tmppEbI4_/rw/checkout/infra/.recipe_deps/build/scripts/slave/runtest.py", line 584, in _SendResultsToDashboard return results_dashboard.SendResults(results, args['url'], args['build_dir']) File "/b/rr/tmppEbI4_/rw/checkout/infra/.recipe_deps/build/scripts/slave/results_dashboard.py", line 51, in SendResults link_annotation = _LinkAnnotation(url, data) File "/b/rr/tmppEbI4_/rw/checkout/infra/.recipe_deps/build/scripts/slave/results_dashboard.py", line 433, in _LinkAnnotation urllib.quote(master), urllib.quote(bot), urllib.quote(test.split('/')[0]), File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib.py", line 1290, in quote raise TypeError('None object cannot be quoted') TypeError: None object cannot be quoted I'm not sure why it's failing. I recently restarted the master several times, so that might have something to do with it? It's not super urgent, because builds are being triggered.
,
Nov 7 2016
If you look at the logs, you can see the JSON sent to the perf dashboard in the line after "Sending result 1 of 26 to dashboard."
In the JSON, "master" is set to null in all of them, as below (pretty printed for readability):
[
{
"supplemental_columns": {
"a_stdio_uri": "[Buildbot stdio](http:\/\/build.chromium.org\/p\/chromium.perf\/builders\/Mac%20Builder\/builds\/50845\/steps\/sizes\/logs\/stdio)",
"r_commit_pos": 429893,
"r_clang_rev": "284979",
"r_chromium": "8a651fecaa57d4a7c368994ab59d70774bb92b49",
"r_webkit_rev": "429893"
},
"bot": "mac",
"value": "9284.0",
"units": "bytes",
"master": null,
"error": "0.0",
"test": "sizes\/GoogleChrome",
"revision": 429893
},
Emily, Dave, any ideas how this gets passed in? It's really weird because master is set correctly to 'ChromiumPerf' in the _LinkAnnotation() method of https://cs.chromium.org/chromium/build/scripts/slave/results_dashboard.py which outputs:
@@@STEP_LINK@Results Dashboard@https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=mac&tests=sizes&rev=430356@@@
,
Nov 7 2016
Note, backup JSON may have to be cleared out after the fix, since it is currently retried.
,
Nov 7 2016
[Assigning back to Stephen to fix broken master name]
,
Nov 9 2016
Ping on this? The step is purple and we are losing data for sizes.
,
Nov 9 2016
Tentatively fixed; will watch https://build.chromium.org/p/chromium.perf/buildslaves/vm175-m1 to see if it turns green (it should).
,
Nov 9 2016
Ok, manually fixed in https://build.chromium.org/p/chromium.perf/builders/Mac%20Builder/builds/51958 Will apply to all machines.
,
Nov 9 2016
Applied to all machines. Things seem to be recovering.
,
Nov 9 2016
Awesome! Thanks. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by martiniss@chromium.org
, Nov 7 2016Status: Assigned (was: Available)