New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662521 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Chrome Release Plan - Incorrect Dates.

Project Member Reported by manoranj...@chromium.org, Nov 4 2016

Issue description

Chrome release plan is showing in-correct release dates. Di, can you please take a look?

Please refer auto email from dimu@ with Sub: [chrome-pmo] Chrome Release Plan - Sun Nov 06 2016

Thank you!
 
Cc: mmoss@chromium.org bustamante@chromium.org

Comment 2 by dimu@google.com, Nov 4 2016

Cc: amineer@chromium.org
I'm taking a look at the Tabler AppScript..I never changed anything since I started to run it, so there might be a hidden bug.

Comment 3 by dimu@google.com, Nov 4 2016

I believe it's a bug due to daylight saving changes.
We are currently adding 1000*60*60*24*(# of days to Monday) to the current datetime, to get the Monday's date.
However, we are 1hrs more away to Monday due to daylight savings now...
That's why the script calcualted "Sun Nov 06 23:00:00 GMT-08:00 2016" instead of Monday at 00:00:00.

Reference: the current function
function CalculateNextMonday() {
    var d = new Date();
    d.setHours(0, 0, 0, 0);
    var n = d.getDay();
    var days = 0;
    if (n == 0) {
        days = 1;
    }
    else {
        days = 8 - n;
    }
    return new Date(d.getTime() + (1000*60*60*24*days));
}

Comment 4 by mmoss@chromium.org, Nov 4 2016

Cc: stip@chromium.org
+stip, he knows why :)
That's weird, I thought AppScript was executing in PST context and so daylight saving's time wouldn't affect it (until next week)?

Should we hedge our bets and add 60*60*2 (2 hours) to pad and hopefully avoid this in the future?

Comment 6 by stip@chromium.org, Feb 10 2017

Cc: -stip@chromium.org
Cc: -amineer@chromium.org
No longer on the Chrome team, e-mail me @google.com if any attention still required from me here, otherwise good luck!

Sign in to add a comment