New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662517 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

GlobalShortcutListenerOzone spews Not implemented reached in virtual bool for RegisterAcceleratorImpl in file:///var/log/chrome/chrome at boot

Project Member Reported by djkurtz@chromium.org, Nov 4 2016

Issue description

Chrome Version: 55.0.2883.35
Chrome OS Version: 8872.35.0
Chrome OS Platform: elm

Steps To Reproduce:
(1) Sign in
(2) Inspect file:///var/log/chrome/chrome
(3)

Expected Result:

No RegisterAcceleratorImpl errors.

Actual Result:

[1238:1238:1104/140512:ERROR:component_loader.cc(154)] Failed to parse extension manifest.
[1238:1238:1104/140512:ERROR:global_shortcut_listener_ozone.cc(26)] GlobalShortcutListenerOzone object created
[1238:1238:1104/140512:ERROR:global_shortcut_listener_ozone.cc(48)] Not implemented reached in virtual bool extensions::GlobalShortcutListenerOzone::RegisterAcceleratorImpl(const ui::Accelerator&)
[1238:1238:1104/140512:ERROR:global_shortcut_listener_ozone.cc(48)] Not implemented reached in virtual bool extensions::GlobalShortcutListenerOzone::RegisterAcceleratorImpl(const ui::Accelerator&)
[1238:1238:1104/140512:ERROR:global_shortcut_listener_ozone.cc(48)] Not implemented reached in virtual bool extensions::GlobalShortcutListenerOzone::RegisterAcceleratorImpl(const ui::Accelerator&)
[1238:1238:1104/140512:ERROR:global_shortcut_listener_ozone.cc(48)] Not implemented reached in virtual bool extensions::GlobalShortcutListenerOzone::RegisterAcceleratorImpl(const ui::Accelerator&)
 
chrome-55.0.2883.35.txt
24.8 KB View Download
Cc: sky@chromium.org
Cc: mccreavy@google.com
It turns out these messages are generated when just a single of my extensions is enabled:

Google Play Music 1.341.0
dhgjflpimlbndpamnkoepaacagejgda

(Installed from: https://play.google.com/music/listen?u=0#/upload/mini)

With that extension installed, toggling 'Enabled' generates the following in /var/log/ui/ui.LATEST:

[16930:16930:1104/153846:ERROR:global_shortcut_listener_ozone.cc(48)] Not implemented reached in virtual bool extensions::GlobalShortcutListenerOzone::RegisterAcceleratorImpl(const ui::Accelerator&)
[16930:16930:1104/153846:ERROR:global_shortcut_listener_ozone.cc(48)] Not implemented reached in virtual bool extensions::GlobalShortcutListenerOzone::RegisterAcceleratorImpl(const ui::Accelerator&)
[16930:16930:1104/153846:ERROR:global_shortcut_listener_ozone.cc(48)] Not implemented reached in virtual bool extensions::GlobalShortcutListenerOzone::RegisterAcceleratorImpl(const ui::Accelerator&)
[16930:16930:1104/153846:ERROR:global_shortcut_listener_ozone.cc(48)] Not implemented reached in virtual bool extensions::GlobalShortcutListenerOzone::RegisterAcceleratorImpl(const ui::Accelerator&)
getrlimit(RLIMIT_NOFILE) failed
[16930:17120:1104/153847:ERROR:service_manager.cc(306)] Error: invalid Name: CEFEB7F37FB11F1210E7FB03A185834B
[1,4135575552:21:38:47.828697] Native Client module will be loaded at base address 0x0000000000000000

Comment 3 by derat@chromium.org, Nov 4 2016

Cc: -derat@chromium.org

Comment 4 by oka@chromium.org, Nov 7 2016

Cc: oka@chromium.org

Comment 5 by oka@chromium.org, Nov 7 2016

crbug/662835 might be caused by this issue.

Comment 6 by oka@chromium.org, Nov 7 2016

http://crbug/662835 might be caused by this issue.

Comment 7 by oka@chromium.org, Nov 8 2016

Cc: weifangsun@chromium.org
Labels: M-56

Comment 8 by oka@chromium.org, Nov 10 2016

Can anyone take this issue? This could be the cause of http://crbug/662835 (I'm not sure though).
The line equivalent to
[1238:1238:1104/140512:ERROR:component_loader.cc(154)] Failed to parse extension manifest.
is also reported in crbug/662835.

Comment 9 by oka@chromium.org, Nov 10 2016

As written in http://crbug/662835, this issue is not elm specific, but observed on Kevin.
Chrome: 55.0.2883.34 beta
Chrome OS: 8872.34.0
Device: kevin-signed-mpkeys

Cc: thestig@chromium.org abodenha@chromium.org
Components: UI>Input>KeyboardShortcuts UI
Owner: abodenha@chromium.org
Status: Assigned (was: Available)
Summary: GlobalShortcutListenerOzone spews Not implemented reached in virtual bool for RegisterAcceleratorImpl in file:///var/log/chrome/chrome at boot (was: elm: GlobalShortcutListenerOzone spews Not implemented reached in virtual bool for RegisterAcceleratorImpl in file:///var/log/chrome/chrome at boot)
@#8/#9 -  issue 662835  is not related to the "Not implemented" messages.

Repro'ed on samus, so this is not Elm specific.

Registering Accelerators is not implemented in global_shortcut_listener_ozone.cc:

bool GlobalShortcutListenerOzone::RegisterAcceleratorImpl(
    const ui::Accelerator& accelerator) {
  NOTIMPLEMENTED();
  // To implement:
  // 1) Convert modifiers to platform specific modifiers.
  // 2) Register for the hotkey.
  // 3) If not successful, return false.
  // 4) Else, return true.

  return false;
}


It is implemented in global_shortcut_listener_chromeos.cc:

bool GlobalShortcutListenerChromeOS::RegisterAcceleratorImpl(
    const ui::Accelerator& accelerator) {
  LOG(ERROR) << __func__;
  ash::AcceleratorController* controller =
      ash::WmShell::Get()->accelerator_controller();
  if (controller->IsRegistered(accelerator)) {
    LOG(ERROR) << __func__ << " accelerator not registered";
    return false;
  }

However, BUILD.gn has some interesting logic that removes the 'chromeos' version if using chromeos & ozone:

  if (is_chromeos && use_ozone) {
    sources -= [ "global_shortcut_listener_chromeos.cc" ]
  }

So is this WAI, and Chrome OS/Ozone currently does not allow extensions to register (global) accelerators?
Owner: r...@chromium.org

Comment 12 by st...@chromium.org, Nov 12 2016

Owner: st...@chromium.org
Owner: r...@chromium.org

Comment 14 by r...@chromium.org, Mar 26 2017

Owner: rdevlin....@chromium.org
I have no context on this bug. Since this is part of extensions, assigning to Devlin to triage.

Components: -UI

Sign in to add a comment