New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 662515 link

Starred by 2 users
Status: Fixed
Owner:
█ yzshen@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
█ yzshen@chromium.org
sky@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 624136



Sign in to add a comment

Switch mojom target services/ui/public/interfaces to use STL types

Project Member Reported by yzshen@chromium.org, Nov 4 2016 
At the moment, the target have the following flag:
  use_new_wrapper_types = false

That maps mojo string/array/map to mojo::String/Array/Map.
The new way is to remove this flag. And the generator will use STL types, mapping mojo string/array/map to
std::string/std::vector/std::unordered_map (or base::Optional<std::string>/... if the types are nullable).

You could take a look at this document for more details:
https://docs.google.com/document/d/1dutUW6XUlbSJzsqmtmPnN-J7R8z-iEL-QJ_GR9hWKHg/edit#heading=h.8kjqdetcrav

Comment 1 by yzshen@chromium.org, Nov 4 2016 

Hi, Scott.
If you know who could take this, please let me know. Otherwise, I can take this (and work on it when I have got a chance). Thanks!

Comment 2 by yzshen@chromium.org, Nov 16 2016

Owner: yzshen@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a5ee17d8ae92239f11977ceaf622e34cfe0772d

commit 6a5ee17d8ae92239f11977ceaf622e34cfe0772d
Author: yzshen <yzshen@chromium.org>
Date: Mon Nov 21 17:43:28 2016

Mojo C++ bindings: switch services/ui/public/interfaces mojom target to use STL types.

BUG= 662515 

Review-Url: https://codereview.chromium.org/2511883006
Cr-Commit-Position: refs/heads/master@{#433581}

[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/mojo/public/cpp/bindings/map.h
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/public/cpp/tests/test_window_tree.cc
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/public/cpp/tests/test_window_tree.h
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/public/cpp/tests/window_tree_client_private.cc
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/public/cpp/tests/window_tree_client_unittest.cc
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/public/cpp/window.cc
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/public/cpp/window_tree_client.cc
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/public/cpp/window_tree_client.h
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/public/interfaces/BUILD.gn
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/ws/display.cc
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/ws/display.h
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/ws/test_change_tracker.cc
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/ws/test_change_tracker.h
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/ws/test_utils.cc
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/ws/test_utils.h
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/ws/window_tree.cc
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/ws/window_tree.h
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/services/ui/ws/window_tree_unittest.cc
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/ui/aura/mus/drag_drop_controller_mus.cc
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/ui/aura/mus/window_tree_client_unittest.cc
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/ui/aura/test/mus/test_window_tree.cc
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/ui/aura/test/mus/test_window_tree.h
[modify] https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d/ui/aura/test/mus/window_tree_client_private.cc

Comment 6 by yzshen@chromium.org, Nov 21 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment