New issue
Advanced search Search tips

Issue 662512 link

Starred by 4 users

Issue metadata

Status: Duplicate
Merged: issue 456
Owner: ----
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Javascript alerts, confirm() and leave/reload prompts are modal to Chrome UI, not to individual tab

Reported by teo8...@gmail.com, Nov 4 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Safari/537.36

Steps to reproduce the problem:
As usual, you take the idiotic approach of restricting issues to comments, so I'm forced to open a new one.

https://bugs.chromium.org/p/chromium/issues/detail?id=456#c106

Reading comments 101 and 106, it seems that instead of fixing the issue somebody had the brilliant idea to completely eliminate alerts. WTF?!?

That would be completely retarded.

Unless, when they talk about "autodismissal", they are talking about something OPTIONAL. But in that case, that would not fix the issue at all, contrary to what comment 106 says

> once I get autodismissal working then I certainly would call this fixed

- Reopen  issue 456  to comments
- Eliminating alert() altogether is just ridiculous. It would breaks tons of existing webs. Is that even standard compliant??
- What about confirm()? You certainly cannot get rid of that. Being able to ask confirmation to the user is a vital functionality, and eliminating it would break even more existing code,  and pose security risks, so the issue still persists for confirm() dialogs
- the issue also affect leave/reload-page confirmation dialogs. Are you planning to remove those as well?? 
- If the concern is malicious content abusing dialogs, the checkbox to prevent new ones already exists, and if that doesn't work enough that's a separate issue that needs to be addressed. You don't get rid of it by getting rid of dialogs altogether. Otherwise we may as well get rid of the browser to prevent it from opening malicious web content.

What is the expected behavior?

What went wrong?
....

Did this work before? N/A 

Chrome version: 53.0.2785.143  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 23.0 r0
 
Cc: a...@chromium.org

Comment 2 by a...@chromium.org, Nov 8 2016

Mergedinto: 456
Status: Duplicate (was: Unconfirmed)

Comment 3 by a...@chromium.org, Nov 8 2016

- Eliminating alert() altogether is just ridiculous. It would breaks tons of existing webs. Is that even standard compliant??

We are not eliminating alert().

- What about confirm()? You certainly cannot get rid of that. Being able to ask confirmation to the user is a vital functionality, and eliminating it would break even more existing code,  and pose security risks, so the issue still persists for confirm() dialogs

We are not eliminating confirm().

- the issue also affect leave/reload-page confirmation dialogs. Are you planning to remove those as well?? 

We are not eliminating onbeforeunload dialogs.

- [...] You don't get rid of it by getting rid of dialogs altogether.

We are not eliminating dialogs.

Comment 4 by teo8...@gmail.com, Nov 8 2016

Cool. So
1- what's the autodismissing thing mentioned in comment 106 of  issue 456 ?
2- how does it address the problem of dialogs being modal to the entire ui rather than the tab they belong to?
3- why do you keep the issue restricted to comments forcing us to discuss this in a duplicate issue?

Comment 5 by a...@chromium.org, Nov 8 2016

1- what's the autodismissing thing mentioned in comment 106 of  issue 456 ?

See my work in  bug 629964 .

2- how does it address the problem of dialogs being modal to the entire ui rather than the tab they belong to?

Dialogs will be attached to a tab, and when you switch away from the tab it will dismiss the dialog. That is the "auto-dismissing" bit. This also will allow you to just close a tab while it has a dialog up.

3- why do you keep the issue restricted to comments forcing us to discuss this in a duplicate issue?

Here's the thing: the bugtracker is a tool for Chromium developers to get their work done, a place for technical discussions. Hot bugs like that one attract hundreds of people who post comments like, "I also have this problem!"

While I appreciate that users have problems, them venting on the tool that Chromium developers use to get their work done actively prevents work from getting done. In addition, the emotion level on bugs like that tends to escalate until it ends up with posts about how Chromium developers are incompetent to not have fixed it by now, or don't care about their users to not have fixed it by now, etc.

That's why we lock bugs like that down. We track the importance of the issues to users with star counts, but the bug tracker isn't the place for discussions other than technical ones on how to fix things.

In any case, I've had my eye on  bug 456  for a while, but it wasn't until not too long ago that I had the inspiration about how to fix it (see the design document at http://bit.ly/project-oldspice ). We're testing these dialogs now, and I'm excited to see if it helps. I hope it does.

Sign in to add a comment