Image: unify drawTiled() methods |
||||
Issue descriptionImage class in Blink has 2 methods for rendering tiled content: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/graphics/Image.h?sq=package:chromium&l=197 It would be nice to unify those methods or properly name them (e.g. drawTiledBorder(), drawTiledBackground()). The original FIXME: // FIXME: Merge with the other drawTiled() function eventually, since we need a // combination of both for some things.
,
Nov 4 2016
,
Nov 28 2016
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d224832bf10e21a898ce920921c862c0c600613 commit 7d224832bf10e21a898ce920921c862c0c600613 Author: adenilson.cavalcanti <adenilson.cavalcanti@arm.com> Date: Tue Nov 29 02:52:19 2016 Rename Image::drawTiled methods As they evolved to be quite different and the amount of common code is minimal, it just make sense to define which member function is used to render borders and which is used for backgrounds. BUG= 662504 Review-Url: https://codereview.chromium.org/2536883002 Cr-Commit-Position: refs/heads/master@{#434846} [modify] https://crrev.com/7d224832bf10e21a898ce920921c862c0c600613/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp [modify] https://crrev.com/7d224832bf10e21a898ce920921c862c0c600613/third_party/WebKit/Source/platform/graphics/Image.cpp [modify] https://crrev.com/7d224832bf10e21a898ce920921c862c0c600613/third_party/WebKit/Source/platform/graphics/Image.h
,
Dec 1 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by cavalcantii@chromium.org
, Nov 4 2016