Show a green "Updated" string next to price when it changes in Payment Request UI. |
|||||||
Issue description^^^
,
Nov 4 2016
Is there a video? Would be cool if it faded out after 10 seconds, but hwi@ might have better ideas ;)
,
Nov 4 2016
Fading in & Sliding in from bottom to up will be *nice to have*. Let me know if this is part of M56, then I can provide a motion spec.
,
Nov 4 2016
Also the fullsheet will have the same green text, correct?
,
Nov 5 2016
This is indeed part of M56 at Zach's request. Fullsheet will have the same text.
,
Nov 8 2016
Here is the requested video. What do you think?
,
Nov 10 2016
With a shorter animation
,
Nov 10 2016
Hi, could you please review this UI? Thanks!
,
Nov 10 2016
What's the duration for the fade-in? 225ms cubic-bezier(0.0, 0.0, 0.2, 1); (LinearOutSlowInInterpolator) might be good to use. Thanks!
,
Nov 10 2016
lgtm on my side
,
Nov 10 2016
Like this?
,
Nov 10 2016
LGTM - Thanks!
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d9dfefb340989c2cb8655bfbc3f6dd83d352c10 commit 0d9dfefb340989c2cb8655bfbc3f6dd83d352c10 Author: sebsg <sebsg@chromium.org> Date: Fri Nov 18 19:24:05 2016 [Payments] Add text when shopping card total is updated. BUG= 662503 Review-Url: https://codereview.chromium.org/2503543003 Cr-Commit-Position: refs/heads/master@{#433259} [modify] https://crrev.com/0d9dfefb340989c2cb8655bfbc3f6dd83d352c10/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java [modify] https://crrev.com/0d9dfefb340989c2cb8655bfbc3f6dd83d352c10/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/0d9dfefb340989c2cb8655bfbc3f6dd83d352c10/chrome/android/java/strings/android_chrome_strings.grd
,
Nov 19 2016
,
Nov 19 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/807d1e1ac6893de33045049e92a5ba0a568f9c1c commit 807d1e1ac6893de33045049e92a5ba0a568f9c1c Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Sat Nov 19 21:17:48 2016 [Merge M-56] [Payments] Add text when shopping card total is updated. BUG= 662503 Review-Url: https://codereview.chromium.org/2503543003 Cr-Commit-Position: refs/heads/master@{#433259} (cherry picked from commit 0d9dfefb340989c2cb8655bfbc3f6dd83d352c10) Review URL: https://codereview.chromium.org/2516913002 . Cr-Commit-Position: refs/branch-heads/2924@{#9} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/807d1e1ac6893de33045049e92a5ba0a568f9c1c/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java [modify] https://crrev.com/807d1e1ac6893de33045049e92a5ba0a568f9c1c/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/807d1e1ac6893de33045049e92a5ba0a568f9c1c/chrome/android/java/strings/android_chrome_strings.grd
,
Nov 19 2016
,
Jun 27 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by se...@chromium.org
, Nov 4 2016451 KB
451 KB View Download