Issue metadata
Sign in to add a comment
|
Add gesture to enable spoken feedback on touch-only CFM devices |
|||||||||||||||||||||||||||||
Issue descriptionSome Chrome OS devices only have a touch screen by default, and no keyboard - and others can convert into a mode where the keyboard is hidden and disabled. For those scenarios, we need an accessible way to enable spoken feedback using only the touch screen, so that blind users can access such systems without help. The gesture we decided on was that the user should hold down two fingers for several seconds. Moving the fingers, releasing a finger, or adding a third finger would all cancel the detection. While holding down the two fingers, a progress tick sound would play to indicate to the user that something is going to happen. The exact amount of time should be easy to configure.
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d commit e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d Author: dmazzoni <dmazzoni@chromium.org> Date: Tue Nov 15 06:20:43 2016 Toggle spoken feedback if two fingers are held down. Blind users need a way to toggle spoken feedback on devices that only have a touch screen, and devices that are temporarily in a mode where the keyboard is disabled. Add a class that watches for two fingers held down, plays a tick sound to let the user know something might happen, then toggles spoken feedback if two fingers remain down without moving for enough time. BUG= 662501 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2476843003 Cr-Commit-Position: refs/heads/master@{#432129} [modify] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/ash/ash_touch_exploration_manager_chromeos.cc [modify] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/ash/ash_touch_exploration_manager_chromeos.h [modify] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/ash/common/accessibility_delegate.h [modify] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/ash/common/default_accessibility_delegate.cc [modify] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/ash/common/default_accessibility_delegate.h [modify] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/chrome/browser/browser_resources.grd [modify] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/chrome/browser/chromeos/accessibility/accessibility_manager.cc [modify] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/chrome/browser/chromeos/accessibility/accessibility_manager.h [add] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_high.wav [add] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_low.wav [modify] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/chrome/browser/ui/ash/chrome_shell_delegate.cc [modify] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/chromeos/audio/chromeos_sounds.h [modify] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/ui/chromeos/BUILD.gn [add] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/ui/chromeos/touch_accessibility_enabler.cc [add] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/ui/chromeos/touch_accessibility_enabler.h [add] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/ui/chromeos/touch_accessibility_enabler_unittest.cc [modify] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/ui/chromeos/touch_exploration_controller.cc [modify] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/ui/chromeos/touch_exploration_controller.h [modify] https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d/ui/chromeos/touch_exploration_controller_unittest.cc
,
Nov 15 2016
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0151acedf182d1c16ccbe9ba4f56b10e8a0314d commit e0151acedf182d1c16ccbe9ba4f56b10e8a0314d Author: dmazzoni <dmazzoni@chromium.org> Date: Mon Nov 28 08:42:35 2016 Tweaks for: Toggle spoken feedback if two fingers are held down Change r432129 added a feature to toggle spoken feedback if the user holds down two fingers for a length of time. Based on feedback from UI review, don't play any audio feedback until 3.0 seconds, and then toggle at 5.0 seconds. Also record an actiontracking the fact that the audio feedback occurred at 3.0 seconds - we can compare that with the existing metric for toggling spoken feedback to see how often users are triggering the warning sound and how often they're triggering spoken feedback on purpose or by accident. BUG= 662501 Review-Url: https://codereview.chromium.org/2504233004 Cr-Commit-Position: refs/heads/master@{#434618} [modify] https://crrev.com/e0151acedf182d1c16ccbe9ba4f56b10e8a0314d/tools/metrics/actions/actions.xml [modify] https://crrev.com/e0151acedf182d1c16ccbe9ba4f56b10e8a0314d/ui/chromeos/touch_accessibility_enabler.cc [modify] https://crrev.com/e0151acedf182d1c16ccbe9ba4f56b10e8a0314d/ui/chromeos/touch_accessibility_enabler_unittest.cc
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2173f056c9a7faf6e4270cb46c264ace433e4e64 commit 2173f056c9a7faf6e4270cb46c264ace433e4e64 Author: dmazzoni <dmazzoni@chromium.org> Date: Thu Dec 01 01:35:51 2016 Revert "Toggle spoken feedback if two fingers are held down." Originally landed in r432129 and r434618. Reverting so we can merge the revert to M56, then will re-land and keep tweaking on trunk. BUG= 662501 , 667439 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=oshima,sadrul,michaelpg Review-Url: https://codereview.chromium.org/2535723008 Cr-Commit-Position: refs/heads/master@{#435519} [modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ash/ash_touch_exploration_manager_chromeos.cc [modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ash/ash_touch_exploration_manager_chromeos.h [modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ash/common/accessibility_delegate.h [modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ash/common/default_accessibility_delegate.cc [modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ash/common/default_accessibility_delegate.h [modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/chrome/browser/browser_resources.grd [modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/chrome/browser/chromeos/accessibility/accessibility_manager.cc [modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/chrome/browser/chromeos/accessibility/accessibility_manager.h [delete] https://crrev.com/1d83f16c4e8a49c614479bbd5e74f16aad7c8232/chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_high.wav [delete] https://crrev.com/1d83f16c4e8a49c614479bbd5e74f16aad7c8232/chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_low.wav [modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/chrome/browser/ui/ash/chrome_shell_delegate.cc [modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/chromeos/audio/chromeos_sounds.h [modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ui/chromeos/BUILD.gn [delete] https://crrev.com/1d83f16c4e8a49c614479bbd5e74f16aad7c8232/ui/chromeos/touch_accessibility_enabler.cc [delete] https://crrev.com/1d83f16c4e8a49c614479bbd5e74f16aad7c8232/ui/chromeos/touch_accessibility_enabler.h [delete] https://crrev.com/1d83f16c4e8a49c614479bbd5e74f16aad7c8232/ui/chromeos/touch_accessibility_enabler_unittest.cc [modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ui/chromeos/touch_exploration_controller.cc [modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ui/chromeos/touch_exploration_controller.h [modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ui/chromeos/touch_exploration_controller_unittest.cc
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2472b5999c08830451e70d903b49ce3e609cc0de commit 2472b5999c08830451e70d903b49ce3e609cc0de Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Thu Dec 01 21:02:40 2016 Merge to M56: Revert "Toggle spoken feedback if two fingers are held down." Originally landed in r432129 and r434618. Reverting so we can merge the revert to M56, then will re-land and keep tweaking on trunk. BUG= 662501 , 667439 TBR=oshima,sadrul,michaelpg CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review URL: https://codereview.chromium.org/2540333004 . Cr-Commit-Position: refs/branch-heads/2924@{#263} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ash/ash_touch_exploration_manager_chromeos.cc [modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ash/ash_touch_exploration_manager_chromeos.h [modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ash/common/accessibility_delegate.h [modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ash/common/default_accessibility_delegate.cc [modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ash/common/default_accessibility_delegate.h [modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/chrome/browser/browser_resources.grd [modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/chrome/browser/chromeos/accessibility/accessibility_manager.cc [modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/chrome/browser/chromeos/accessibility/accessibility_manager.h [delete] https://crrev.com/9a3c05c817412f456802d7e150d10a2c36eb9eff/chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_high.wav [delete] https://crrev.com/9a3c05c817412f456802d7e150d10a2c36eb9eff/chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_low.wav [modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/chrome/browser/ui/ash/chrome_shell_delegate.cc [modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/chromeos/audio/chromeos_sounds.h [modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ui/chromeos/BUILD.gn [delete] https://crrev.com/9a3c05c817412f456802d7e150d10a2c36eb9eff/ui/chromeos/touch_accessibility_enabler.cc [delete] https://crrev.com/9a3c05c817412f456802d7e150d10a2c36eb9eff/ui/chromeos/touch_accessibility_enabler.h [delete] https://crrev.com/9a3c05c817412f456802d7e150d10a2c36eb9eff/ui/chromeos/touch_accessibility_enabler_unittest.cc [modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ui/chromeos/touch_exploration_controller.cc [modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ui/chromeos/touch_exploration_controller.h [modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ui/chromeos/touch_exploration_controller_unittest.cc
,
Dec 16 2016
Gesture works (in M57+ now), and we'll follow up with the problems in other bugs.
,
Dec 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16d2dec10b4a9ae2259658a474cd6867f82d08e3 commit 16d2dec10b4a9ae2259658a474cd6867f82d08e3 Author: dmazzoni <dmazzoni@chromium.org> Date: Mon Dec 19 23:27:57 2016 Re-land: Toggle spoken feedback if two fingers are held down. Originally landed in r432129 and r434618, reverted in r435519 because it was triggering too often. Re-landing this time but modifying it to only apply to Chromebox For Meetings devices. Original CL: https://codereview.chromium.org/2476843003 BUG= 662501 , 667439 TBR=oshima,sadrul,michaelpg CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2584063002 Cr-Commit-Position: refs/heads/master@{#439611} [modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ash/ash_touch_exploration_manager_chromeos.cc [modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ash/ash_touch_exploration_manager_chromeos.h [modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ash/common/accessibility_delegate.h [modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ash/common/default_accessibility_delegate.cc [modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ash/common/default_accessibility_delegate.h [modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/chrome/browser/browser_resources.grd [modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/chrome/browser/chromeos/accessibility/accessibility_manager.cc [modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/chrome/browser/chromeos/accessibility/accessibility_manager.h [add] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_high.wav [add] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_low.wav [modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/chrome/browser/ui/ash/chrome_shell_delegate.cc [modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/chromeos/audio/chromeos_sounds.h [modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ui/chromeos/BUILD.gn [add] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ui/chromeos/touch_accessibility_enabler.cc [add] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ui/chromeos/touch_accessibility_enabler.h [add] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ui/chromeos/touch_accessibility_enabler_unittest.cc [modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ui/chromeos/touch_exploration_controller.cc [modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ui/chromeos/touch_exploration_controller.h [modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ui/chromeos/touch_exploration_controller_unittest.cc
,
Jan 4 2017
Build: 9147.0.0 / 57.0.2969.0 Hardware: Buddy GVC: 1.3.89.0 WCS: 20161212.05_p2 && GVC: 1.3.91.0 WCS: 20170103.05_p0 Few issues/Observations: 1) The Spoken feedback (VoX) is NOT enabled with 2 finger gesture, for the very first time after, it is disabled. Scenario: Gesture ( 2 fingers on the touch screen without movement) 1) Gesture -> VoX is enabled 2) Gesture -> VoX is disabled 3) Gesture -> No action 4) Gesture -> VoX is enabled 5) Gesture -> VoX is disabled 6) Gesture -> No action and so on .. 2) The VoX is activated, if we start touch with 2 fingers and lifts 1 finger up. I'm not sure if this behavior is accepted. 3) The greeting message is different when the VoX is enabled for the first time vs rest of the times. - This shall be maintained uniform across. First Time - Chrome Box Spoken Feedback is ready. Rest of the times - Google Hangouts 4) Tested touching the 3rd finger while VoX activation is in progress - Works fine 5) Tested scrolling the fingers while VoX activation is in progress, - works fine 6) Tested activating the VoX with Menu button on the remote - Works fine. Hence marking the issue as assigned.
,
Jan 4 2017
,
Jan 12 2017
,
Jan 20 2017
,
Jan 26 2017
Hi Laura, what do you make of the first scenario described in #9? Should spoken feedback toggle with each sequential 2 finger gesture?
,
Jan 27 2017
> Few issues/Observations: > 1) The Spoken feedback (VoX) is NOT enabled with 2 finger gesture, for the very > first time after, it is disabled. IIUC, the 2-finger long-hold to enable ChromeVox only works the first time, but subsequent attempts will disable it? If so, it should act as a toggle, and always enable/disable. > Scenario: Gesture ( 2 fingers on the touch screen without movement) > 1) Gesture -> VoX is enabled WAI > 2) Gesture -> VoX is disabled If this is after #1, it sounds WAI, as it is enable > disable. > 3) Gesture -> No action Should enable > 4) Gesture -> VoX is enabled Should disable > 5) Gesture -> VoX is disabled Should enable > 6) Gesture -> No action and so on .. Should disable > 2) The VoX is activated, if we start touch with 2 fingers and lifts 1 finger up. Bug. Non-intuitive and not-expected. > I'm not sure if this behavior is accepted. No, it's not :) > 3) The greeting message is different when the VoX is enabled for the first time It should be consistent, as the second time it's been enabled may be the first time that second user has enabled. > vs rest of the times. - This shall be maintained uniform > across. +1 to uniform > First Time - Chrome Box Spoken Feedback is ready. This should be on the first, nth, etc. of enabling cvox > Rest of the times - Google Hangouts It should utter focused window title after speaking that ChromeVox spoken feedback is ready > 4) Tested touching the 3rd finger while VoX activation is in progress - Works fine Interesting test, but shouldn't be officially supported, nor will be tried by users. > 5) Tested scrolling the fingers while VoX activation is in progress, - works fine Is this 2-fingers scroll? > 6) Tested activating the VoX with Menu button on the remote - Works fine. Excellent there's no regression. > Hence marking the issue as assigned. Thanks!
,
Jan 31 2017
,
Feb 10 2017
@dmazzoni, I am trying to verify this feature on M58 (58 / 9270.0.0 / 58.0.3007.0). I could not see any response on two finger gesture on the screen (buddy). Can you please let me know if this feature is enabled in M58? Also, can you let me know the flags / experimental features that need to be verified to ensure this feature is enabled?
,
Mar 3 2017
Hi dmazzoni, Can you please comment! I could not see any response on two finger gesture on the screen (buddy). Thanks.
,
Mar 10 2017
Hi, we were waiting to hear back from the CFM team about the best way to proceed. Adding Brian to this bug. He had said that the designers on the CFM team were working on pulling together some simple UI on their side that would appear when this gesture was used, to help educate the user on what's going on and avoid accidental triggers. Brian, where does this UI stand? Should we move forward on our side enabling this gesture for M58 like we had discussed in our previous meetings? Can we enable this without the corresponding UI if the UI piece will take longer?
,
Mar 13 2017
We need this feature for CFM's new touchscreen, Mimo. We would like you to move ahead. I don't see any problem enabling this without the UI
,
Mar 14 2017
Our ask from the CfM eng side is that we would like some sort of facility to turn this feature on and off. Perhaps through the https://developer.chrome.com/apps/accessibilityFeatures API? Our main concern is that features that are not controllable through an API limit the control we have over our user experience. The longpress for ChromeVox is a perfect example of when what seems like a perfectly reasonable solution turns out to be a problem for our end users.
,
Mar 16 2017
,
Mar 20 2017
What I thought we agreed at our last meeting was that we'd expose the gesture via an API, and then CFM would actually enable ChromeVox. That way if you want to change the timing or the behavior it'd all be entirely up to you. If I add an API to accessibilityFeatures that lets you detect the long-press, will your team commit to "wiring it up"? That way you'd be in control from now on, you could disable it, add a setting, add UI, etc. One other question - are you able to use private APIs without disruption? If your app is already priveleged and you can use any private API, using accessibilityPrivate might make more sense, so we don't have to commit to this as a public API.
,
Mar 27 2017
,
Mar 28 2017
CFM team, ping - does this sound good to you?
,
Mar 30 2017
My apologies, missed this thread. Yes, to expose the gesture via an API, and then have us trigger it sounds good! I assume this API will be in the form of an event that we will subscribe to? I think we need to sync on that design, I will follow up in an email. And yes, we are able to use private APIs. We already use the accessabilityPrivate API even.
,
Apr 4 2017
What we agreed on is the following (and please correct me if I misrepresent something): - Fire an event when the user starts holding down two fingers, and another when the user stops holding down two fingers. - App sets timers and enables/disables ChromeVox. - Events will be provided through the accessabilityPrivate API.
,
Apr 4 2017
That's correct. I'm going to try to finish this by April 13th so it gets in Chrome 59.
,
Apr 10 2017
Change uploaded for review: https://codereview.chromium.org/2808053004/
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df9a1e9283950cdbeaccfbd83587d424f4dc2436 commit df9a1e9283950cdbeaccfbd83587d424f4dc2436 Author: dmazzoni <dmazzoni@chromium.org> Date: Thu Apr 13 05:10:44 2017 Fire accessibilityPrivate events on two-finger hold gesture. ChromeBox for Meetings devices want a way to toggle spoken feedback when the user holds down two fingers. Use existing code that detects this gesture, but instead of toggling directly, fire private events on accessibilityPrivate that they can intercept and then trigger with their own UI and timing. BUG= 662501 Review-Url: https://codereview.chromium.org/2808053004 Cr-Commit-Position: refs/heads/master@{#464306} [modify] https://crrev.com/df9a1e9283950cdbeaccfbd83587d424f4dc2436/ash/accessibility_delegate.h [modify] https://crrev.com/df9a1e9283950cdbeaccfbd83587d424f4dc2436/ash/ash_touch_exploration_manager_chromeos.cc [modify] https://crrev.com/df9a1e9283950cdbeaccfbd83587d424f4dc2436/ash/ash_touch_exploration_manager_chromeos.h [modify] https://crrev.com/df9a1e9283950cdbeaccfbd83587d424f4dc2436/chrome/browser/chromeos/accessibility/accessibility_manager.cc [modify] https://crrev.com/df9a1e9283950cdbeaccfbd83587d424f4dc2436/chrome/browser/chromeos/accessibility/accessibility_manager.h [modify] https://crrev.com/df9a1e9283950cdbeaccfbd83587d424f4dc2436/chrome/browser/ui/ash/chrome_shell_delegate.cc [modify] https://crrev.com/df9a1e9283950cdbeaccfbd83587d424f4dc2436/chrome/common/extensions/api/accessibility_private.json [modify] https://crrev.com/df9a1e9283950cdbeaccfbd83587d424f4dc2436/extensions/browser/extension_event_histogram_value.h [modify] https://crrev.com/df9a1e9283950cdbeaccfbd83587d424f4dc2436/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/df9a1e9283950cdbeaccfbd83587d424f4dc2436/ui/chromeos/touch_accessibility_enabler.cc [modify] https://crrev.com/df9a1e9283950cdbeaccfbd83587d424f4dc2436/ui/chromeos/touch_accessibility_enabler.h [modify] https://crrev.com/df9a1e9283950cdbeaccfbd83587d424f4dc2436/ui/chromeos/touch_accessibility_enabler_unittest.cc
,
Apr 17 2017
@cederberg, can you take over from here and verify that the new API works and that you'll be able to build something based on that?
,
Apr 20 2017
,
Apr 20 2017
Looking into it.
,
Apr 20 2017
CfM work is tracked in http://b/37531413.
,
Apr 21 2017
,
Apr 21 2017
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/248a8e115572e07479edbe71820a90098f12a537 commit 248a8e115572e07479edbe71820a90098f12a537 Author: dmazzoni <dmazzoni@chromium.org> Date: Fri Apr 21 21:39:46 2017 Update externs for accessibilityPrivate The API was modified here: https://codereview.chromium.org/2808053004 BUG= 662501 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2834033003 Cr-Commit-Position: refs/heads/master@{#466453} [modify] https://crrev.com/248a8e115572e07479edbe71820a90098f12a537/third_party/closure_compiler/externs/accessibility_private.js
,
May 2 2017
,
Jun 22 2017
When testing the the two finger touch only the start event is triggered, both on start and on stop. It looks like there is a copy and past error here: https://cs.chromium.org/chromium/src/ash/ash_touch_exploration_manager_chromeos.cc?l=120&rcl=fc930616af698875d2e6a2a955326c7910f4059a Where elegate->OnTwoFingerTouchStart(); is called inside void AshTouchExplorationManager::OnTwoFingerTouchStop() { delegate->OnTwoFingerTouchStart(); should be: delegate->OnTwoFingerTouchStop();
,
Jun 22 2017
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80e7ad9bbb7e8d04e88b4793644c449b1c3d23e0 commit 80e7ad9bbb7e8d04e88b4793644c449b1c3d23e0 Author: felixe <felixe@chromium.org> Date: Mon Jun 26 23:29:08 2017 Call matching method on delegate Fix possible type and call delegate method with matching name. BUG= 662501 Review-Url: https://codereview.chromium.org/2955783003 Cr-Commit-Position: refs/heads/master@{#482461} [modify] https://crrev.com/80e7ad9bbb7e8d04e88b4793644c449b1c3d23e0/ash/ash_touch_exploration_manager_chromeos.cc
,
Jun 27 2017
,
Jun 27 2017
This bug requires manual review: There is .grd file changes and we are only 27 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 28 2017
To simplify for the merge reviewer I want to highlight that only the CL in http://crbug/662501#c40 need backporting (since the rest in on 60 already) and that the change is not complicated nor touching .grd files.
,
Jun 30 2017
ok, thanks for additional info. Approved for merge to M60
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e33b255fb06b2e54affeff01715c494db771de9 commit 2e33b255fb06b2e54affeff01715c494db771de9 Author: Guido Urdaneta <guidou@chromium.org> Date: Fri Jun 30 13:28:36 2017 Call matching method on delegate Fix possible type and call delegate method with matching name. BUG= 662501 TBR=felixe@chromium.org (cherry picked from commit 80e7ad9bbb7e8d04e88b4793644c449b1c3d23e0) Review-Url: https://codereview.chromium.org/2955783003 Cr-Original-Commit-Position: refs/heads/master@{#482461} Change-Id: I7eeefbbc8c988735193f975315a456c333c0c76b Reviewed-on: https://chromium-review.googlesource.com/558091 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#502} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/2e33b255fb06b2e54affeff01715c494db771de9/ash/ash_touch_exploration_manager_chromeos.cc
,
Aug 17 2017
,
Aug 17 2017
,
Aug 30 2017
,
Jan 22 2018
|
||||||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||||||
Comment 1 by lpalmaro@chromium.org
, Nov 4 2016